Received: by 10.223.185.116 with SMTP id b49csp3733127wrg; Mon, 19 Feb 2018 05:11:34 -0800 (PST) X-Google-Smtp-Source: AH8x227ABPNmvcfGr85oqD9dCzI9Dsy2JZ47JbWmYKPvQbpr4Ks+4Ffcn4oZhcVdsJZdpIOQBLpV X-Received: by 2002:a17:902:bd08:: with SMTP id p8-v6mr13939130pls.78.1519045894304; Mon, 19 Feb 2018 05:11:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519045894; cv=none; d=google.com; s=arc-20160816; b=yNMFFLSvSLr0Q+lt/lnqrbaNy4rG2NMjaoDhBLe9Or9nAZZ+qfyzF+Rd7gs9P70kun BHbmdOmfIDRFgaBBLMmJLJoiQOtWDDd8hTDJWnRWu4KEeMfegicNjflDql/1JNrepLwI RUfgUZwMVF9IFMEYN9urNCVqARNdKwN2k0LBjBUND8fQpAAyMR6f9ea/mJhQNHWWh4R1 zHWIgObTH3/dM/Nj5bs0y4LowjYj3Wkut9IjMFeZK9L1IQtZTvHa+v20/JEO8ilwuwdg HpftlFSi4012j3Ze8lvzKKivmVliqPs1tcM7tHrcVbm+eGD5uPSwD1KpAIsz7q+/nKay Nr5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=S2RU5MnAVQ5HZtel8uOmV4sIj5P2EKgiqVlxoCJbxHo=; b=zRo7KJV5t5u7pnvZEHdt8DBXbce9Vlkv+NXCVRjAPRnDiq7qCTrbJwajq+lZSWEG+h Ia6c5I81YxRtdN0g3kGsczzkTpLDJfwMmRCdWqjLOFzC2FM2Ale/mddjpfmJ0kCkxI3M 9e1Cft8bJDjl01Yd0FvK0E6OhY1WIyr52ywozpLsHWeVVuqrW+pB8R0TcDGoor/j9haI q88pcDr6w7KZcpm5fuU7GXYI7bmXaQ7MPWQN+CxCMhn+M9bp3OlXNEcL6oFqHarVEuOV dsu8/EFQGtwZv31HCervBBAwUn1+LLNj0nicXvTO7pP/DogOdDTTkoTSv4twjzXKZSZ4 3KGg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a34-v6si3949070pld.505.2018.02.19.05.11.18; Mon, 19 Feb 2018 05:11:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752772AbeBSNKU (ORCPT + 99 others); Mon, 19 Feb 2018 08:10:20 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:42516 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752687AbeBSNKR (ORCPT ); Mon, 19 Feb 2018 08:10:17 -0500 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 54E9F40363B6; Mon, 19 Feb 2018 13:10:17 +0000 (UTC) Received: from [10.36.116.114] (ovpn-116-114.ams2.redhat.com [10.36.116.114]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A48555033F; Mon, 19 Feb 2018 13:10:15 +0000 (UTC) Subject: Re: [PATCH 7/9] KVM/VMX: Emulate MSR_IA32_ARCH_CAPABILITIES To: Jim Mattson Cc: David Woodhouse , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , LKML , kvm list , KarimAllah Ahmed , Greg Kroah-Hartman , stable@vger.kernel.org References: <1517938181-15317-1-git-send-email-dwmw@amazon.co.uk> <1517938181-15317-8-git-send-email-dwmw@amazon.co.uk> <4be4e462-61be-53a9-b0e1-3508466d1645@redhat.com> From: Paolo Bonzini Message-ID: Date: Mon, 19 Feb 2018 14:10:11 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Mon, 19 Feb 2018 13:10:17 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Mon, 19 Feb 2018 13:10:17 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'pbonzini@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/02/2018 17:29, Jim Mattson wrote: > On Fri, Feb 16, 2018 at 6:18 AM, Paolo Bonzini wrote: > >> Uhm, taking contents from the hardware is wrong (guess why---live >> migration). I'll send a revert of those two lines. > > Hardware seems like a reasonable place to get the default value (cf. > the VMX capability MSRs). There are some differences: - a zero value for ARCH_CAPABILITIES should be safe, while a zero value for VMX capabilities doesn't really make sense. On the contrary, a nonzero value for ARCH_CAPABILITIES is not safe across live migration. - VMX doesn't support live migration; before adding that support we will probably have Tom's patches to retrieve MSR capabilities. Thanks, Paolo > Should these two lines just be moved to > vmx_create_cpu? >