Received: by 10.223.185.116 with SMTP id b49csp3773645wrg;
        Mon, 19 Feb 2018 05:52:03 -0800 (PST)
X-Google-Smtp-Source: AH8x227RwwUucq5H5cXuR8jZfilljxz17fjMifQSpCzC0oLHSI7YyqaxrnjzhI1QU7BkbzWtImQZ
X-Received: by 10.98.80.89 with SMTP id e86mr14586434pfb.46.1519048323135;
        Mon, 19 Feb 2018 05:52:03 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1519048323; cv=none;
        d=google.com; s=arc-20160816;
        b=PtiFNCtqAgTzYKXPDtnVPOHXW5oLFw5pmBZ4DZ49Mk8tVf9zvjHSjmkQvKDETqd0xZ
         wC8S66ZaKL3NYHesm0TdlHwE6dw+Rw54gCcDy9nsOhBiTgIzKzQb/vaKi560r/P6dpUV
         soujk8J75vE+Zs+rQqGFTBmHQaNbwshjD/48n3O0tHo27l0B8MiVGyGp5eorUmdxpknk
         5DHRd285NQrZEzcpAXdmu6ve/NKW1E4/agiqIe8kN3iXMpwZJuvvyMSJ9AdKWJmVeoSH
         9OLr2TWAhW6NG5R75o99fr1UgquKnVZemmI9Z1dSKVRIhzdZPwjSHgtTv1qmQOK2je+o
         Cq4w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:date:cc:to:from:subject:message-id
         :arc-authentication-results;
        bh=O4jZr8xfxn+AO4533yHBoII/p2+lDh9Gma7CY0tRW6Y=;
        b=0HXMWU1PwQMtdj5ibse8NDehomnD2bhA29F9IkPCvz/dYIhGhdjTPrTISEBgreb3nT
         QzNCqIFpF7RJXZ+HGsHHerrVqPNcKvlKlS8Wa3LM5RfEbYzHrechPEXdzq2agtprkVln
         0wB2Kz6BauMTHotIf4US8YFlx7xSXVtyXPpy+THAvGq1U9qrVRvQR/Qx8eBjAS/PZnrN
         eDsHDc5dmbMSdLjRnDE2bWjIOePD+RlZ2W2mIrCUaJwNgbxRBJFKQt6Md5Qb/Ns5l4y5
         K2XNqacoB7pVXQb75YvWLhHkj4hN3wXtmqc80htYGXDDYTMvma1TE8OIAMtl+dJgZEfH
         6dWw==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id 4-v6si5940228plf.402.2018.02.19.05.51.48;
        Mon, 19 Feb 2018 05:52:03 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752852AbeBSNty (ORCPT <rfc822;xc.haze2010@gmail.com>
        + 99 others); Mon, 19 Feb 2018 08:49:54 -0500
Received: from metis.ext.pengutronix.de ([85.220.165.71]:46513 "EHLO
        metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752753AbeBSNtx (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 19 Feb 2018 08:49:53 -0500
Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine)
        by metis.ext.pengutronix.de with esmtp (Exim 4.89)
        (envelope-from <p.zabel@pengutronix.de>)
        id 1enlp5-0004ib-EQ; Mon, 19 Feb 2018 14:49:39 +0100
Message-ID: <1519048168.3408.13.camel@pengutronix.de>
Subject: Re: [PATCH v5 05/12] drm/bridge/synopsys: dw-hdmi: don't clobber
 drvdata
From:   Philipp Zabel <p.zabel@pengutronix.de>
To:     Jernej Skrabec <jernej.skrabec@siol.net>,
        maxime.ripard@free-electrons.com, wens@csie.org, airlied@linux.ie,
        robh+dt@kernel.org, mark.rutland@arm.com, mturquette@baylibre.com,
        sboyd@kernel.org, architt@codeaurora.org, a.hajda@samsung.com,
        Laurent.pinchart@ideasonboard.com, narmstrong@baylibre.com,
        Jose.Abreu@synopsys.com
Cc:     dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-clk@vger.kernel.org, linux-sunxi@googlegroups.com,
        hjc@rock-chips.com, heiko@sntech.de
Date:   Mon, 19 Feb 2018 14:49:28 +0100
In-Reply-To: <20180214200906.31509-6-jernej.skrabec@siol.net>
References: <20180214200906.31509-1-jernej.skrabec@siol.net>
         <20180214200906.31509-6-jernej.skrabec@siol.net>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.22.6-1+deb9u1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17
X-SA-Exim-Mail-From: p.zabel@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false
X-PTX-Original-Recipient: linux-kernel@vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 2018-02-14 at 21:08 +0100, Jernej Skrabec wrote:
> dw_hdmi shouldn't set drvdata since some drivers might need to store
> it's own data there. Rework dw_hdmi in a way to return struct dw_hdmi
> instead to store it in drvdata. This way drivers are responsible to
> store and pass structure when needed.
> 
> Idea was taken from the following commit:
> 8242ecbd597d ("drm/bridge/synopsys: stop clobbering drvdata")
> 
> Cc: p.zabel@pengutronix.de
> Cc: narmstrong@baylibre.com
> Cc: Laurent.pinchart@ideasonboard.com
> Cc: hjc@rock-chips.com
> Cc: heiko@sntech.de
> Acked-by: Neil Armstrong <narmstrong@baylibre.com>
> Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>

For i.MX:
Tested-by: Philipp Zabel <p.zabel@pengutronix.de>
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>

regards
Philipp