Received: by 10.223.185.116 with SMTP id b49csp3926279wrg; Mon, 19 Feb 2018 08:13:56 -0800 (PST) X-Google-Smtp-Source: AH8x225mhKoB6qEzZK0BaIkPfpY2cU6Qe3Xp/z15HKrhsaosC9o33Zn9dnR8OigdQDjZYyZ9okI+ X-Received: by 2002:a17:902:6116:: with SMTP id t22-v6mr14648541plj.307.1519056835935; Mon, 19 Feb 2018 08:13:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519056835; cv=none; d=google.com; s=arc-20160816; b=gcd5BjE2GJuLA8SNpf0djqPabr8o5/YcsMF5Q9cfduD4h7RBRPBlXTqxWqGEildt9Z gMEn0NcRh7bs/l5znSqvYRplJcKFmx8JN6v9XrLHEGm+O++YvEYe8DZoitXFHiPDturg X+UpnAjeeYxiBY0KxSu7FGknPeeU6YMFHhk8dfdxfEdAls1hQ5G4zGxDNao6I/wUN0AX YX+RWwjyryzc75YRyPnIqi3dFZCgmBr90GlQXkixCENPKGtcpOf6lFxbZIPrL0hZNgCh YjIUEk4bfqaFrbushpX4sY1/tT8CnBCJGQdkUU3wv3ch5K8zDTNB3Ecf6FYddV+sXXqQ 3EAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=yg8FuuTd9/zAY/E+sYv93zMUWhRmqdjvZdbTSIx8GMg=; b=lXWtabATnfomHlaWJusYsICylT6Yw+a4BNvhFdW1VwgPacuUevdQEWo+V/k1DxmLAB NZ5j9Ynsi3QftG9iNP/o6ex8ykAXxWcrivNEoS1SCAGeN6cgFaWakaR+g0sIyWjraiNp 7GJjn8t5XNdCo2XXekKVvKvNukkhSoovFmiI3rCxxAyA5KSVYeL6dCVw339pFgkcI2h+ ftVsyDW1rbV/CUipsJG76trXnEOCogGcy/+18tTvuCWmz1f/hvtFm6QyYwNb2fVBT3wk y6diHQNSEIqPFkB7Z9dRTtrinGcTX5HSqd4fJc4nZsD0xPSOxcmRIHE+PQFaAMq3iroV N+PQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 13-v6si5655888plb.515.2018.02.19.08.13.41; Mon, 19 Feb 2018 08:13:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753185AbeBSQLm (ORCPT + 99 others); Mon, 19 Feb 2018 11:11:42 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:60922 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752857AbeBSQLk (ORCPT ); Mon, 19 Feb 2018 11:11:40 -0500 Received: from localhost (67.110.78.66.ptr.us.xo.net [67.110.78.66]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id F2BF813CD7FA4; Mon, 19 Feb 2018 08:11:39 -0800 (PST) Date: Mon, 19 Feb 2018 11:11:38 -0500 (EST) Message-Id: <20180219.111138.1929929854473154523.davem@davemloft.net> To: parri.andrea@gmail.com Cc: linux-kernel@vger.kernel.org, mst@redhat.com, jasowang@redhat.com, john.fastabend@gmail.com, edumazet@google.com, netdev@vger.kernel.org Subject: Re: [PATCH] ptr_ring: Remove now-redundant smp_read_barrier_depends() From: David Miller In-Reply-To: <1518779173-30812-1-git-send-email-parri.andrea@gmail.com> References: <1518779173-30812-1-git-send-email-parri.andrea@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 19 Feb 2018 08:11:40 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Andrea Parri Date: Fri, 16 Feb 2018 12:06:13 +0100 > Because READ_ONCE() now implies smp_read_barrier_depends(), the > smp_read_barrier_depends() in __ptr_ring_consume() is redundant; > this commit removes it and updates the comments. > > Signed-off-by: Andrea Parri Ok, if READ_ONCE() does a barrier now, this change makes sense. Applied to net-next, thank you.