Received: by 10.223.185.116 with SMTP id b49csp4010671wrg; Mon, 19 Feb 2018 09:29:33 -0800 (PST) X-Google-Smtp-Source: AH8x225IYavSXwPaea2g5wbqGUkgHQjl9X3KWWNMNahwpYEvmT4LUGFRKSz8eYRrVlAIV2ZU7B5G X-Received: by 10.99.121.131 with SMTP id u125mr10707222pgc.263.1519061373496; Mon, 19 Feb 2018 09:29:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519061373; cv=none; d=google.com; s=arc-20160816; b=OrEmf5tCCjLzCMj5ckiY7VNof61MGQK0QtFLFCZBECfoGfc8LSaFfObzYumZsDx17k nwmWtYt5SxyjWnScZJKT71veQTr0phiXs0rgXuygmD3Lz3Btqc7cOGkghlBjnBwNtB92 vYhX3vIgm7QkSBW/5Ipzq4sA5JtkaBLw+NKFqkcRerg67WGv3vmSOTTUeWqwsO3pZKP5 ClyOMvSHzru8yC30PLH24VHg5q139WQRQEtezwwz/5DOIBS2TE24/DfWxv5ZX9oAMrR2 mK+FyhbJBXvtqsm7Uf1g9KPcXfF+teUju7UCXvchQZhN0OxF2pgmcIgrpaeIQzoe4P/+ bRQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:references:in-reply-to:subject:cc:to:from :arc-authentication-results; bh=NHuOjGG2UphcF7eWevMiMyK2wWbg9mtTzj1qyWdtKjA=; b=UmggI03JrNcUaMHztezOYI5idBi3OxY+ttrmwb+wB5ybndZYoAmrmYMQK6rB6W48M7 fr4VGuK0BJfjSbFopPmIyuqmUbuEdrOZCodUxhABPEUjJOXftrHgIeNUm2AWwr/5gBJK 1mWBidKsup8d+UNKz/gie6jJN3FQHG0DLhSR7t3V9/Y199sIzRGxt1jJ3Du4G2TbomKX CXFykaBgqrOJCQl01uyK9UhDlvCJ8zs8FY5VTyEa55JWkkCy6joU+vscEstOa0/DnoU4 3LpbxpZPTN048+doABgrH+00nn8VfR5MzzKIbY7yP7A3zW1sLlaDEZiATjIRntqZY6Gv FttA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y64si798487pfj.47.2018.02.19.09.29.19; Mon, 19 Feb 2018 09:29:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753370AbeBSR1h convert rfc822-to-8bit (ORCPT + 99 others); Mon, 19 Feb 2018 12:27:37 -0500 Received: from smtp.nue.novell.com ([195.135.221.5]:54368 "EHLO smtp.nue.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753012AbeBSR1f (ORCPT ); Mon, 19 Feb 2018 12:27:35 -0500 Received: from localhost (nat.nue.novell.com [195.135.221.2]) by smtp.nue.novell.com with ESMTP (TLS encrypted); Mon, 19 Feb 2018 18:27:33 +0100 From: =?utf-8?Q?Aur=C3=A9lien?= Aptel To: "Gustavo A. R. Silva" , Steve French Cc: linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: Re: [PATCH] CIFS: fix sha512 check in cifs_crypto_secmech_release In-Reply-To: <20180219171113.GA16636@embeddedgus> References: <20180219171113.GA16636@embeddedgus> Date: Mon, 19 Feb 2018 18:27:32 +0100 Message-ID: <87zi4428l7.fsf@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Gustavo A. R. Silva" writes: > It seems this is a copy-paste error and that the proper variable to use > in this particular case is _sha512_ instead of _md5_. *sigh* I re-read this a lot yet still missed it. Minor memory leak fixed, good coverity catch and thanks for the fix! Reviewed-by: Aurelien Aptel -- Aurélien Aptel / SUSE Labs Samba Team GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3 SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)