Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] CIFS: fix sha512 check in cifs_crypto_secmech_release
To:     =?UTF-8?Q?Aur=c3=a9lien_Aptel?= <aaptel@suse.com>,
        "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
        Steve French <sfrench@samba.org>
Cc:     linux-cifs@vger.kernel.org, samba-technical@lists.samba.org,
        linux-kernel@vger.kernel.org
References: <20180219171113.GA16636@embeddedgus> <87zi4428l7.fsf@suse.com>
From:   "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Message-ID: <3eb514ff-d659-80ef-3e09-aa39c829f862@embeddedor.com>
Date:   Mon, 19 Feb 2018 12:13:54 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <87zi4428l7.fsf@suse.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Aurélien,

On 02/19/2018 11:27 AM, Aurélien Aptel wrote:
> "Gustavo A. R. Silva" <gustavo@embeddedor.com> writes:
>> It seems this is a copy-paste error and that the proper variable to use
>> in this particular case is _sha512_ instead of _md5_.
> 
> *sigh* I re-read this a lot yet still missed it. Minor memory leak
>   fixed, good coverity catch and thanks for the fix!
> 
> Reviewed-by: Aurelien Aptel <aaptel@suse.com>
> 

Glad to help. Thanks for the review.

BTW I think this should be sent to stable too.
--
Gustavo