Received: by 10.223.185.116 with SMTP id b49csp4107463wrg; Mon, 19 Feb 2018 11:12:49 -0800 (PST) X-Google-Smtp-Source: AH8x2271bZQ2P/Cq69WQ478xUJHwDsF9yfxCWHkSoEN2Xl70V5zk3h7Ud8nT0Iu0dOm/nwvzFJHw X-Received: by 2002:a17:902:4643:: with SMTP id o61-v6mr15477450pld.103.1519067569534; Mon, 19 Feb 2018 11:12:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519067569; cv=none; d=google.com; s=arc-20160816; b=GL7JZxKQD9G2La/eVDv+imlSePJRENomnfqB5aGmRgraSXI0pjc8dR6dP5VY4rq3Yy 4Ri7BtgEmYGcMchmRx1xCJ1asYrTGmJAUWqSqxYITKDs5yp+SLjtXngxgk4hEnH0oGuP 3vmKnhFy92vnS+OfIxQ2YKSAqBX8r/WYaqnFNqFDLQlDSC3gPwRDY6CQIs0QLDlb3Jm8 uI+VmWFimzNbWicl2KxkbB9lmxfB/vdV7Fg8vAkiTp60zxEFF+Xcsaw4eh23YW82lNoA /9fVhyVt9ZoqlCEV3LPeBMzUKOLiNMrVbH1dmk+HSfAIMjovGxmSZI38Wpn/WnZOH1Ob +Aew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date :arc-authentication-results; bh=57iNLO5SlPP8cKb2h7QwIpzoDNDFYueMlf7q9stGhZg=; b=yPRfBLuDVIpLi+YavwyiGo6Wf/3Cnng3mldUfbmDyfcBXJbvA8xF0KaUH3ufNvJjCf lMYqcS+dlkLVzKvBfWd09QQtW8A/at/5OIOkhd4A1HSAe5bwWx5NTxelnaL+nJwuPyW4 tO/ovZPVNei9wqK01O82vQHkvmFAfUyhyM9VFAv3BL1s+lqN5E1FougNrBL/co1EAa/K W39mTZtszLeUWVilsvnW44D5KIAdpOPftqKMtiXK9ZgLw1MrUH0uOKpym01OZFkDB67r TCpHXVAIiaJXtk4vNFw+YAcRKqzECtjJyzZCDhlfCMD9WfePrbVGo0fCkrcqjvTtXqp3 QEzA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q11si6545555pfi.35.2018.02.19.11.12.34; Mon, 19 Feb 2018 11:12:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753592AbeBSTLl (ORCPT + 99 others); Mon, 19 Feb 2018 14:11:41 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:35036 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753548AbeBSTLj (ORCPT ); Mon, 19 Feb 2018 14:11:39 -0500 Received: from localhost (67.110.78.66.ptr.us.xo.net [67.110.78.66]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 6FEC313EDB009; Mon, 19 Feb 2018 11:11:38 -0800 (PST) Date: Mon, 19 Feb 2018 14:11:37 -0500 (EST) Message-Id: <20180219.141137.2095980245673495027.davem@davemloft.net> To: fthain@telegraphics.com.au Cc: netdev@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org, linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH net 2/4] net/8390: Fix msg_enable patch snafu From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 19 Feb 2018 11:11:39 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Finn Thain Date: Sun, 18 Feb 2018 21:39:17 -0500 (EST) > The lib8390 module parameter 'msg_enable' doesn't do anything useful: > it causes an ancient version string to be logged. Since you are removing the last reference to this 'version' string you should remove it as well. I'm surprised the compiler doesn't warn about this.