Received: by 10.223.185.116 with SMTP id b49csp4140225wrg; Mon, 19 Feb 2018 11:54:28 -0800 (PST) X-Google-Smtp-Source: AH8x226UwZVcXdnD6G+gNyDWUTQwIHZCXZW8VKlSbVgG8TzysiJtDsxuAacdwuKNtAHRY+hahDjK X-Received: by 10.99.117.26 with SMTP id q26mr13599099pgc.46.1519070068352; Mon, 19 Feb 2018 11:54:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519070068; cv=none; d=google.com; s=arc-20160816; b=DkJzcKtOm7KS1XJIhhqCWSe9UmmtywwVCNPMUxnyFN9TuCofefn7141y7yJ2EmofW3 vo6ri1nrBtThHqyEhw8Amrko/M/iSqCce/l53+ZbJio0gJeNe/q6uaDJqYYeAWEsjczO dk1+KrsMtXh9TAq+9GJCAXtduFDJRjyzUwq8JQ5AVlsKR1zDCpx0J4MbBBzPd+UpKI/g NFg4ZiYle4GjiMuhZZxbD+QGRPirDdEEmvvr6LMEF42cLIVGyyGmME39k374XGOG01r1 nOCCTqKBi5T7RYxtn7+gikpg8+5a8Ktxy7SIROxjY22xIaeUXWkbz356ECO0pozOXX9U LP8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:arc-authentication-results; bh=AIVCSqSCujQTXZvwmOFB1RPPVCsl+iVsqZZMZVL+LQM=; b=mm3qMg4MU757ip5Jh4zxn1cHm/IX1a9HM6euLIpF1gqi3pU32yxs5O4T7oWlLhjPSC vVfpDNmA4VS3LzaI+pWjumlrKCk1q7ZDSF9eYgMMr1xT0JiyS0MLUcfnoZnqYJ1Xxlnv UoBBT9+80hMgXjHcwsK6kcUgXEIB3qsJuEuBXN2E6HpFnJ5HXPvW/GCwsV2MgLjmTcTt SzrmE0FEpjIKSxatjPdW7FcFmbNGh/GMxPlMMy2FBXMJyMeT5uNu5KjdheEd41rwbLqg 5UIO4QDje3AjXNJtH05GiGWIR8SCBhFcP0u6L67fNq672rnb5XwUpLazvEezWKFPIsj5 qpXg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z7si4228627pgv.473.2018.02.19.11.54.14; Mon, 19 Feb 2018 11:54:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932100AbeBSTw3 (ORCPT + 99 others); Mon, 19 Feb 2018 14:52:29 -0500 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:36102 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932078AbeBSTw0 (ORCPT ); Mon, 19 Feb 2018 14:52:26 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E976840A0971; Mon, 19 Feb 2018 19:52:25 +0000 (UTC) Received: from [10.36.116.69] (ovpn-116-69.ams2.redhat.com [10.36.116.69]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 120731006EA3; Mon, 19 Feb 2018 19:52:23 +0000 (UTC) Subject: Re: [PATCH v3 2/3] s390/char : Rename EBCDIC keymap variables To: Farhan Ali , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, linux-fbdev@vger.kernel.org Cc: geert@linux-m68k.org, borntraeger@de.ibm.com, tomi.valkeinen@ti.com, b.zolnierkie@samsung.com References: <4e0d31cf01c9fff5fe177338f14b1ca3f6871fb5.1519053920.git.alifm@linux.vnet.ibm.com> From: Thomas Huth Message-ID: <250077c8-ccef-fbbc-1d53-8a5cc3984243@redhat.com> Date: Mon, 19 Feb 2018 20:52:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <4e0d31cf01c9fff5fe177338f14b1ca3f6871fb5.1519053920.git.alifm@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Mon, 19 Feb 2018 19:52:26 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Mon, 19 Feb 2018 19:52:26 +0000 (UTC) for IP:'10.11.54.3' DOMAIN:'int-mx03.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'thuth@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19.02.2018 16:47, Farhan Ali wrote: > The Linux Virtual Terminal (VT) layer provides a default keymap > which is compiled when VT layer is enabled. But at the same time > we are also compiling the EBCDIC keymap and this causes the linker > to complain. > > So let's rename the EBCDIC keymap variables to prevent linker > conflict. > > Signed-off-by: Farhan Ali > Acked-by: Christian Borntraeger > --- > drivers/s390/char/defkeymap.c | 66 ++++++++++++++++++++++--------------------- > drivers/s390/char/keyboard.c | 32 ++++++++++----------- > drivers/s390/char/keyboard.h | 11 ++++++++ > 3 files changed, 61 insertions(+), 48 deletions(-) Reviewed-by: Thomas Huth