Received: by 10.223.185.116 with SMTP id b49csp220242wrg; Mon, 19 Feb 2018 20:50:34 -0800 (PST) X-Google-Smtp-Source: AH8x225iCmyeOpGTGoMr1wvoxxgo4MJeUh6z8nmc/dVdghPce2dAU+BNEmM0pynTCQ0JSoFt8kGn X-Received: by 2002:a17:902:8c95:: with SMTP id t21-v6mr6323324plo.36.1519102234766; Mon, 19 Feb 2018 20:50:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519102234; cv=none; d=google.com; s=arc-20160816; b=urSlJT/mfnN4ULX93HgtA1DzOiHv7GM6+OXKbmKiQ/qjwfXuEWYV9ELC+hdG+5/GDY kYIeGRyo6jC1KJsiEmU4pBOgqZ2bej6DncuAos9dthliuCF0dBwy3k2b5hUIHhr/Yc9N oGRir4jtmgBTDWOphgH2a+ZnIw2RMn+A2soPfC9sEkw5hAKtFftO5pE+H48d+skOAo6h v3VlREVmi2MKpdTmpAyKOjvj8mQ0U4rVrTU1xq3YndQ/O9UOUicb3dlolm88EalxRlRp pcfL4OhcJfYS/wRkxXVK9q3PnSpttbnyKPaiNlYiB/gG216ZCExCp+YdIqIpYAwWYXdF jOig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature:arc-authentication-results; bh=iHNNuWs4CK6hBmaascxnMbhtQ9DFIK/nmOMEv3RBcOI=; b=NtENOAxuZBIQxQnzjukiKYyrDBb5QeQjykI4f3g01/chm21uhhSHUNa+xYb3Fxk/7X P+1dE86dNeEI+NXSbGT+ZMqLOFrQc/i1+lAMIXs4ExvJNLOm9bVcQVepO/eOImdvJE03 gXVuAlmycl0PlTVuKe3+fy4AkNoWw+rHky9QZykbhod+lW/dyPOfaP0FWRYt9OivZ2d2 739tl4VMUwPssKk3L2NPFdXxbo7ImeY9RsvsY4XJqwJxombvGA1hv0bM8lpMDgKEgfmi l4wd6GCCOgWdT8ZdDzE6ZWHN/0e9GAJktEgdntCj8ORkkagsIAYOpCDF/aaEu9Sw/6mF nfzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=hYXkLzjT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k11-v6si736589pls.294.2018.02.19.20.50.20; Mon, 19 Feb 2018 20:50:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=hYXkLzjT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751339AbeBTEoz (ORCPT + 99 others); Mon, 19 Feb 2018 23:44:55 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:35951 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751131AbeBTEou (ORCPT ); Mon, 19 Feb 2018 23:44:50 -0500 Received: by mail-pg0-f67.google.com with SMTP id j9so6711168pgv.3 for ; Mon, 19 Feb 2018 20:44:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=iHNNuWs4CK6hBmaascxnMbhtQ9DFIK/nmOMEv3RBcOI=; b=hYXkLzjTSB0bE6DHKR5Mh2sNlfkV+r7TpsV0nFPTb9GfBBo/zI+UdVgOUi5Y42ED5U GPu7wpR2hO6MIxexYlWMoTABXB8sozU3N49fRB5T0YNFSXw4BZQH9d/+38sJPG4u9kdk 3KPILaeTdOjE4tkLtU1KCLV8T6rPsAEssGEig= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=iHNNuWs4CK6hBmaascxnMbhtQ9DFIK/nmOMEv3RBcOI=; b=O6GN3yevrEwIqQMun0nEAixznP+c7hIu3p0Jc+3UT89H6kxkExuVYoW5GrECuMy54x wv0GrcPJ0/IuIEOV6E8CCJLKBp9ikTf/amxXY61OcZ0oIdoTJ5XXyqkx8YtjOHyppHqS yibLPuXn4GFRXY4B86eTXyz395/xr7cAU/qg/M63S0duQxM1C2FLM26sMPY5NsIzVUni kYfAzJ6fHwXcKnM7yBljxbXVj2+iLB6zhLbEUmRPVZMNVdgrysVto2qpjhaMJSdlCXji f9xvO2ZqratztcBOGfTprk5hZhOOWyHQDtuiFK4wIv9vVWZSTp5BHSCu3I1YkuNfXaNT twdQ== X-Gm-Message-State: APf1xPDOyK1owAdi1yxxlT8DCTBrbV9vFfdBCO8rXvrnDmLEJEx2JXnN 0UI8suFECv2N+KSFenv0U/Vkjw== X-Received: by 10.99.124.91 with SMTP id l27mr13785259pgn.298.1519101889883; Mon, 19 Feb 2018 20:44:49 -0800 (PST) Received: from acourbot.tok.corp.google.com ([2401:fa00:4:1002:a6cd:a898:e07b:a331]) by smtp.gmail.com with ESMTPSA id q9sm783397pgs.28.2018.02.19.20.44.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Feb 2018 20:44:49 -0800 (PST) From: Alexandre Courbot To: Mauro Carvalho Chehab , Hans Verkuil , Laurent Pinchart , Pawel Osciak , Marek Szyprowski , Tomasz Figa , Sakari Ailus Cc: Gustavo Padovan , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Hans Verkuil , Alexandre Courbot Subject: [RFCv4 03/21] v4l2-ctrls: prepare internal structs for request API Date: Tue, 20 Feb 2018 13:44:07 +0900 Message-Id: <20180220044425.169493-4-acourbot@chromium.org> X-Mailer: git-send-email 2.16.1.291.g4437f3f132-goog In-Reply-To: <20180220044425.169493-1-acourbot@chromium.org> References: <20180220044425.169493-1-acourbot@chromium.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hans Verkuil Add a refcount and is_request bool to struct v4l2_ctrl_handler: this is used to refcount a handler that represents a request. Add a p_req field to struct v4l2_ctrl_ref that will store the request value. Signed-off-by: Hans Verkuil Signed-off-by: Alexandre Courbot --- drivers/media/v4l2-core/v4l2-ctrls.c | 1 + include/media/v4l2-ctrls.h | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c index 5c705f5dde9b..eac70598635d 100644 --- a/drivers/media/v4l2-core/v4l2-ctrls.c +++ b/drivers/media/v4l2-core/v4l2-ctrls.c @@ -1761,6 +1761,7 @@ int v4l2_ctrl_handler_init_class(struct v4l2_ctrl_handler *hdl, sizeof(hdl->buckets[0]), GFP_KERNEL | __GFP_ZERO); hdl->error = hdl->buckets ? 0 : -ENOMEM; + hdl->is_request = false; return hdl->error; } EXPORT_SYMBOL(v4l2_ctrl_handler_init_class); diff --git a/include/media/v4l2-ctrls.h b/include/media/v4l2-ctrls.h index 96f5c63c12d0..bcabbf8a44b5 100644 --- a/include/media/v4l2-ctrls.h +++ b/include/media/v4l2-ctrls.h @@ -18,6 +18,7 @@ #define _V4L2_CTRLS_H #include +#include #include #include @@ -257,6 +258,7 @@ struct v4l2_ctrl_ref { struct v4l2_ctrl_ref *next; struct v4l2_ctrl *ctrl; struct v4l2_ctrl_helper *helper; + union v4l2_ctrl_ptr p_req; bool from_other_dev; }; @@ -292,7 +294,9 @@ struct v4l2_ctrl_handler { v4l2_ctrl_notify_fnc notify; void *notify_priv; u16 nr_of_buckets; + bool is_request; int error; + struct kref ref; }; /** -- 2.16.1.291.g4437f3f132-goog