Received: by 10.223.185.116 with SMTP id b49csp244529wrg; Mon, 19 Feb 2018 21:27:25 -0800 (PST) X-Google-Smtp-Source: AH8x226UjiwfKUhi9ehOfRawVB557eC1zmLIWBITEy8jcN5rGrUbtn+jBd6f5PuxXXJWqJmHpQ/U X-Received: by 2002:a17:902:b2c6:: with SMTP id x6-v6mr16312324plw.285.1519104445453; Mon, 19 Feb 2018 21:27:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519104445; cv=none; d=google.com; s=arc-20160816; b=MBQPW9xX6KfV+QDeaXTFFJzs+pP9MAwLBB1WlKVOyHsUuC8jSaJPzkwEndQR7t8pKQ iFCwQybNOgZ5Dr6rSL6Sa2ffAU5Z8gKumu3N+fq1NPsFXssDAS+mvtNUwjI//4aQ7T9P q+T5li8+bgkB7TWeEEDBeDSaD7rmICBsTMxQy6I0+sqOjbqsWToP/0q0K4oJvzGtdXNI MhAFiLlV7dRmQ8ySoqKt8l9E/Vyn+4LQ7jyVXmsLQU81c+VxmWgEYnLrWm7Fbsa3p3t/ YiHs7eXJav2opeQ8nSrIkic1rFlwgKjLEVqWg33E9PKi+szR4yCeZ5eNbudUiipplrS7 mh6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=IOUGHiBBACiwNchu13ulbIro5Dnf+tNmVWwx71tfrXI=; b=eFkIS4NQoiFHE4ySfSBJBceEGWosFYN/hrZEFM4Oge672PiunQjG2n06TQPnAiOHfK 8kptpLoS1/lkFUvK6RNlXwzPBpa/+QGAOMcjNuHcTAtAUGfq4RzI3RbHFvNw94GP/Z+q rjmmwCwDNYduu2CbmHOQxY+GZaQvifjeJmrsHzgjsMy/GE2WWz5dUfUDOeGYnAEvNrYn 2m8vZV/byEgZOkJNy2lm0P2SPTEG5Bd8PFAtILwQg6FMNTZSqVYI9PvUvG3bQRpO6Wv/ umpDBDqpTHgvdAPl6zxHDIe5KnCrzF4/QYYrll83BZqg2+dA3F3xcQOZixr5q2+vkJr5 fXRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kempniu.pl header.s=google header.b=YtQvKZ8e; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=kempniu.pl Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j125si882825pfg.348.2018.02.19.21.27.11; Mon, 19 Feb 2018 21:27:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kempniu.pl header.s=google header.b=YtQvKZ8e; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=kempniu.pl Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751399AbeBTF0B (ORCPT + 99 others); Tue, 20 Feb 2018 00:26:01 -0500 Received: from mail-lf0-f65.google.com ([209.85.215.65]:36187 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751053AbeBTFZH (ORCPT ); Tue, 20 Feb 2018 00:25:07 -0500 Received: by mail-lf0-f65.google.com with SMTP id t79so2456106lfe.3 for ; Mon, 19 Feb 2018 21:25:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kempniu.pl; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IOUGHiBBACiwNchu13ulbIro5Dnf+tNmVWwx71tfrXI=; b=YtQvKZ8eSy3xw2+sJCukwcs/vAOul4FHo4pbYlUEveiNDY0Xy5+xkLfYK3rq1nxoI/ /znGYU8TYC6r7U7sTntw7RIcvFYIamx8dHPJA/lbW/Niy72xOXbn4G4q2xAe0qFuBhMy yCiW9rskfjrf9ZPT3SO4G6fYyHFNwFunklhI8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IOUGHiBBACiwNchu13ulbIro5Dnf+tNmVWwx71tfrXI=; b=El2AbAyNey6/KP3gyIHSYYS5Bc896NFksZx87BpymFvAkGgexBIydUkJTFuKBjCXSp 0u2eTzpfCn+NnY9x2WQj9VK/uInkSqwCE+/T+Oh+eARR1QU3IwBNrgwz5Kom8jQZ/bIl /A7rb4V1KlpOz8nLNBfhxrydjexctmk0raKTUJt8c+N4bnOcCgzbtmahZ7A35pDM9wrZ SSDBAeMKNVslkYhrx5xAVatSQvtRwJOaqxV46GOAhJr01J1j+EuH9frMLBtIf9GBIw6A mliM4qhEUcjduXpTer5Y9EMXkc8nOT2ZNR/4K2nn4Hxv9BYoA91L8xWI/y+6jK9/BU5E Vnqg== X-Gm-Message-State: APf1xPArIFIia5S4223DsJtSjmvi02/UdRuf4TStVNZYXghF5o2L88F2 zIDUJEB16ucUO3QBhIayVsfERQ== X-Received: by 10.46.12.73 with SMTP id o9mr2447283ljd.68.1519104305473; Mon, 19 Feb 2018 21:25:05 -0800 (PST) Received: from kmp-mobile.hq.kempniu.pl (kmp-mobile.hq.kempniu.pl. [2001:470:64df:111::1b01]) by smtp.googlemail.com with ESMTPSA id b27sm3978286ljb.84.2018.02.19.21.25.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 19 Feb 2018 21:25:04 -0800 (PST) From: =?UTF-8?q?Micha=C5=82=20K=C4=99pie=C5=84?= To: Jonathan Woithe , Darren Hart , Andy Shevchenko Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 4/7] platform/x86: fujitsu-laptop: Clearly distinguish module parameters Date: Tue, 20 Feb 2018 06:24:51 +0100 Message-Id: <20180220052454.11134-5-kernel@kempniu.pl> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180220052454.11134-1-kernel@kempniu.pl> References: <20180220052454.11134-1-kernel@kempniu.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In order to improve code clarity, move declarations of variables that are module parameters higher up and add a comment. Signed-off-by: Michał Kępień --- drivers/platform/x86/fujitsu-laptop.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c index 94ff7f86fa8f..7888b779d6c5 100644 --- a/drivers/platform/x86/fujitsu-laptop.c +++ b/drivers/platform/x86/fujitsu-laptop.c @@ -112,6 +112,10 @@ #define MAX_HOTKEY_RINGBUFFER_SIZE 100 #define RINGBUFFERSIZE 40 +/* Module parameters */ +static int use_alt_lcd_levels = -1; +static bool disable_brightness_adjust; + /* Device controlling the backlight and associated keys */ struct fujitsu_bl { struct input_dev *input; @@ -122,8 +126,6 @@ struct fujitsu_bl { }; static struct fujitsu_bl *fujitsu_bl; -static int use_alt_lcd_levels = -1; -static bool disable_brightness_adjust; /* Device used to access hotkeys and other features on the laptop */ struct fujitsu_laptop { -- 2.16.1