Received: by 10.223.185.116 with SMTP id b49csp288831wrg; Mon, 19 Feb 2018 22:29:18 -0800 (PST) X-Google-Smtp-Source: AH8x225Wdla+34nNa39OVGcKZxp7Gu84YUreQ/Yrhdme4KsGIYnd6X/XFmFx693nuvLdZ3rhfhQj X-Received: by 2002:a17:902:1a2:: with SMTP id b31-v6mr15769530plb.28.1519108158744; Mon, 19 Feb 2018 22:29:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519108158; cv=none; d=google.com; s=arc-20160816; b=EqpUau/K+zrdklOZCzNdY1pzyLePuXJ8kEdaYemenb2tmRbnMNlMaObQhNFp0Mhx5D H3XQQ+iihaJM/SruZCR5w/p7wdKxpCUavPZ5YvL3UM1zt+QRsTT9EMk4dv+TTufB3xJM uhBCv8ixqJRtCoDJ03XvNTzEacSiEgdfaajwAwMPNiJZbwvO9Ke3Y/75EFeAg/Iny1g7 PYHVwv2pGVCdIVNMzDGxsj4X5ddlJJQLDw+gu29LOrn5EjYpPTjQSBP7A6/waRqaw2JX Uu1phL3U0ZyjMxFeA+J9DlMd3haBxXSKajNGuU0AmihtM2XEQ71YoCo74bu5zKTGIQNh RCnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=fiTWRCZT1b4nBlZJaTqFZGetUsHIyeeLaJ7pk64qMmw=; b=vUKQGH7x/T3zb6JkxqiESxrXzlNjGFDiHsRI4ckbWCxNaMoPLnhmAL91v/cUquZ+g/ zz++TSv9BA/sBcURi/eRmmEw67Nj6ptj5gHHvsoPBPjfpK6LRcggje95FzvOpIfjLIRk QX1NDY8d6lfh79WKCOcGsbB+sftfvbMll6cl0nv41liz/8E8dzNAixtAly00eEvFMtpH VjZ9aqtHbGOxNVT0BfSWRdIgPrLvQ7tSzNw+tYmrpsF0xalqGRBRw8D6M84Oodo5ysxW j16pVwOkJgSpAeZDn7Zo6TEN1Lk4ncHx4m6mBXp4clyRCO3Re4JFD1kq5TV2mXkwGcMc fiig== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u77si5029331pfd.165.2018.02.19.22.28.53; Mon, 19 Feb 2018 22:29:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751038AbeBTG1w (ORCPT + 99 others); Tue, 20 Feb 2018 01:27:52 -0500 Received: from server.atrad.com.au ([150.101.241.2]:39858 "EHLO server.atrad.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774AbeBTG1v (ORCPT ); Tue, 20 Feb 2018 01:27:51 -0500 Received: from marvin.atrad.com.au (IDENT:1008@marvin.atrad.com.au [192.168.0.2]) by server.atrad.com.au (8.15.2/8.14.9) with ESMTPS id w1K6R4ML002962 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 20 Feb 2018 16:57:09 +1030 Date: Tue, 20 Feb 2018 16:57:04 +1030 From: Jonathan Woithe To: Micha?? K??pie?? Cc: Darren Hart , Andy Shevchenko , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/7] fujitsu-laptop: Miscellaneous cleanups Message-ID: <20180220062704.GK3785@marvin.atrad.com.au> References: <20180220052454.11134-1-kernel@kempniu.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180220052454.11134-1-kernel@kempniu.pl> User-Agent: Mutt/1.6.1 (2016-04-27) X-MIMEDefang-action: accept X-Scanned-By: MIMEDefang 2.79 on 192.168.0.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 20, 2018 at 06:24:47AM +0100, Micha?? K??pie?? wrote: > This patch series contains miscellaneous cleanups which I think are > worth getting done before splitting fujitsu-laptop into two separate > modules. > > Changes from v1: > > - [6/7] Rename BACKLIGHT_POWER to BACKLIGHT_PARAM_POWER. > > - [6/7] Use BACKLIGHT_OFF instead of a numeric constant. > > - [7/7] Include due to the use of BIT(). Thanks for the revision; the result looks good to me. Collectively these changes improve the readability of the code and make its intent clearer. Reviewed-by: Jonathan Woithe Regards jonathan