Received: by 10.223.185.116 with SMTP id b49csp454326wrg; Tue, 20 Feb 2018 02:11:03 -0800 (PST) X-Google-Smtp-Source: AH8x225py/4I7JKd6ba4eNSGA1QR3pFswBtqFTC2IqTsQ9IUGNZVJzYxvzoadp8iG9rL9fTjxYe1 X-Received: by 10.98.206.134 with SMTP id y128mr2655878pfg.34.1519121463839; Tue, 20 Feb 2018 02:11:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519121463; cv=none; d=google.com; s=arc-20160816; b=JBptLWq+MT/sSU2vrPY0LZgMmkuhB9xAf7zrj6Fzj/w91oEjJe8Gc5mJAncDZHGtMs ctusX2xZehhv5ehQHlvnBnp/+LuEmgVgdVft+Z6kgBo3KAIzF1VF5bry0K+2TjDWku2w S6S5L6LG3YEHqBs7D2lPJjWniqtbXTG45RkQDqpWLGe44qsVkieiU4/BHKWN2fuf+Njy mPr4K5ow+8HO/SFW6r4MRXoW6wJ0sfdqcW0zzw3ynUoQVdSeSfXcH39nBlg1Rb791KmN kS6P/jG+CRnMVANuieHszodIek5a4IN/Vjs5QOgsNd0mAQbHWHzjnQ1lbX4F79lzO8pI F93w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:arc-authentication-results; bh=qsAoa7tMoWUghyEfJ783K1X33EQyyHJfTae93xmhEfU=; b=0/R8PSPbbfJeJxbLIKWeYi9RLJog9kldWBMyAJd+QSTf3cOywuJvSzVKPu7PJHK3VI SH9PvyuReA3WKbkXN0TXYy/XqwUweO8N4XKmQF/TFl8ajzSAVeYBCppt9JeHBzDqD4fC 62phSVHqcS+jFdbE/iJ2aNwoVL18p/VKdO9r9XNOgd3FrauYquQYlzZhLwCuQWSvEO8C TJlcxmonuSgFJ97ZL2ps+ZzmZ4gAxQQoV760ExtozMSbNMeEKFRM19Lk0HlWDxHej7vi /+WUZr7mH+FSDL9AwfsNaaLdA3JHGdwkXMl4hjh8o+uRcmBhMn1dl5b2LSCku1sGavjm O15Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m10-v6si7149717plt.185.2018.02.20.02.10.49; Tue, 20 Feb 2018 02:11:03 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751402AbeBTKKN (ORCPT + 99 others); Tue, 20 Feb 2018 05:10:13 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:56734 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751119AbeBTKKL (ORCPT ); Tue, 20 Feb 2018 05:10:11 -0500 Received: from w540 (unknown [IPv6:2001:b07:6442:1ac4:4036:52e3:3484:3ff2]) (Authenticated sender: jacopo@jmondi.org) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 3F9E1A8112; Tue, 20 Feb 2018 11:10:05 +0100 (CET) Date: Tue, 20 Feb 2018 11:10:04 +0100 From: jacopo mondi To: Geert Uytterhoeven Cc: Jacopo Mondi , Simon Horman , Magnus Damm , Rob Herring , Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-kernel@lists.infradead.org, Linux-Renesas , Linux Kernel Mailing List Subject: Re: [PATCH 03/15] soc: renesas: Add R-Car M3-N support Message-ID: <20180220101004.GD7203@w540> References: <1518515162-23663-1-git-send-email-jacopo+renesas@jmondi.org> <1518515162-23663-4-git-send-email-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, On Wed, Feb 14, 2018 at 01:48:27PM +0100, Geert Uytterhoeven wrote: > Hi Jacopo, > > Thanks for your patch! > > On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi > wrote: > > Add support for R-Car M3-N (r8a77965) power areas and reset. > > M3-N power areas are identical to M3-W ones, so just copy and rename > > them. > > They are not identical: > - M3-N does not have the CA53-related areas, > - M3-W does not have A3VP, > - M3-N does not have A2VC0 (M3-W also doesn't, according to latest > datasheet?). > > The datasheet also mentions A3SH, without further info about the register > block. I think we need to bring this up with Renesas. > > > .../bindings/power/renesas,rcar-sysc.txt | 1 + > > .../devicetree/bindings/reset/renesas,rst.txt | 1 + > > drivers/soc/renesas/Kconfig | 9 ++++-- > > drivers/soc/renesas/Makefile | 1 + > > drivers/soc/renesas/r8a77965-sysc.c | 37 ++++++++++++++++++++++ > > drivers/soc/renesas/rcar-rst.c | 1 + > > drivers/soc/renesas/rcar-sysc.c | 3 ++ > > drivers/soc/renesas/rcar-sysc.h | 1 + > > drivers/soc/renesas/renesas-soc.c | 8 +++++ > > include/dt-bindings/power/r8a77965-sysc.h | 31 ++++++++++++++++++ > > 10 files changed, 91 insertions(+), 2 deletions(-) > > create mode 100644 drivers/soc/renesas/r8a77965-sysc.c > > create mode 100644 include/dt-bindings/power/r8a77965-sysc.h > > The maintainer may ask you to split this patch by functionality... > > > --- /dev/null > > +++ b/drivers/soc/renesas/r8a77965-sysc.c > > @@ -0,0 +1,37 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Renesas R-Car M3-N System Controller > > + * Copyright (C) 2018 Jacopo Mondi > > + * > > + * Based on Renesas R-Car M3-W System Controller > > + * Copyright (C) 2016 Glider bvba > > + */ > > + > > +#include > > +#include > > + > > +#include > > + > > +#include "rcar-sysc.h" > > + > > +static const struct rcar_sysc_area r8a77965_areas[] __initconst = { > > + { "always-on", 0, 0, R8A77965_PD_ALWAYS_ON, -1, PD_ALWAYS_ON }, > > + { "ca57-scu", 0x1c0, 0, R8A77965_PD_CA57_SCU, R8A77965_PD_ALWAYS_ON, > > + PD_SCU }, > > + { "ca57-cpu0", 0x80, 0, R8A77965_PD_CA57_CPU0, R8A77965_PD_CA57_SCU, > > + PD_CPU_NOCR }, > > + { "ca57-cpu1", 0x80, 1, R8A77965_PD_CA57_CPU1, R8A77965_PD_CA57_SCU, > > + PD_CPU_NOCR }, > > + { "cr7", 0x240, 0, R8A77965_PD_CR7, R8A77965_PD_ALWAYS_ON }, > > + { "a3vc", 0x380, 0, R8A77965_PD_A3VC, R8A77965_PD_ALWAYS_ON }, > > + { "a2vc0", 0x3c0, 0, R8A77965_PD_A2VC0, R8A77965_PD_A3VC }, > > M3-N (and M3-W) does not have A2VC0? Why do I still see that power area listed in latest renesas-drivers for M3-W? Are there patch pendings for that? I'll remove it anyway for M3-N. Thanks j > > > + { "a2vc1", 0x3c0, 1, R8A77965_PD_A2VC1, R8A77965_PD_A3VC }, > > + { "3dg-a", 0x100, 0, R8A77965_PD_3DG_A, R8A77965_PD_ALWAYS_ON }, > > + { "3dg-b", 0x100, 1, R8A77965_PD_3DG_B, R8A77965_PD_3DG_A }, > > + { "a3ir", 0x180, 0, R8A77965_PD_A3IR, R8A77965_PD_ALWAYS_ON }, > > A3VP is missing? > > > +}; > > + > > +const struct rcar_sysc_info r8a77965_sysc_info __initconst = { > > + .areas = r8a77965_areas, > > + .num_areas = ARRAY_SIZE(r8a77965_areas), > > +}; > > > --- /dev/null > > +++ b/include/dt-bindings/power/r8a77965-sysc.h > > @@ -0,0 +1,31 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* > > + * Copyright (C) 2018 Jacopo Mondi > > + * Copyright (C) 2016 Glider bvba > > + */ > > + > > +#ifndef __DT_BINDINGS_POWER_R8A77965_SYSC_H__ > > +#define __DT_BINDINGS_POWER_R8A77965_SYSC_H__ > > + > > +/* > > + * These power domain indices match the numbers of the interrupt bits > > + * representing the power areas in the various Interrupt Registers > > + * (e.g. SYSCISR, Interrupt Status Register) > > + */ > > + > > +#define R8A77965_PD_CA57_CPU0 0 > > +#define R8A77965_PD_CA57_CPU1 1 > > +#define R8A77965_PD_A3VP 9 > > +#define R8A77965_PD_CA57_SCU 12 > > +#define R8A77965_PD_CR7 13 > > +#define R8A77965_PD_A3VC 14 > > +#define R8A77965_PD_3DG_A 17 > > +#define R8A77965_PD_3DG_B 18 > > +#define R8A77965_PD_A3IR 24 > > +#define R8A77965_PD_A2VC0 25 > > M3-N (and M3-W) does not have A2VC0? > > > +#define R8A77965_PD_A2VC1 26 > > + > > +/* Always-on power area */ > > +#define R8A77965_PD_ALWAYS_ON 32 > > + > > +#endif /* __DT_BINDINGS_POWER_R8A77965_SYSC_H__ */ > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds