Received: by 10.223.185.116 with SMTP id b49csp554366wrg; Tue, 20 Feb 2018 04:06:34 -0800 (PST) X-Google-Smtp-Source: AH8x225jmAPumvAubr8Qi20rXQBMCQkHR3s6wZJYlNNxUlRs/giK9fXkpG4AWyQl5sQOt2TT28ml X-Received: by 2002:a17:902:b707:: with SMTP id d7-v6mr17695454pls.119.1519128394869; Tue, 20 Feb 2018 04:06:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519128394; cv=none; d=google.com; s=arc-20160816; b=nG8eo26JRV8YqBhJcGwWs66gO9UVZnaZuzPjZi7MhgsGncy3lbah9Kj1M8GcYtURUI hzmCSn3y8pIAJug1quECO6dpoFs3Wo8O8xKHfLISArI1SDYGscYK30NvT4tzyhWzD/bY FkAGVNpiJRmhrw20Aah6SHcLhD1CA1cJD3YIUxe3VoCCVpap2i2TjeiP+UjQ+LIp8erK je3hoWGM5SjBWooK9PoQ7MZLezsZeJg9wjOe8ruGQqvACm50jxLi/U3LLtfJZCuJc/xF qdxlVVygknb9xXii7iS96a7HtC995ttfT/GT05itF7Kb5rY+km22eBTW57byvBs5RGEB HCuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature:arc-authentication-results; bh=WPvQJx9xEYQuN4oDz+OPfHcEosYZa0rPCyHpe8IcVKE=; b=C8a/226+puyAXHKaJBv8/wqd3bgkZvNbl69XeiXUGc83rEfh3S1uKXwa9kxbySS6Uu lkA4FIuf3PNrqiAUzBwcAip1J2A3wn3azFPixaqjN+8eT4gBLYz3b0z8EeIf4MRDBRHI 5tiLTz0vF8nF3VCUyLDq4MG+Kiqk8vcCK3aOn5KJDxlFqq4rXkr+EZDPsYXOQ0mbt8Rt s5SLkStPDn82DQzY5pE3XlENw0VJhNGFFHnHWK9v3yylgWbrOvAhw6VeMXEuw4d8nDLC tmoOGMKiNqv6vNPfm+w+lPWEBgwDRULLDWw5k6fJ0ZPV8BndQNFwpyIjB9stBlivI7U1 eO7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=LIYZhib+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n6-v6si7295189pla.619.2018.02.20.04.06.18; Tue, 20 Feb 2018 04:06:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=LIYZhib+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751951AbeBTMF0 (ORCPT + 99 others); Tue, 20 Feb 2018 07:05:26 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:54104 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751879AbeBTMFY (ORCPT ); Tue, 20 Feb 2018 07:05:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=WPvQJx9xEYQuN4oDz+OPfHcEosYZa0rPCyHpe8IcVKE=; b=LIYZhib+0mI33v4pvpImWwURH w84Q3uwpdXA2m7X5Aip2yfp3DQVEWXahlPYkVbYiHD0ssOiPco92aY1QI27zpYbk12VtlGmU+gGv1 Dk5PDiqmAqs6MW1MB5FfNFl4eGTI9MDg0rwcf7ghz8DkORNKkICsrr6fHjszkOWxFm6S8=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1eo6fi-0004tq-Hi; Tue, 20 Feb 2018 12:05:22 +0000 Received: from broonie by debutante with local (Exim 4.90_1) (envelope-from ) id 1eo6fh-0002JW-T0; Tue, 20 Feb 2018 12:05:21 +0000 Date: Tue, 20 Feb 2018 12:05:21 +0000 From: Mark Brown To: Neil Armstrong Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] ASoC: max9759: Add Amplifier Driver Message-ID: <20180220120521.GC6378@sirena.org.uk> References: <1519047958-22583-1-git-send-email-narmstrong@baylibre.com> <1519047958-22583-3-git-send-email-narmstrong@baylibre.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Fig2xvG2VGoz8o/s" Content-Disposition: inline In-Reply-To: <1519047958-22583-3-git-send-email-narmstrong@baylibre.com> X-Cookie: Don't read everything you believe. User-Agent: Mutt/1.9.3 (2018-01-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Fig2xvG2VGoz8o/s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Feb 19, 2018 at 02:45:58PM +0100, Neil Armstrong wrote: > +++ b/sound/soc/codecs/max9759.c > @@ -0,0 +1,207 @@ > +// SPDX-Licence-Identifier: GPL-2.0 > +/* > + * MAX9759 Amplifier Driver > + * Please don't mix C and C++ style comments like this, make it all a C++ comment - it looks more intentional. Otherwise this looks good so I'll apply, please send an incremental fixup. --Fig2xvG2VGoz8o/s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlqMDwEACgkQJNaLcl1U h9BKqQf+I8r9vpHpGAJfRSiXdFwKEDA9HVOxBRLQVV4FOhfaThFShCf1TPJMbMS7 oGAbl6/DuKNlpabrrkCv7jWipyVCDOWPN/YvvpWph6RbIHwUhBZEF4BucOclXGhD kgKEEQBsSCpjZfALXqRKfdCWTe8gFnX+pAi/eP3cDChfvmDdQSlEx1siEh6ffTDW wKoGAl/DlYmygtOKzBe4I8/KHgbV2Dmd9/WvPqdTPCiGD0LpFJV3RmYM6TlQjQxA DAYRtPQ9+DU0ZvDV4lKKa7Pso18edxsVyk1L7mBp+HOqOTxkByHRq/R+ZOJKuDkg GfODTxFqESv8pyFbXA54t4Q6Dv25dA== =1WAN -----END PGP SIGNATURE----- --Fig2xvG2VGoz8o/s--