Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2] usb: core: introduce per-port over-current counters
To:     Felipe Balbi <felipe.balbi@linux.intel.com>,
        Richard Leitner <dev@g0hl1n.net>, <linux-usb@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     <gregkh@linuxfoundation.org>, <stern@rowland.harvard.edu>,
        <linux@roeck-us.net>, <mathias.nyman@linux.intel.com>,
        <johan@kernel.org>, <ekorenevsky@gmail.com>, <peter.chen@nxp.com>,
        <drake@endlessm.com>, <joe@perches.com>
References: <20180220115033.29496-1-dev@g0hl1n.net>
 <87k1v7q3hx.fsf@linux.intel.com>
From:   Richard Leitner <richard.leitner@skidata.com>
Message-ID: <5c398870-08ea-e0ec-5fd4-101255e2b727@skidata.com>
Date:   Tue, 20 Feb 2018 13:14:31 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.6.0
MIME-Version: 1.0
In-Reply-To: <87k1v7q3hx.fsf@linux.intel.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 02/20/2018 12:55 PM, Felipe Balbi wrote:
> 
> Hi,
> 
> Richard Leitner <dev@g0hl1n.net> writes:
>> From: Richard Leitner <richard.leitner@skidata.com>
>>
>> For some userspace applications information on the number of
>> over-current conditions at specific USB hub ports is relevant.
>>
>> In our case we have a series of USB hardware (using the cp210x driver)
>> which communicates using a proprietary protocol. These devices sometimes
>> trigger an over-current situation on some hubs. In case of such an
>> over-current situation the USB devices offer an interface for reducing
>> the max used power. As these conditions are quite rare and imply
>> performance reductions of the device we don't want to reduce the max
>> power always.
>>
>> Therefore give user-space applications the possibility to react
>> adequately by introducing an over_current_counter in the usb port struct
>> which is exported via sysfs.
> 
> why don't you just provide more than one configuration with several
> bMaxPower fields? Then host OS should choose correct configuration based
> on power budget.

Thank you for that suggestion!
Generally speaking that would be possible. Nonetheless we
	a) don't have the possibility to change the firmware or the USB 
		configuration of the device.
	b) in those corner-cases (where the over-current situation occurs)
		the device consumes more than 500mA (which couldn't be 
		configured in bMaxPower AFAIK?). Nonetheless most
		hubs don't detect the over-current (AFAIK) due to
		electrical tolerances of their components. Our problem are
		the hubs which trigger the over-current situation (which
		is fine from a USB perspective).

I know it's probably not a very nice solution, so if anybody has a better
proposal please let me know :-)

Thanks!

regards;Richard.L