Received: by 10.223.185.116 with SMTP id b49csp649098wrg; Tue, 20 Feb 2018 05:41:48 -0800 (PST) X-Google-Smtp-Source: AH8x226cdsDPLASUQRb4mKOr1rSf2z2KVeFT/PaBqtkOngD7QK7nL8MRN80d+2hn9q2qkurZP643 X-Received: by 10.101.101.142 with SMTP id u14mr15507481pgv.429.1519134108653; Tue, 20 Feb 2018 05:41:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519134108; cv=none; d=google.com; s=arc-20160816; b=d4Gtljsw1YwC0b7vV8zx+oB9TdhkAgbhNwk/L0ZtJguRuAxhz3kdn+S5xZnmAXAlLV vswZFwKqai/dPWDfi5C+Q2w0fqt17wrSWRLYRvibe4eyMQFbyroITKifFNejimTIlaCe T5WBx9QJdH8fFt0RMTl/8iZzLCupKAoH6Imt79gWJukWPDejkao7tM9ptzxRo16QNqRw TcH7mwjw5MN9Y3/nmQSNLX+o1NAef/oFDviQ79/ImL3j861VJLwaOj8WSTuzQS1vVhpP ddzKjBhFMfkYd94U3C91IddnA4L14egpMiN3t18jykba1bpUi4o5sU55Hd8m5jvPyhFO vnMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=Ipx+jptzRqncPy3BfJfVmxgreo9dKATJ9aS0Jh6kVgc=; b=YbCpWzzx2E5nj2d8tQNnSfXFOPfIJkekmocpm68BQKo6a8lM5ooL/Hx6inyr5CsXzG isgdKO+emhEVyPp6vBdTElvXPSbXH0+1cyo92A+bCENgFXfcdeHG3yoWBGaNY6dI9wn9 rz0wFm4L/X0ABLOha1sApktZFEIosHETAiUADvDJZPV2pBKIotjH30rCf6qwQQyJSbs9 PcY0sJXffI4p++BdT9xWurg/jnWlEUIJ3bLYXGxXcdkYXMgWMtVuqsnKa3Xw3KSEntYL Y7UcrkRXZQ7triUCzmq0IqGR0tobNjcyz9IKoPkHltiB6ZvRhz6JQ+61lkPdsb8N04SG WUoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=Apa4lKfK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t5si3313721pgf.93.2018.02.20.05.41.34; Tue, 20 Feb 2018 05:41:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=Apa4lKfK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751943AbeBTNky (ORCPT + 99 others); Tue, 20 Feb 2018 08:40:54 -0500 Received: from mail-qt0-f195.google.com ([209.85.216.195]:37530 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751707AbeBTNkv (ORCPT ); Tue, 20 Feb 2018 08:40:51 -0500 Received: by mail-qt0-f195.google.com with SMTP id d26so16350155qtj.4; Tue, 20 Feb 2018 05:40:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=Ipx+jptzRqncPy3BfJfVmxgreo9dKATJ9aS0Jh6kVgc=; b=Apa4lKfKmFOZcmDHY822ov/6pf+q7RbbOCS6q5Op4E5oB478kYo1Y1mmTphV60R7G7 iPMv6ddxK111J2HE3tMBOA5Ym+ZiLKtE1wATfE5Fac/NOqEpRlhassu5yTmT0URIt/uM b1urdpeo/VT/FX9RvWkrRpdYGpBcTFb+gEUEn1n5sc0G6Wi2G8Tzm0RNHmohD046AdHj QOA4v98OXs2Nm/ebm2ld0jUGvuO+MqeuXnvsMcjYezyd8VFUQKdpHOjMUmXxbq5m29A/ qjQ6Koxl7WAx01BQtGNebeZ3L2wy3ybeZwgjz3RE5BofRFey48ZfCN4tQCIEwcKFAyU9 XZUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=Ipx+jptzRqncPy3BfJfVmxgreo9dKATJ9aS0Jh6kVgc=; b=nfW2aZt522Is1atgx78RQg51gxFfKaFpdmXxYHruetvszGZ7N/LYsrsfI5jhKGtDBj Ys5QrmNZ+sMlHVsB8wQ/JhliDw8dL8EizR2ccelpyvB2Nem8Dn7fjk6N73tg+7qf3Ng9 qwlQMWu5OZTJ35SJIA+JdXsp73PThNDx9oBwrCB3Mj4kNjZkmQe6WrQY5o9lhketCpzn 2PWCZz64vcGwaorROXjBKCi5REBZDT3qYhHIc7mgbSDTMNKhMfPhspoQXBIPHaMEZs1V deDDZLvkDO5V00NakERKwaFVc9Mook6KCGfh6llLOGUq7poSuA2dl5hEalCiyM6pHCKc co+w== X-Gm-Message-State: APf1xPAN9TuFQcyRxCCbe1PM1lxQK/kr6OFUtqKey0ROr++TJGPynod7 Py/hGfrmuQFPSVbT5IzbSHEIhVlJlDgpXQif0Ks= X-Received: by 10.237.43.167 with SMTP id e36mr2057076qtd.160.1519134050979; Tue, 20 Feb 2018 05:40:50 -0800 (PST) MIME-Version: 1.0 Received: by 10.200.47.219 with HTTP; Tue, 20 Feb 2018 05:40:50 -0800 (PST) In-Reply-To: <20180220133532.GE7203@w540> References: <1518515162-23663-1-git-send-email-jacopo+renesas@jmondi.org> <1518515162-23663-12-git-send-email-jacopo+renesas@jmondi.org> <20180220133532.GE7203@w540> From: Geert Uytterhoeven Date: Tue, 20 Feb 2018 14:40:50 +0100 X-Google-Sender-Auth: ZX7LE-nnhgLkOX3oj-GW65JCapw Message-ID: Subject: Re: [PATCH 11/15] gpio: rcar: Add R-Car M3-N compatible string To: jacopo mondi Cc: Jacopo Mondi , Simon Horman , Magnus Damm , Rob Herring , Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-kernel@lists.infradead.org, Linux-Renesas , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jacopo, On Tue, Feb 20, 2018 at 2:35 PM, jacopo mondi wrote: > On Wed, Feb 14, 2018 at 03:05:05PM +0100, Geert Uytterhoeven wrote: >> On Tue, Feb 13, 2018 at 10:45 AM, Jacopo Mondi >> wrote: >> > Add compatible string for R-Car M3-N (r8a77965) in gpio-rcar. >> > >> > Signed-off-by: Jacopo Mondi >> >> > --- a/drivers/gpio/gpio-rcar.c >> > +++ b/drivers/gpio/gpio-rcar.c >> > @@ -360,6 +360,10 @@ static const struct of_device_id gpio_rcar_of_table[] = { >> > /* Gen3 GPIO is identical to Gen2. */ >> > .data = &gpio_rcar_info_gen2, >> > }, { >> > + .compatible = "renesas,gpio-r8a77965", >> > + /* Gen3 GPIO is identical to Gen2. */ >> > + .data = &gpio_rcar_info_gen2, >> > + }, { >> >> This part is not needed, as the driver already matches agains the generic >> "renesas,rcar-gen3-gpio". > > Just to point out that the compatible string is there for M3-W and H3. > Anyway, if that's not good practice to add per-SoC strings here, I'll > drop this bit. That's correct. Initially, we added the H3 string first, and the M3-W later. After that we learned about new future Gen3 members, and we started using the family-specific one. Note that we cannot drop the strings for H3 and M3-W from the driver, as old DTBs do not have the family-specific strings. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds