Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   KY Srinivasan <kys@microsoft.com>
To:     KarimAllah Ahmed <karahmed@amazon.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
        "x86@kernel.org" <x86@kernel.org>
CC:     Haiyang Zhang <haiyangz@microsoft.com>,
        Stephen Hemminger <sthemmin@microsoft.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>,
        "H . Peter Anvin" <hpa@zytor.com>
Subject: RE: [PATCH] X86/UAPI: Use __u64 instead of u64 in hyperv.h
Thread-Topic: [PATCH] X86/UAPI: Use __u64 instead of u64 in hyperv.h
Thread-Index: AQHTqh4JMqo3qqolIEiafDtLlZ6qdaOtgPJQ
Date:   Tue, 20 Feb 2018 16:48:50 +0000
Message-ID: <DM5PR2101MB0888CA2B75450EC38B8BD80EA0CF0@DM5PR2101MB0888.namprd21.prod.outlook.com>
References: <1519112391-23773-1-git-send-email-karahmed@amazon.de>
In-Reply-To: <1519112391-23773-1-git-send-email-karahmed@amazon.de>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: microsoft.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 73c92107-28de-4ebb-03b7-08d57881d193
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2018 16:48:50.3949
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB0872
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: KarimAllah Ahmed <karahmed@amazon.de>
> Sent: Monday, February 19, 2018 11:40 PM
> To: linux-kernel@vger.kernel.org; devel@linuxdriverproject.org;
> x86@kernel.org
> Cc: KarimAllah Ahmed <karahmed@amazon.de>; KY Srinivasan
> <kys@microsoft.com>; Haiyang Zhang <haiyangz@microsoft.com>; Stephen
> Hemminger <sthemmin@microsoft.com>; Thomas Gleixner
> <tglx@linutronix.de>; Ingo Molnar <mingo@redhat.com>; H . Peter Anvin
> <hpa@zytor.com>
> Subject: [PATCH] X86/UAPI: Use __u64 instead of u64 in hyperv.h
>=20
> ... since u64 has a hidden header dependency that was not there before
> using it (i.e. it breaks our VMM build). Also, __u64 is the right way to
> expose the data type through UAPI.
>=20
> Fixes: 93286261 ("x86/hyperv: Reenlightenment notifications support")
> Signed-off-by: KarimAllah Ahmed <karahmed@amazon.de>
> Cc: K. Y. Srinivasan <kys@microsoft.com>
> Cc: Haiyang Zhang <haiyangz@microsoft.com>
> Cc: Stephen Hemminger <sthemmin@microsoft.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: x86@kernel.org
> Cc: devel@linuxdriverproject.org
> Cc: linux-kernel@vger.kernel.org

Acked-by: K. Y. Srinivasan <kys@microsoft.com>
> ---
>  arch/x86/include/uapi/asm/hyperv.h | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
>=20
> diff --git a/arch/x86/include/uapi/asm/hyperv.h
> b/arch/x86/include/uapi/asm/hyperv.h
> index 197c2e6..0994143 100644
> --- a/arch/x86/include/uapi/asm/hyperv.h
> +++ b/arch/x86/include/uapi/asm/hyperv.h
> @@ -241,24 +241,24 @@
>  #define HV_X64_MSR_REENLIGHTENMENT_CONTROL	0x40000106
>=20
>  struct hv_reenlightenment_control {
> -	u64 vector:8;
> -	u64 reserved1:8;
> -	u64 enabled:1;
> -	u64 reserved2:15;
> -	u64 target_vp:32;
> +	__u64 vector:8;
> +	__u64 reserved1:8;
> +	__u64 enabled:1;
> +	__u64 reserved2:15;
> +	__u64 target_vp:32;
>  };
>=20
>  #define HV_X64_MSR_TSC_EMULATION_CONTROL	0x40000107
>  #define HV_X64_MSR_TSC_EMULATION_STATUS		0x40000108
>=20
>  struct hv_tsc_emulation_control {
> -	u64 enabled:1;
> -	u64 reserved:63;
> +	__u64 enabled:1;
> +	__u64 reserved:63;
>  };
>=20
>  struct hv_tsc_emulation_status {
> -	u64 inprogress:1;
> -	u64 reserved:63;
> +	__u64 inprogress:1;
> +	__u64 reserved:63;
>  };
>=20
>  #define HV_X64_MSR_HYPERCALL_ENABLE		0x00000001
> --
> 2.7.4