Received: by 10.223.185.116 with SMTP id b49csp961023wrg; Tue, 20 Feb 2018 10:39:01 -0800 (PST) X-Google-Smtp-Source: AH8x225oAAJVfBfWp9lHwx29oVNcDSBprMBD6/EZ/h2aAE1nMVg+dsnzQYpqQk20qaxBDrb5nFGG X-Received: by 2002:a17:902:bd94:: with SMTP id q20-v6mr499682pls.247.1519151941330; Tue, 20 Feb 2018 10:39:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519151941; cv=none; d=google.com; s=arc-20160816; b=sj/bomy3z67e+O570veonTLUt20VUtsZmu1W5G4wuyD49V2pErC1NDVlxGgbVWSHJF xn03zHXVEjQ68cMaMfZep/wXz8Li25SeBXayV9IGI6rIqZibFi8ym7okGm1vmrvMO6wM W0bQIO5nDE9vPEazzokc/ZA1YU13Y3ebpntnUMHcul80qqLfPPWf3rfPjwZskFPimjuE zfuWNFF4bqnvaVymVoS8uQNdA4VrEqmSOyTS7WH4MWIzBzAU2/Y3QataZwZaQoY8C2SU RyazSFSMF9hCrKQj7TWWkV+7Cz/pP0r9fRiGrjzDXJr0NwTbmrso2v2AiiUOE9zZdpFV dm/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=lIbgEOgXNiQDzt0yQkvu8grqITByZtxIO2CeelAp830=; b=PO/LKO9wG8fxxIdND2SakBLvdJYXL+OS5WVq14q3dEaD0+NglixTx5iFk/kSeXf/x5 T0h7r20CPHTzg+g9j0UTEid1awsTZTSvkKP/U2w0PDf0R6zCLg7W+nRz0PHAvdQfRiaM qGltuuSvfZ/o9oQ9KnV111xDtVsxupDLdAAgiYsgJTMO5TY4xsCOz9Yt2VxsNCa9/gEB B608UDqCY+jWt435AECUuf2bDRaXqLVCJDsk51RU2ohez1iwncYFkWilUXUv6rt5IGfU kvGhjG9oWbFanIzcef8SvyhR1UNatmLJFIrNP9qg8V0KSOMOwVIC6iJp2JFdMBaupSeb fBog== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=ioqvh9LJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 59-v6si10696448pla.203.2018.02.20.10.38.46; Tue, 20 Feb 2018 10:39:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=ioqvh9LJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751559AbeBTSiK (ORCPT + 99 others); Tue, 20 Feb 2018 13:38:10 -0500 Received: from mail-qt0-f196.google.com ([209.85.216.196]:41195 "EHLO mail-qt0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751158AbeBTSiI (ORCPT ); Tue, 20 Feb 2018 13:38:08 -0500 Received: by mail-qt0-f196.google.com with SMTP id a9so17607630qtj.8; Tue, 20 Feb 2018 10:38:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=lIbgEOgXNiQDzt0yQkvu8grqITByZtxIO2CeelAp830=; b=ioqvh9LJjbH3NZIsLFTiaKHrsYPafeE1/h8pGmQUzfNOle9NB66+lzVy9IgekjmaWP ys0dRb4kXmLcuXugJ9U1FqJ6F11MFnytFoHP7CJ0+y5py9wLD/J3MsF/aAwsiNC5Jlm5 Ugd8zcYF5l+nt3WH0V4vODzISbbQJcd98txEAnSLcmc6VCy54o4cJT2L3DkhgrZuju2b Jx6NE65/0sld5P76rr4QCoOdBKU+2WGXJax+wcp/a2EVjKAPFuDeNFgBWXBvSGxCQ95D huWsG8uoxkudzkbcxF/TOX65ZoVQCiOM/GBKhlV0zd5wU0pi5RbpWvM9r4lrLLMTJunv bvRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=lIbgEOgXNiQDzt0yQkvu8grqITByZtxIO2CeelAp830=; b=H1GAHRgN3eaext9RMJM5mvtRxMd1f3QazuRlNtZ8tTs3Ooj8rHY+B9WkBbV9jsXDjh 2OOYTgiGun7ZH6vMvxJEexQtaY576XaZkP6y5nXS+EbVB0eD9VXXYHiXlKyNtRn7yci6 C0haTSuK3eeSLAfmn8zkSLchcitt08eEpUfOXaidLUAn3Q+Nu2LRl/Ex4AkRXcMSzTKg LKPTwZ379bYhWgsKek2QvoIiGss48TA6kBqI6KmgTAAFrx2XpJcnDD6TPXnuxsYdUJEX +czffdzW7Xy3HF+k9fsurRGEW67GSrDQnRyYSUdjMfJScKgiP3LwY/atlZuuYf69DBkX 3pzw== X-Gm-Message-State: APf1xPC+/GkDzIWkLzTANSPnoepx5HkYvGKEqjMqKsiQyIVDuKBkJFfb Kjusy3916KwypNhfq5WdJI4BmU86LyR34OEx/74= X-Received: by 10.200.27.2 with SMTP id y2mr933453qtj.161.1519151887543; Tue, 20 Feb 2018 10:38:07 -0800 (PST) MIME-Version: 1.0 Received: by 10.200.47.219 with HTTP; Tue, 20 Feb 2018 10:38:07 -0800 (PST) In-Reply-To: <20180220181751.20826-1-krzk@kernel.org> References: <20180220181751.20826-1-krzk@kernel.org> From: Geert Uytterhoeven Date: Tue, 20 Feb 2018 19:38:07 +0100 X-Google-Sender-Auth: 0-azr2yXDjigAVDZgYiM-2OYlKg Message-ID: Subject: Re: [PATCH] pinctrl: samsung: Validate alias coming from DT To: Krzysztof Kozlowski Cc: Tomasz Figa , Sylwester Nawrocki , Linus Walleij , Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, Linux Kernel Mailing List , stable Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 20, 2018 at 7:17 PM, Krzysztof Kozlowski wrote: > Driver uses alias from Device Tree as an index of pin controller data > array. In case of a wrong DTB or an out-of-tree DTB, the alias could be > outside of this data array leading to out-of-bounds access. > > Depending on binary and memory layout, this could be handled properly > (showing error like "samsung-pinctrl 3860000.pinctrl: driver data not > available") or could lead to exceptions. > > Reported-by: Geert Uytterhoeven > Cc: > Fixes: 30574f0db1b1 ("pinctrl: add samsung pinctrl and gpiolib driver") > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds