Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   York Sun <york.sun@nxp.com>
To:     Rasmus Villemoes <rasmus.villemoes@prevas.dk>
CC:     Borislav Petkov <bp@alien8.de>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Alexander Stein <alexander.stein@systec-electronic.com>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] EDAC, layerscape: allow building for LS1021A
Thread-Topic: [PATCH] EDAC, layerscape: allow building for LS1021A
Thread-Index: AQHTqlzMp+s6+nVFsUO1f+4zS65Fo6OtxyaN
Date:   Tue, 20 Feb 2018 21:01:11 +0000
Message-ID: <BCC182D6-3CC0-40F1-B17A-0E410A20ACC4@nxp.com>
References: <20180220150912.2954-1-rasmus.villemoes@prevas.dk>
In-Reply-To: <20180220150912.2954-1-rasmus.villemoes@prevas.dk>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: aff41666-f785-43b7-f889-08d578a512ac
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2018 21:01:11.9649
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB3117
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Sorry for top posting. I am on vacation and replying from my phone.

The controller is compatible and the driver should work. Please double chec=
k to make sure you can inject errors and receive interrupt. After that you =
are good to go.

York

Sent from my iPhone

> On Feb 20, 2018, at 23:09, Rasmus Villemoes <rasmus.villemoes@prevas.dk> =
wrote:
>=20
> The LS1021A has a memory controller supported by this driver. It builds
> just fine, and I've done some rudimentary testing using the error
> injection facility, which suggests that it is indeed working.
>=20
> Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
> ---
> Hi York
>=20
> In https://emea01.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fp=
atchwork.kernel.org%2Fpatch%2F9264623%2F&data=3D02%7C01%7Cyork.sun%40nxp.co=
m%7C08fea717f1ca406b5db608d57873ed51%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0=
%7C0%7C636547361667697520&sdata=3Dj%2Ff9myWudDTi38NQCBVv5yX5h%2F2TqcO10yTvc=
g%2FPWVM%3D&reserved=3D0, you wrote that LS1021A
> support is "just one step away". I'm wondering if this is simply that
> step, or there is a little more to it. As I write, it seems to work
> just fine, but I may be missing something.
>=20
> drivers/edac/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/edac/Kconfig b/drivers/edac/Kconfig
> index 96afb2aeed18..23f619afe31d 100644
> --- a/drivers/edac/Kconfig
> +++ b/drivers/edac/Kconfig
> @@ -254,7 +254,7 @@ config EDAC_MPC85XX
>=20
> config EDAC_LAYERSCAPE
>    tristate "Freescale Layerscape DDR"
> -    depends on ARCH_LAYERSCAPE
> +    depends on ARCH_LAYERSCAPE || SOC_LS1021A
>    help
>      Support for error detection and correction on Freescale memory
>      controllers on Layerscape SoCs.
> --=20
> 2.15.1
>=20