Date: Sat, 2 Aug 2003 01:57:16 -0400
From: Diffie <diffie@blazebox.homeip.net>
To: Mike Anderson <andmike@us.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Badness in device_release at drivers/base/core.c:84
Message-ID: <20030802055716.GC3613@blazebox.homeip.net>
References: <20030801182207.GA3759@blazebox.homeip.net> <20030801144455.450d8e52.akpm@osdl.org> <20030801232721.GA5249@beaverton.ibm.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="eHhjakXzOLJAF9wJ"
Content-Disposition: inline
In-Reply-To: <20030801232721.GA5249@beaverton.ibm.com>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2552
Lines: 87


--eHhjakXzOLJAF9wJ
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Aug 01, 2003 at 04:27:22PM -0700, Mike Anderson wrote:
> Andrew Morton [akpm@osdl.org] wrote:
> > This patch should fix the oops.
> >=20
> > As for why the proc reading code was unable to locate the HBA: dunno, b=
ut
> > this is a first step.
> >=20
> > Or maybe you don't have any adaptec controllers in the machine?
> >=20
> > (jejb, please apply..)
> >=20
> >=20
> >  25-akpm/drivers/scsi/aic7xxx_old/aic7xxx_proc.c |    2 +-
> >  1 files changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff -puN drivers/scsi/aic7xxx_old/aic7xxx_proc.c~aic7xxx_old-oops-fix =
drivers/scsi/aic7xxx_old/aic7xxx_proc.c
> > --- 25/drivers/scsi/aic7xxx_old/aic7xxx_proc.c~aic7xxx_old-oops-fix	Fri=
 Aug  1 14:41:14 2003
> > +++ 25-akpm/drivers/scsi/aic7xxx_old/aic7xxx_proc.c	Fri Aug  1 14:41:20=
 2003
> > @@ -92,7 +92,7 @@ aic7xxx_proc_info ( struct Scsi_Host *HB
> > =20
> >    HBAptr =3D NULL;
> > =20
> > -  for(p=3Dfirst_aic7xxx; p->host !=3D HBAptr; p=3Dp->next)
> > +  for(p=3Dfirst_aic7xxx; p && p->host !=3D HBAptr; p=3Dp->next)
> >      ;
> > =20
> >    if (!p)
>=20
> Is this really the right thing to add. The only purpose of these few lines
> is a poor sanity check as down further in the code a pointer to the
> structure is already present in hostdata.=20
>=20
> Adding the "p" is an indication that this drivers list got corrupted some
> where.
>=20
> I agree it may be better than an oops, but what else is invalid?
>=20
> You need to have adaptec controllers in the system to get a procfs node
> to read / write, but this error could be related to the node not getting
> cleaned up correctly on a remove which a patch has previously been
> posted.
>=20
> -andmike
> --
> Michael Anderson
> andmike@us.ibm.com
>=20
>=20

Mike,

I do indeed have an AHA-2940U2W controller in the box...could you be
kind and point me at the said patch? Thank you.

Regards,

Paul


--eHhjakXzOLJAF9wJ
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQE/K1K8IymMQsXoRDARAiAvAJ9C1g+J3mBPvDaEEcGbk+qZpLDI9ACfcmca
hGtTfEbyWqF0FRSQkPIFpe4=
=1R+8
-----END PGP SIGNATURE-----

--eHhjakXzOLJAF9wJ--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/