Received: by 10.223.185.116 with SMTP id b49csp1121688wrg; Tue, 20 Feb 2018 13:47:12 -0800 (PST) X-Google-Smtp-Source: AH8x224xmKtG351nNjkYyJK53fjtnZGYIgKKAUnxXh55GUa2kJ8aqigXHgD3x+t52hDQnxBcBaqW X-Received: by 10.98.22.65 with SMTP id 62mr962660pfw.211.1519163232867; Tue, 20 Feb 2018 13:47:12 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519163232; cv=none; d=google.com; s=arc-20160816; b=LEeSyFuvNmnnsIuqwNXrCbkI4CZFuiDSHArvt+o+3hRXR7gcJBMpGO4PLwno67gQf1 cOJvvLXnzGLlpBEy7bWVPXnxv6KTs0veBboHTVywKUNIDKlkF7P7pIUjacWQYRNE7ey2 Cpzn04uKzfaVQQ8GL+lf/CcKGXPs+BZxRSea/WAxSCl0OyisNrr5fZHLu4yHDSUPh7gy o4n4u0N7wHEF4iY3K/igzSCsQbg0lyYPpNwr2j2S49y4TThVB18WIpKA0vSDCWGEwaSO +yMM9kv2tK+igZ7AtONWjkVKE9tYu8PLEeYfLdrWXhg7rqpL1YhaWNAXP0gVn06U7PNl yheA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=XoVFbAKgcle3IrpCP4c0o1EvTl/KVV5+49/uZUHjP+A=; b=TWFGsQfDstz1nvqjsiXWkBM5u1koM2rBQtSMVi30Ab2HvPY9a9IMWb3W1j5jzp3YaF fRPDQexQlSr/0RJSzWoACVQ76JLWpMQFkpeJaEhiY4KLIJNiW/ZRb5a+WP6uaeidk/Iv TkRtLKyeTXJs/vHziF9NWpTwSFgoKLjYvzCUJGexFcX/UD/u6CCLkLr5Y9Em/ZE271GF qisDzDeQKgN8qfyKHCf3UHy0SyZ2QXQZVU0BXviKKYRAs3eMsqJ1maAhvY5bTerDHF0j kypWujsZ1mHwrslyo15RpNh98ZKvkjnwAcnPoK/ojwrB6eMz0JRIWpH9kO8Gxl0MHuqm IDXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k195si663462pga.68.2018.02.20.13.46.58; Tue, 20 Feb 2018 13:47:12 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751683AbeBTVpu (ORCPT + 99 others); Tue, 20 Feb 2018 16:45:50 -0500 Received: from mga04.intel.com ([192.55.52.120]:7632 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751387AbeBTVoM (ORCPT ); Tue, 20 Feb 2018 16:44:12 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Feb 2018 13:44:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,541,1511856000"; d="scan'208";a="19075780" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga007.jf.intel.com with ESMTP; 20 Feb 2018 13:44:08 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 0B31D1186; Tue, 20 Feb 2018 23:44:02 +0200 (EET) From: Andy Shevchenko To: Rasmus Villemoes , Greg Kroah-Hartman , Andrew Morton , linux-kernel@vger.kernel.org, Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org, Arnd Bergmann , Joe Perches , Mark Salyzyn Cc: Andy Shevchenko Subject: [PATCH v2 15/21] rtc: s3c: Switch to use %ptR Date: Tue, 20 Feb 2018 23:43:54 +0200 Message-Id: <20180220214400.66749-16-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.15.1 In-Reply-To: <20180220214400.66749-1-andriy.shevchenko@linux.intel.com> References: <20180220214400.66749-1-andriy.shevchenko@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use %ptR instead of open coded variant to print content of struct rtc_time in human readable format. Signed-off-by: Andy Shevchenko --- drivers/rtc/rtc-s3c.c | 21 +++++---------------- 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c index a8992c227f61..4a18824a39b1 100644 --- a/drivers/rtc/rtc-s3c.c +++ b/drivers/rtc/rtc-s3c.c @@ -225,13 +225,10 @@ static int s3c_rtc_gettime(struct device *dev, struct rtc_time *rtc_tm) s3c_rtc_disable_clk(info); rtc_tm->tm_year += 100; - - dev_dbg(dev, "read time %04d.%02d.%02d %02d:%02d:%02d\n", - 1900 + rtc_tm->tm_year, rtc_tm->tm_mon, rtc_tm->tm_mday, - rtc_tm->tm_hour, rtc_tm->tm_min, rtc_tm->tm_sec); - rtc_tm->tm_mon -= 1; + dev_dbg(dev, "read time %ptR\n", rtc_tm); + return rtc_valid_tm(rtc_tm); } @@ -241,9 +238,7 @@ static int s3c_rtc_settime(struct device *dev, struct rtc_time *tm) int year = tm->tm_year - 100; int ret; - dev_dbg(dev, "set time %04d.%02d.%02d %02d:%02d:%02d\n", - 1900 + tm->tm_year, tm->tm_mon, tm->tm_mday, - tm->tm_hour, tm->tm_min, tm->tm_sec); + dev_dbg(dev, "set time %ptR\n", tm); /* we get around y2k by simply not supporting it */ @@ -292,10 +287,7 @@ static int s3c_rtc_getalarm(struct device *dev, struct rtc_wkalrm *alrm) alrm->enabled = (alm_en & S3C2410_RTCALM_ALMEN) ? 1 : 0; - dev_dbg(dev, "read alarm %d, %04d.%02d.%02d %02d:%02d:%02d\n", - alm_en, - 1900 + alm_tm->tm_year, alm_tm->tm_mon, alm_tm->tm_mday, - alm_tm->tm_hour, alm_tm->tm_min, alm_tm->tm_sec); + dev_dbg(dev, "read alarm %d, %ptR\n", alm_en, alm_tm); /* decode the alarm enable field */ if (alm_en & S3C2410_RTCALM_SECEN) @@ -329,10 +321,7 @@ static int s3c_rtc_setalarm(struct device *dev, struct rtc_wkalrm *alrm) int ret; int year = tm->tm_year - 100; - dev_dbg(dev, "s3c_rtc_setalarm: %d, %04d.%02d.%02d %02d:%02d:%02d\n", - alrm->enabled, - 1900 + tm->tm_year, tm->tm_mon + 1, tm->tm_mday, - tm->tm_hour, tm->tm_min, tm->tm_sec); + dev_dbg(dev, "s3c_rtc_setalarm: %d, %ptR\n", alrm->enabled, tm); ret = s3c_rtc_enable_clk(info); if (ret) -- 2.15.1