Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 21 Feb 2018 03:35:31 +0000 (UTC)
From:   Denis Du <dudenis2000@yahoo.ca>
To:     David Miller <davem@davemloft.net>
Cc:     <khc@pm.waw.pl>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Message-ID: <1603547691.2507241.1519184131708@mail.yahoo.com>
In-Reply-To: <2005408285.4065183.1517935842178@mail.yahoo.com>
References: <998451043.3408644.1516727290310@mail.yahoo.com> <m3r2qavz73.fsf@pm.waw.pl> <438911112.3985245.1517930128335@mail.yahoo.com> <20180206.102943.1688399898359622454.davem@davemloft.net> <2005408285.4065183.1517935842178@mail.yahoo.com>
Subject: Re: [PATCH] Carrier detect ok, don't turn off negotiation
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Content-Length: 3217
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi, David:

How=C2=A0 is your thinking about this patch?


From b5902a4dfc709b62b704997ab64f31c9ef69a6db Mon Sep 17 00:00:00 2001=20
From: Denis Du <dudenis2000@yahoo.ca>=20
Date: Mon, 15 Jan 2018 17:26:06 -0500=20
Subject: [PATCH] netdev: carrier detect ok, don't turn off negotiation=20

Sometimes when physical lines have a just good noise to make the protocol=
=20
handshaking fail, but the carrier detect still good. Then after remove of=
=20
the noise, nobody will trigger this protocol to be start again to cause=20
the link to never come back. The fix is when the carrier is still on, not=
=20
terminate the protocol handshaking.=20

Signed-off-by: Denis Du <dudenis2000@yahoo.ca>=20
---=20
drivers/net/wan/hdlc_ppp.c | 5 ++++-=20
1 file changed, 4 insertions(+), 1 deletion(-)=20

diff --git a/drivers/net/wan/hdlc_ppp.c b/drivers/net/wan/hdlc_ppp.c=20
index afeca6b..ab8b3cb 100644=20
--- a/drivers/net/wan/hdlc_ppp.c=20
+++ b/drivers/net/wan/hdlc_ppp.c=20
@@ -574,7 +574,10 @@ static void ppp_timer(struct timer_list *t)=20
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0ppp=
_cp_event(proto->dev, proto->pid, TO_GOOD, 0, 0,=20
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 0, NULL);=20
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0pro=
to->restart_counter--;=20
-=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0} else=20
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0} else if (netif_carrier_o=
k(proto->dev))=20
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0pp=
p_cp_event(proto->dev, proto->pid, TO_GOOD, 0, 0,=20
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 0, NULL);=20
+=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0else=20
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0ppp=
_cp_event(proto->dev, proto->pid, TO_BAD, 0, 0,=20
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 0, NULL);=20
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0break;=20
--=20
2.1.4=20


On =E2=80=8ETuesday=E2=80=8E, =E2=80=8EFebruary=E2=80=8E =E2=80=8E06=E2=80=
=8E, =E2=80=8E2018=E2=80=8E =E2=80=8E12=E2=80=8E:=E2=80=8E06=E2=80=8E:=E2=
=80=8E43=E2=80=8E =E2=80=8EPM=E2=80=8E =E2=80=8EEST, Denis Du <dudenis2000@=
yahoo.ca> wrote:=20


Ok, I submit it=C2=A0 again.


In drivers/net/wan/hdlc_ppp.c, some noise on physical line can cause the ca=
rrier detect still ok, but the protocol will fail. So if carrier detect ok,=
 don't turn off protocol negotiation

This patch is against the kernel version Linux 4.15-rc8


On Tuesday, February 6, 2018, 10:29:53 AM EST, David Miller <davem@davemlof=
t.net> wrote:=20


From: Denis Du <dudenis2000@yahoo.ca>

Date: Tue, 6 Feb 2018 15:15:28 +0000 (UTC)

> How=C2=A0 do you think my patch?
>=20
> As you see, Krzysztof=C2=A0 think my patch is ok to be accepted.
> But if you have a better idea to fix it,I am glad to see it. Anyway, this=
 issue have to be fixed.


Please resubmit it and I'll think about it again, thank you.