Received: by 10.223.185.116 with SMTP id b49csp253331wrg; Tue, 20 Feb 2018 20:34:17 -0800 (PST) X-Google-Smtp-Source: AH8x225tH0x2Tn2Ymw3758ebWdG4v2hNNOcVJ3MpA0nCk+3OGc2oVnhqOlCEuNdjbos1V6Cc3E03 X-Received: by 10.99.168.8 with SMTP id o8mr1676331pgf.42.1519187656926; Tue, 20 Feb 2018 20:34:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519187656; cv=none; d=google.com; s=arc-20160816; b=DvBXznUKYuGnPDw6PfICZfT7BZagoHJ8eeeZVnsXUqHrbUGGjKb5SE+xk7Id5jTqje PNRb0PPZTV/TUOAI4YwyTGteTvt8Y1B9jhmtrBROe2Qn/homMRtYIFFGpWTkqnKjJDLA 3M3iEtxQODFlo82nFFcCsy+vQ7o3ic+CBeIxCZeKC1X2bcRBp3jf/D1NbFRiTU9bIqBF olWm+vF8Cy4aWeXow/zdUU1/8M3TwZRu+WY2ttyqdGC9TuEYjHYPewb0TZWT1PDOyO3F Gey1i48LQRftggdpffm67iYfwKgmIEHWFsXbN/ubV4L5KRCPb5bKPhrNElmiMggA8t23 k3NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from:arc-authentication-results; bh=gnIFYkQvTwqEblRKywkEVMta3tH3kIXmekiDjFRkoNU=; b=Uf7m1InPkeCCzh/fgjPYCJO6BZPQSRgJmekByCo4Qi4vqAPogWgApsEZpDZFgzc7W1 yHM4P568BghTakj2BvR59+2kUdfbawHoF9EOtxA/ZJ3uUNwQt+YrFAYaMICmhNWzL12D V5Jzb6JkjyEJTNImLigBgpMSF7q4h8gbXKg3muao8P4qSs2lyIlmu3ufxbuHjZVbBXP0 MPFswuew1GtxZCnLdxSLNzIXa3ruH8dtnPpZUSssT53G2zZvms2loPfWuKSdLzrMX2at snE40npDQbvKlOPApgGIbys2fiCuZP/SA+c3/1ImhafBevpZnFLD3KopRcmf9Lu7tsr0 wBEw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bd8-v6si944753plb.3.2018.02.20.20.33.53; Tue, 20 Feb 2018 20:34:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751407AbeBUEZ3 (ORCPT + 99 others); Tue, 20 Feb 2018 23:25:29 -0500 Received: from mail.cn.fujitsu.com ([183.91.158.132]:57192 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751017AbeBUEZ2 (ORCPT ); Tue, 20 Feb 2018 23:25:28 -0500 X-IronPort-AV: E=Sophos;i="5.43,368,1503331200"; d="scan'208";a="37143461" Received: from bogon (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 21 Feb 2018 12:25:26 +0800 Received: from G08CNEXCHPEKD02.g08.fujitsu.local (unknown [10.167.33.83]) by cn.fujitsu.com (Postfix) with ESMTP id 7D6B348AE763; Wed, 21 Feb 2018 12:25:24 +0800 (CST) Received: from TSAO.g08.fujitsu.local (10.167.226.60) by G08CNEXCHPEKD02.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.361.1; Wed, 21 Feb 2018 12:25:24 +0800 From: Cao jin To: , CC: , , Subject: [PATCH RFC] kbuild: drop superfluous GCC_PLUGINS_CFLAGS assignment Date: Wed, 21 Feb 2018 12:25:07 +0800 Message-ID: <20180221042507.31379-1-caoj.fnst@cn.fujitsu.com> X-Mailer: git-send-email 2.14.3 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.167.226.60] X-yoursite-MailScanner-ID: 7D6B348AE763.AA7EA X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: caoj.fnst@cn.fujitsu.com X-Spam-Status: No Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org GCC_PLUGINS_CFLAGS is already in the environment, so it is superfluous to add it in commanline of final build of init/ Signed-off-by: Cao jin --- This is only tested with Randomizing Structure Layout plugin. The test method is not so grace but I think it can prove the correctness of this patch. On the other hand, if we concerns that some flags cannot be passed during final build, should also consider all the other flags. Currently, with Randomizing plugin enabled, the crash utility can't work with it, the symptom is a Segmentation fault due to infinite function call. With the patch, the symptom is exactly the same, so I am sure the plugin works. scripts/link-vmlinux.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh index e6818b8e7141..e07b2d251ad6 100755 --- a/scripts/link-vmlinux.sh +++ b/scripts/link-vmlinux.sh @@ -248,7 +248,7 @@ else fi; # final build of init/ -${MAKE} -f "${srctree}/scripts/Makefile.build" obj=init GCC_PLUGINS_CFLAGS="${GCC_PLUGINS_CFLAGS}" +${MAKE} -f "${srctree}/scripts/Makefile.build" obj=init archive_builtin -- 2.14.3