Received: by 10.223.185.116 with SMTP id b49csp399057wrg; Tue, 20 Feb 2018 23:47:21 -0800 (PST) X-Google-Smtp-Source: AH8x224AtJQuWLTw28sNWuAqAaQqUk1xP6x8i3rApZ4ZwYHTAn4QRb97QPK2war75xbjyUi5qEvt X-Received: by 10.101.81.204 with SMTP id i12mr2010707pgq.206.1519199241835; Tue, 20 Feb 2018 23:47:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519199241; cv=none; d=google.com; s=arc-20160816; b=kh/z4vsLy1BcrdFqUvhJwb/QbBnVxrfDY2T2y53N8HbGdQqMKeu2RT4Vz9h1qv0wUo itkqUtCThcOoI91bpYHQj4oZ5Li3wB4hfaOz9SX6AfLKCLZUF+rTLQCxLx3hnR7o40tE M3VxToi1eOQjLfhI4EE0zUz0mOtpFADXW0vEKUBr0IdZVoMpIPTg/ts7INlCepPrBDmg LF5qm4oGTAv+yBoPyCz84i+6B7f6VEjL7ms5wpkRh8JkV3f9roT8kxXhtMvuMT3klBjN 7vbXLxCEUqwNiUXTir4FNPlImA/rsCSNwRszZIvHEdrBHXo0+iWjWqVl1r76515s/Zg1 4J2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:reply-to:mime-version:dkim-signature :arc-authentication-results; bh=DblVUkvil8mGKk8tigEh3BvCYeFlaSkkrDVpuKH0SPA=; b=L8cgDT32MXtEalrS5CEG9AuUYXw+WtJFIau7J+FIbuV+0SWbYpdzAw18z/MhSIBQxj 62GTMzPdfjUnZCDHgD7hvlrtCCOHwBPc3n3OGH5naQCfWHQ0q7HD6boAeN2JSMmBn5U9 0dPAbJUdaeJmGp46N3kWtUUbRV2dLjZue+Yw5BWc3o8N2EahKC7wVuqnRTRs+82w4zrs UfY3Kvhb2afDmFY+irc88bjkeoHz1GtLRRvE+Z9lH007D6ic6c7gTpmHQLFYATfzYjFd 5lkuqG+iiM6AFbyn+Tw8quRhMJoUoGwci5mMzK8TdU1qZMWT0QX3WqJl83yqT48Un83H 2bQA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=fLMJNV6p; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 37-v6si2164609plq.366.2018.02.20.23.47.07; Tue, 20 Feb 2018 23:47:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=fLMJNV6p; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751537AbeBUHpo (ORCPT + 99 others); Wed, 21 Feb 2018 02:45:44 -0500 Received: from mail-wr0-f175.google.com ([209.85.128.175]:42227 "EHLO mail-wr0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750831AbeBUHpn (ORCPT ); Wed, 21 Feb 2018 02:45:43 -0500 Received: by mail-wr0-f175.google.com with SMTP id k9so1649931wre.9; Tue, 20 Feb 2018 23:45:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:reply-to:in-reply-to:references:from:date:message-id :subject:to:cc; bh=DblVUkvil8mGKk8tigEh3BvCYeFlaSkkrDVpuKH0SPA=; b=fLMJNV6ppv9jujGAv+Fuf+VAyrC8upyFBVEdTa9CL4JAcR57jVnGAwPZgCJDicrREI 4sy7DBtBuBwOb44lVis4ouH6uc0rgkpLymO1RFy1L/jQFxA5t4wwvSXoGDuHovAgsT5T ITYH4XU7JHWQEYo5qs5TMAjqBubIUKbjlZHBU9KAqvPfmQU9vKlI5MuqHgIPcDSoQX6/ reeaYZVbdbtwxoF9Yu+wFeZ6AdHfxHmcZ0xDeToJfeGofJ2MzolXRxWC98numeLJ1BxK TcYtvRvEHIA5Rk7pnTugcWB7KZLHkILCBqhBokNKfFaVWyKCR33S+MaQmXth4DjBNRga f5IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=DblVUkvil8mGKk8tigEh3BvCYeFlaSkkrDVpuKH0SPA=; b=fXKqNgNdVu0+XnAsy/XiBFzyOWVM2YgWZ+irGys/cpz973ntKQLLH5sSjj9883PtB9 HnnH2mZ5jzzdOMeR1FcZ2ze/b8HObrmJfSNgzfYR+6LlJ6/fk7OSjlVeZM3/sXoQfkbJ 5T9QZ5ZSBxvRuAkQ/YjbatD85YPfxsxrem+wPSZym8NqGr2XwCGKSOqYsoBsE1yQT2nA IXfTBp2ak8SjLwnL8reotqX5PxctF26n4J016CIXBIjtxeK40n09EimFi1OZa7QFCEYy J3VhrIQlQmvGIoGnkK0XGFTV9tXj/TCsMLHPV2smzndz9xToqG3vJczBzH7o4djl3iLJ usSw== X-Gm-Message-State: APf1xPArKPRbQgtFcBSmUm/0Zrp+/sF14XczsFFJPAtANCfUhwtKeT+A AemmuX7k1Oca/hLfTljm8MhwyZeShn4BkvyqxOv9nw== X-Received: by 10.80.212.158 with SMTP id s30mr3726781edi.268.1519199142092; Tue, 20 Feb 2018 23:45:42 -0800 (PST) MIME-Version: 1.0 Received: by 10.80.153.194 with HTTP; Tue, 20 Feb 2018 23:45:21 -0800 (PST) Reply-To: mtk.manpages@gmail.com In-Reply-To: <20180220230136.GD170644@devbig577.frc2.facebook.com> References: <20180220193547.GB170644@devbig577.frc2.facebook.com> <20180220230136.GD170644@devbig577.frc2.facebook.com> From: "Michael Kerrisk (man-pages)" Date: Wed, 21 Feb 2018 08:45:21 +0100 Message-ID: Subject: Re: A "domain invalid" cgroup *can* sometimes have member tasks To: Tejun Heo Cc: "Serge E. Hallyn" , lkml , "open list:CONTROL GROUP (CGROUP)" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tehjun, On 21 February 2018 at 00:01, Tejun Heo wrote: > On Tue, Feb 20, 2018 at 11:35:47AM -0800, Tejun Heo wrote: >> Hmm... nr_populated_domain_children check should have caught that >> condition and rejected it. Will look into what's going on. > > Ah, okay, I was special-casing the first level children case too > early. If you nest the test case by one more level, it fails as > intended. I'll fix the checks. Thanks for looking into this so quickly! Please CC me on the patch. Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/