Received: by 10.223.185.116 with SMTP id b49csp652413wrg; Wed, 21 Feb 2018 04:52:50 -0800 (PST) X-Google-Smtp-Source: AH8x225xGORFhRPAtYU1Ee+8V1FZv+1lb8AFBRdelaZ0ZCA6IM3UwrzoUrUGJjTDfKZj4uGSmvBv X-Received: by 10.98.86.151 with SMTP id h23mr3196371pfj.79.1519217570348; Wed, 21 Feb 2018 04:52:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519217570; cv=none; d=google.com; s=arc-20160816; b=rfyeVCEiHVHl36TAsGvpUMeLkvyJ8kIoHMrwjqmswn0nmnlbweTSj7bnWdrLyjAkam DZgtHK14pZlFCGMeVEMYKaMqcl67HK5cJDKz6TEvD1Y5lOM1fFAyP9se91XbjfV9jVlh a5qxRQCxXJBhpUAJv4VYgfdc+0wDwD+/VEOOzE2pfw/O1W4d8ziyUY+eSd/qWns/PkAu 1zNxbTa17mdo64ye+LNLT059Rhe5+BkiezxPir0la93nbIR+OmQJNHWegiEG6Az3+8Rw R84vhmDuh7s6x2yxLsApQh2iLHMKuoaHeRaq2uKkPgtfvY1iEXLNW9LpPnkML6SHWd0w cviA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :references:in-reply-to:mime-version:dkim-signature :arc-authentication-results; bh=9F6zBjXEWfLdGQGXyn//khDeS5uHtVDFkKPRrpCVUJo=; b=NAq+Iw9rvA7AyaOh2JpCFYwslyNeXLMtLK/jmsJRlkKMH/0Jey8NHpFfYNNMt9cZmy bg+JCblwpnbZM+W9PaXTEJCDBoXNyo0sQ/nrW1NtCNlbS72q7EeZxAqO/skwiDJwdDse dKPWt9YWC2K1KKTeRcc1SDJZlK8trktFvOSt4IPL+Dqwj+xCYPXMsc2BfUAOuaFIKxoN KbmPaG/HtqK657JjGb2HW2/FF9YlviIccF3F2D0mFylrwpMzWRm6Ra9B/8CVr52Atch1 q/+mTSBETreR+axJGK70jwqZAQfHa/jnQakLVDBFMZNl6bAQCHzX9+iYOqY0Bwbr/17D lZ9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=nf1jD5LL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s36-v6si2853087pld.175.2018.02.21.04.52.36; Wed, 21 Feb 2018 04:52:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=nf1jD5LL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932472AbeBUJfB (ORCPT + 99 others); Wed, 21 Feb 2018 04:35:01 -0500 Received: from mail-qt0-f177.google.com ([209.85.216.177]:37920 "EHLO mail-qt0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753249AbeBUJe7 (ORCPT ); Wed, 21 Feb 2018 04:34:59 -0500 Received: by mail-qt0-f177.google.com with SMTP id k13so1118554qtg.5; Wed, 21 Feb 2018 01:34:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=9F6zBjXEWfLdGQGXyn//khDeS5uHtVDFkKPRrpCVUJo=; b=nf1jD5LL318VeqRzzOwYwnhSphPUKvsZVukbSr46Epv8pKgwcs7YNSjxwySJRW2Ev5 kW6StMrgweoQTmWdJdrPdOL42eIJPu+VphfSPG6kBYSAZwUNPhxrmaKybO/RO23oaYGB fFvPYY0i5sOy3M+o6hzWqpGoN58q50dn6D0u2vaYoMPSIhLYAjFuJTZ2EMXqpRH8GgHM MDGNd3RNQ9/ysDahjehHhdB4KNUSK7AfrL+rF6g+YvIHQOmxJpaMTp8xOalTY8vfAzxZ M+GDhcPf7fRHb+uNAATslhrnlvtW6JuMvS7WVEqGUf+hnRACd90V1yGbUyWCa+59LMW9 Qetw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=9F6zBjXEWfLdGQGXyn//khDeS5uHtVDFkKPRrpCVUJo=; b=qYjRmP0s7Yu24OYGcRs0gZIpxsqjUG7g+WaWYsIbga5jBkanxRy1WK5A+3oAUDgSYA Lc6sGUWwkrZMCE30vRbrIyJPfiAe27wxtt1Bsuo69YUzh2QubIx4UZ3jsGxvZIhydTlZ xHJaiGPsL3JSL1h/vQrdJPXm4Qd3ycSieAWijv7/DZC3a67z63byAP5rGiDo4BRgiaE5 hTewFjkBZTO8W1zwevBhXG+WY9woS6QPjddQqRRAUctzx4yNgxiqiwKdCTcG6A+HfAlg b86W7XOHgKc9TcRxkbz3OFbKQJ5dPilp6MCF0kIdei52tdxafOtABm70uE0pUhoU4xEZ 610w== X-Gm-Message-State: APf1xPDTEicrVcqFjESxEWJBQBSHTrcVrfOX2bPlepvR/9bhVCpIUDqQ J8e/9FfqBqI8AZ+IAejGcuakqJqcxwUI6qGj6Fg= X-Received: by 10.200.28.8 with SMTP id a8mr4479577qtk.280.1519205698425; Wed, 21 Feb 2018 01:34:58 -0800 (PST) MIME-Version: 1.0 Received: by 10.200.47.219 with HTTP; Wed, 21 Feb 2018 01:34:58 -0800 (PST) In-Reply-To: <7b59b34b-92ee-da85-9c76-1d7f8f72c318@samsung.com> References: <1519117393-31302-1-git-send-email-geert+renesas@glider.be> <7b59b34b-92ee-da85-9c76-1d7f8f72c318@samsung.com> From: Geert Uytterhoeven Date: Wed, 21 Feb 2018 10:34:58 +0100 X-Google-Sender-Auth: uU1Bbbv1EzJhbteZEvs4gzQgSVA Message-ID: Subject: Re: [PATCH] mmc: dw_mmc-k3: Fix out-of-bounds access through DT alias To: Jaehoon Chung Cc: Geert Uytterhoeven , Ulf Hansson , Linux MMC List , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jaehoon, On Wed, Feb 21, 2018 at 6:39 AM, Jaehoon Chung wrote: > On 02/20/2018 07:50 PM, Geert Uytterhoeven wrote: >> On Tue, Feb 20, 2018 at 10:03 AM, Geert Uytterhoeven >> wrote: >>> The hs_timing_cfg[] array is indexed using a value derived from the >>> "mshcN" alias in DT, which may lead to an out-of-bounds access. >>> >>> Fix this by adding a range check. >>> >>> Fixes: 7d92895208a008a2 ("mmc: dw_mmc-k3: Fix out-of-bounds access through DT alias") >> >> Oops >> >> Fixes: 361c7fe9b02eee7e ("mmc: dw_mmc-k3: add sd support for hi3660") > > Could you resend the patch with changing commit-msg? > Then i will pick yours. Sure. Will send a v2 soon. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds