Received: by 10.223.185.116 with SMTP id b49csp659516wrg; Wed, 21 Feb 2018 05:00:37 -0800 (PST) X-Google-Smtp-Source: AH8x227s4rKo0NvWiLxsuZjU31ubVUGLBo9uyEpLfUxe8Qldjo1QKLy/RGdfAYiEubGpXmIdvP21 X-Received: by 10.101.87.199 with SMTP id q7mr2701257pgr.215.1519218037521; Wed, 21 Feb 2018 05:00:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519218037; cv=none; d=google.com; s=arc-20160816; b=MRg6WH3ToVtCJ2/KNwkMKn9/0G6kaplarURn+o9en/tUIU+v7bYA59bbuFr30BSa1T YQrHTYr3+C7TcDvs+gZb4GhY8tQlD662sJYhHoWNRLXfjsyGS6beiXIv86rS6LuutuKk ERFxJtSYivOgs9HJfAEnUUoa6onXxkYFAN3ly+0U165jbhDjoolc/JxUFXXqcrrRP4jS CPDvo92/9Et08mQmiHrnnvWGpaE9EzgOAsJVxnJ5jZQVp24dNuuJ8wSCxFka67Kpgw+p b/TFeoEFoUTFnZySIWl6AxiiWvSDgcEjA5IzcMv8igRyoyaNSoyCLV0OusK6OSHSNdE+ WIqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=2zM87APuJkTbmqVZfJm0fOSkAfBcDPyS8u3i3dHnvXM=; b=XZTnzjzWhwTvo1kK9xiEyUcP8AcsDgPKhsePCs662odfjrmQT7j56/h2d/wNTw+eSa 4A2KXe6hgo2pXoxkaAETYvWabDv0xyaCJNrAv/HVdylnFfX4AQ0yjA99mY0QTQ+yYoCd NI1IHasE78KJt4l4YdoKnnfCFExuV/SWF3aI9OmgSUUiY8MlG+fBh08M5etTWhCX3h6E U1bTpRo9Q8OFiMtSw6HWNJ+MpFbO4RunAWnt2L1LaBolEXrAQBAijrvL9sorjj5tOE7o JnzEb77sWw+IQ0D7ndzgHu6Wc/sOz8+6QpknQ4uqdvA6+x97/g8+pitFyEMWcPgwWYpx BvYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=E5eR20/4; dkim=pass header.i=@codeaurora.org header.s=default header.b=Jbb6DNAA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e16si3400983pgv.581.2018.02.21.05.00.22; Wed, 21 Feb 2018 05:00:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=E5eR20/4; dkim=pass header.i=@codeaurora.org header.s=default header.b=Jbb6DNAA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933018AbeBUK1E (ORCPT + 99 others); Wed, 21 Feb 2018 05:27:04 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:47406 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932807AbeBUK1B (ORCPT ); Wed, 21 Feb 2018 05:27:01 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 796E460B71; Wed, 21 Feb 2018 10:27:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1519208820; bh=GIbbWhRbb6nzNbM9rAyoZWtK7iLx0XkXqEJUNJOUJDU=; h=From:To:Cc:Subject:Date:From; b=E5eR20/4vhxQjoHnrmtXpvY9UmJK2a+tUCbI0mI7r0Gka1vdDqwApK2ElEJjUImhf bDBS7zCbwsYoUKI3Q7G2fzXm1kK+HujGb3Fx2fZ/n1xxRPCPVrI/cu8RHgqFjFyb2q SeY7TQiJJiXQmm7ivZu49M0qcmbi1467lg6WXCOk= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from blr-ubuntu-poza.qualcomm.com (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.18.19]) (using TLSv1.1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: poza@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id F3A90602BA; Wed, 21 Feb 2018 10:26:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1519208819; bh=GIbbWhRbb6nzNbM9rAyoZWtK7iLx0XkXqEJUNJOUJDU=; h=From:To:Cc:Subject:Date:From; b=Jbb6DNAAPS1RlHv9Ci7qjSqXoKpi9ZslT83LyWvDwzX2mYhj3eBH4TJtykO1GxDPi O6KuinlLd4Z6CbX98XJLiWr//nWfRYzo4EUKmRx88VKnFFjLQZHJ5HzVbwwvAgblez OqqYzK6gFTewOkeFr7cj2SLbI1/rwPI1ke3d+oo0= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org F3A90602BA Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=poza@codeaurora.org From: Oza Pawandeep To: Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Keith Busch , Wei Zhang , Sinan Kaya , Timur Tabi Cc: Oza Pawandeep Subject: [PATCH v8 0/7] Address error and recovery for AER and DPC Date: Wed, 21 Feb 2018 15:56:37 +0530 Message-Id: <1519208804-24512-1-git-send-email-poza@codeaurora.org> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch set brings in error handling support for DPC The current implementation of AER and error message broadcasting to the EP driver is tightly coupled and limited to AER service driver. It is important to factor out broadcasting and other link handling callbacks. So that not only when AER gets triggered, but also when DPC get triggered (for e.g. ERR_FATAL), callbacks are handled appropriately. DPC should enumerate the devices after recovering the link, which is achieved by implementing error_resume callback. Changes since v7: Rebased the code on pci master > https://kernel.googlesource.com/pub/scm/linux/kernel/git/helgaas/pci Changes since v6: Sinan's and Stefan's comments implemented. > reordered patch 6 and 7 > cleaned up Changes since v5: Sinan's and Keith's comments incorporated. > made separate patch for mutex > unified error repotting codes into driver/pci/pci.h > got rid of wait link active/inactive and made generic function in driver/pci/pci.c Changes since v4: Bjorn's comments incorporated. > Renamed only do_recovery. > moved the things more locally to drivers/pci/pci.h Changes since v3: Bjorn's comments incorporated. > Made separate patch renaming generic pci_err.c > Introduce pci_err.h to contain all the error types and recovery > removed all the dependencies on pci.h Changes since v2: Based on feedback from Keith: " When DPC is triggered due to receipt of an uncorrectable error Message, the Requester ID from the Message is recorded in the DPC Error Source ID register and that Message is discarded and not forwarded Upstream. " Removed the patch where AER checks if DPC service is active Changes since v1: Kbuild errors fixed: > pci_find_dpc_dev made static > ras_event.h updated > pci_find_aer_service call with CONFIG check > pci_find_dpc_service call with CONFIG check Oza Pawandeep (7): PCI/AER: Rename error recovery to generic pci naming PCI/AER: factor out error reporting from AER PCI/ERR: add mutex to synchronize recovery PCI/DPC: Unify and plumb error handling into DPC PCI/AER: Unify aer error defines at single space PCI/DPC: Enumerate the devices after DPC trigger event PCI: Unify wait for link active into generic pci drivers/acpi/apei/ghes.c | 1 + drivers/pci/hotplug/pciehp_hpc.c | 21 +- drivers/pci/pci.c | 39 +++- drivers/pci/pci.h | 11 + drivers/pci/pcie/Makefile | 2 +- drivers/pci/pcie/aer/aerdrv.h | 30 --- drivers/pci/pcie/aer/aerdrv_core.c | 293 +------------------------- drivers/pci/pcie/aer/aerdrv_errprint.c | 1 + drivers/pci/pcie/pcie-dpc.c | 115 ++++++++++- drivers/pci/pcie/pcie-err.c | 366 +++++++++++++++++++++++++++++++++ drivers/pci/pcie/portdrv.h | 2 + include/linux/aer.h | 4 - include/linux/pci.h | 1 + 13 files changed, 534 insertions(+), 352 deletions(-) create mode 100644 drivers/pci/pcie/pcie-err.c -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc., a Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.