Received: by 10.223.185.116 with SMTP id b49csp750966wrg; Wed, 21 Feb 2018 06:23:29 -0800 (PST) X-Google-Smtp-Source: AH8x227w1vQ74zJhrP1ErjvcA0K0CK588hmdHZJaoPrma3qh8wEaojkHWSTTdp8WsvYEYCORPndl X-Received: by 2002:a17:902:5a5:: with SMTP id f34-v6mr3390089plf.134.1519223009603; Wed, 21 Feb 2018 06:23:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519223009; cv=none; d=google.com; s=arc-20160816; b=0/EQNbn+IY5NWpDEfjiEBO/vjvhiCHJgfr8O2KdKZko89thnMc/ONFfy0DZJdq4hpU +UFDazL7f9KiF5ZPip46WVXUD8kDkCPP3BHki1+RRh4kgG4FgRycaGvLTZpoo2p1sRbi 7HtfIegvwsbF67fl1CI+LhIyVSVv8BRkLkLTApyDtfhnJ2c5Rq1IhaTCYipXiz/CFXj/ M5OKKv2k/LrnXuNdQHECoG9+2GLKPoBy44h3s0HThum0cxgfia2lykEMAgpVHVIc5oxs cIHRUzsadnpan7FXVpyBbeaNP+i+ZSZbSYHS1Hn+abvAPJqEM8ltA7svXucVIz20oFnk rb3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=v9DZ8O7sPeEly3E8aGLMIWsgmqiLLXU9NLVLTl6A4Ko=; b=xAQk32L0EEzfNDL2tV8GfcRBDPsVHyhg1VVh2nvF89JKVAy/VDDk5XvtHHeqHLB0if +08b4AVJKMnVksiXCa3nlEXRln6jmwJO8VHwPo2iOlfxY0zBSHKVHVokdiN25tFw/P+R yl2qX8bthWSw4yIxHSUrR1iMwhWFjeIA2ha+B8UsprAS7VKu+wx562dMp+ejrbOeBYN1 QpInMQVcwiZAwKAXhTxLVELtlZUUybphLN3RmR3QuZz5ihxGoLn+IvP/OWPfR/WriU/u /py3bw/QZWvV0q4NIPtTmUJVMPJtwFZP2u/JT1ZyfdQKAx3V7oLHvk397EC/gjZsbilU EYHA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u187si2263445pgc.451.2018.02.21.06.23.13; Wed, 21 Feb 2018 06:23:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965958AbeBUOWK (ORCPT + 99 others); Wed, 21 Feb 2018 09:22:10 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:36112 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934886AbeBUM6V (ORCPT ); Wed, 21 Feb 2018 07:58:21 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 0F861FA2; Wed, 21 Feb 2018 12:58:20 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mahesh Salgaonkar , Balbir Singh , Michael Ellerman Subject: [PATCH 4.14 019/167] powerpc/radix: Remove trace_tlbie call from radix__flush_tlb_all Date: Wed, 21 Feb 2018 13:47:10 +0100 Message-Id: <20180221124525.656642817@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180221124524.639039577@linuxfoundation.org> References: <20180221124524.639039577@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Mahesh Salgaonkar commit 8d81296cfcce89013a714feb8d25004a156f8181 upstream. radix__flush_tlb_all() is called only in kexec path in real mode and any tracepoints at this stage will make kexec to fail if enabled. To verify enable tlbie trace before kexec. $ echo 1 > /sys/kernel/debug/tracing/events/powerpc/tlbie/enable == kexec into new kernel and kexec fails. Fix this by not calling trace_tlbie from radix__flush_tlb_all(). Fixes: 0428491cba92 ("powerpc/mm: Trace tlbie(l) instructions") Cc: stable@vger.kernel.org # v4.13+ Signed-off-by: Mahesh Salgaonkar Acked-by: Balbir Singh Signed-off-by: Michael Ellerman Signed-off-by: Greg Kroah-Hartman --- arch/powerpc/mm/tlb-radix.c | 2 -- 1 file changed, 2 deletions(-) --- a/arch/powerpc/mm/tlb-radix.c +++ b/arch/powerpc/mm/tlb-radix.c @@ -453,14 +453,12 @@ void radix__flush_tlb_all(void) */ asm volatile(PPC_TLBIE_5(%0, %4, %3, %2, %1) : : "r"(rb), "i"(r), "i"(1), "i"(ric), "r"(rs) : "memory"); - trace_tlbie(0, 0, rb, rs, ric, prs, r); /* * now flush host entires by passing PRS = 0 and LPID == 0 */ asm volatile(PPC_TLBIE_5(%0, %4, %3, %2, %1) : : "r"(rb), "i"(r), "i"(prs), "i"(ric), "r"(0) : "memory"); asm volatile("eieio; tlbsync; ptesync": : :"memory"); - trace_tlbie(0, 0, rb, 0, ric, prs, r); } void radix__flush_tlb_pte_p9_dd1(unsigned long old_pte, struct mm_struct *mm,