Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
In-Reply-To: <20180220225425.40682-1-bbellevi@uci.edu>
References: <20180220225425.40682-1-bbellevi@uci.edu>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Wed, 21 Feb 2018 16:58:16 +0200
Message-ID: <CAHp75Vc9GLy+GoVQb28K9mNREPFR3oD_uVaAWCQXSGmZ+EA+-w@mail.gmail.com>
Subject: Re: [PATCH] floppy: Don't print kernel addresses to log in show_floppy
To:     Brian Belleville <bbellevi@uci.edu>
Cc:     Jiri Kosina <jikos@kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Feb 21, 2018 at 12:54 AM, Brian Belleville <bbellevi@uci.edu> wrote:
> Outputting kernel addresses will reveal the locations of kernel code
> and data. Change the cases in show_floppy that print
> fd_timer.work.func and fd_timeout.work.func to use the %pf format
> specifier, which will print the symbol name, like what is done for the
> other function pointers printed by show_floppy. No longer output the
> value of cont. The variable cont is a pointer that can hold the
> address of kernel global variables.

Perhaps you missed %px introduction and hashing pointers otherwise.

OTOH I don't give a crap about floppy.

-- 
With Best Regards,
Andy Shevchenko