Received: by 10.223.185.116 with SMTP id b49csp809875wrg; Wed, 21 Feb 2018 07:16:22 -0800 (PST) X-Google-Smtp-Source: AH8x224ThhqMVmrQ3LnufjdOp4LIs/VDyHnue1N38kWl9amw5GG4578sr2RaOf5I2fBF2jDbZho8 X-Received: by 10.101.66.193 with SMTP id l1mr2960228pgp.57.1519226182432; Wed, 21 Feb 2018 07:16:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519226182; cv=none; d=google.com; s=arc-20160816; b=G4mf19maf9CJjUsTHgNCvO27gbABu5kThRWAzlLrNHE0FrU1fObcoFnYagpsO6qDro JIf1c9aGgmHB6DaxjjForNTgaVJ/C4jaVN45qcJZM30NonNSBbskJOAoAmTvMufhGkoF Ox3IhSEYxA15WHSpYcC/PdJ0r/gV0XrbHEehftwhA5UGH2iNABmCag0fDPF6cLEYKMqO f5UCSMqudAp+6u5PPjPbec0p9aOnYY1hTI7j4wfHM1xLUt+o1BeNFcgLFgkvZo7vJcHd JcuQnsGv0zeGaA9PFEnZF6SlQv9niFWyNWweSHNC4v4JhQtO86G+s9O88FWLIasULQyw dE6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject:arc-authentication-results; bh=uVMZgR3r8giUdU7ERJnNdwumlKeRkOUjzgPQFRy9nDI=; b=S28Qy1c5qXEp80s5hjUpbzkdsDkxVjK9f0pJSkja5ic+jfAuWtevUQrJ+dQDA3Bssj cROMSMhB7TRQzrTDR+QQr9DfctjSr22HdOCXIzepiKLV58kZWuSC9udury8p0yXdBHvy gx7InBLZX0ob5/T3H1wi/SS+fJASZZzTuTlS4j91ItF0Nj47f1Km5JFr4pDvjJ6Fgtt4 g4hY9hrft7wgz3djerI2HJR/CB2wbwKeoyDzUDDsNOKbbaaS15hqNdoXCWHs7/Eeictx ctxTMfdOuBN5rddiHuW1axNV7S84BKEe7YzocHmJmJYifj6z5UrtuzsoGcMFu9Nek6MV lCiw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 62si2592983pfh.153.2018.02.21.07.16.07; Wed, 21 Feb 2018 07:16:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965992AbeBUPM5 (ORCPT + 99 others); Wed, 21 Feb 2018 10:12:57 -0500 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:39267 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933330AbeBUPMz (ORCPT ); Wed, 21 Feb 2018 10:12:55 -0500 Received: from pps.filterd (m0046660.ppops.net [127.0.0.1]) by mx08-.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id w1LF8rwl023571; Wed, 21 Feb 2018 16:12:30 +0100 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-00178001.pphosted.com with ESMTP id 2g8s9xca9a-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 21 Feb 2018 16:12:30 +0100 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 4BE943A; Wed, 21 Feb 2018 15:12:29 +0000 (GMT) Received: from Webmail-eu.st.com (sfhdag3node2.st.com [10.75.127.8]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 216504ECC; Wed, 21 Feb 2018 15:12:29 +0000 (GMT) Received: from [10.201.21.58] (10.75.127.44) by SFHDAG3NODE2.st.com (10.75.127.8) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Wed, 21 Feb 2018 16:12:28 +0100 Subject: Re: [PATCH 2/2] ARM: pinctrl: stm32: Optimizes and enhances stm32gpio irqchip To: Radoslaw Pietrzyk , Thomas Gleixner , Jason Cooper , Marc Zyngier , Maxime Coquelin , Linus Walleij , Benjamin Gaignard , Philipp Zabel , , , References: <1519221027-4028-1-git-send-email-radoslaw.pietrzyk@gmail.com> <1519221027-4028-3-git-send-email-radoslaw.pietrzyk@gmail.com> From: Alexandre Torgue Message-ID: Date: Wed, 21 Feb 2018 16:12:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1519221027-4028-3-git-send-email-radoslaw.pietrzyk@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.44] X-ClientProxiedBy: SFHDAG3NODE3.st.com (10.75.127.9) To SFHDAG3NODE2.st.com (10.75.127.8) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-02-21_05:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Maybe you could remove ARM from commit header. On 02/21/2018 02:50 PM, Radoslaw Pietrzyk wrote: > - removes unneeded irq_chip.irq_eoi callback > - adds irq_chip.irq_set_wake callback for possible > in the future GPIO wakeup > > Signed-off-by: Radoslaw Pietrzyk > --- > drivers/pinctrl/stm32/pinctrl-stm32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/stm32/pinctrl-stm32.c b/drivers/pinctrl/stm32/pinctrl-stm32.c > index 617df16..5b1740d 100644 > --- a/drivers/pinctrl/stm32/pinctrl-stm32.c > +++ b/drivers/pinctrl/stm32/pinctrl-stm32.c > @@ -268,10 +268,10 @@ static void stm32_gpio_irq_release_resources(struct irq_data *irq_data) > > static struct irq_chip stm32_gpio_irq_chip = { > .name = "stm32gpio", > - .irq_eoi = irq_chip_eoi_parent, > .irq_mask = irq_chip_mask_parent, > .irq_unmask = irq_chip_unmask_parent, > .irq_set_type = irq_chip_set_type_parent, > + .irq_set_wake = irq_chip_set_wake_parent, > .irq_request_resources = stm32_gpio_irq_request_resources, > .irq_release_resources = stm32_gpio_irq_release_resources, > }; >