Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264030AbTHBOnU (ORCPT ); Sat, 2 Aug 2003 10:43:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S265069AbTHBOnT (ORCPT ); Sat, 2 Aug 2003 10:43:19 -0400 Received: from waste.org ([209.173.204.2]:50881 "EHLO waste.org") by vger.kernel.org with ESMTP id S264030AbTHBOnT (ORCPT ); Sat, 2 Aug 2003 10:43:19 -0400 Date: Sat, 2 Aug 2003 09:43:10 -0500 From: Matt Mackall To: Zwane Mwaikambo Cc: Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] [1/2] random: SMP locking Message-ID: <20030802144310.GH22824@waste.org> References: <20030802042445.GD22824@waste.org> <20030802040015.0fcafda2.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.3.28i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 849 Lines: 19 On Sat, Aug 02, 2003 at 08:35:22AM -0400, Zwane Mwaikambo wrote: > On Sat, 2 Aug 2003, Andrew Morton wrote: > > Cannot perform userspace access while holding a lock - a pagefault could > > occur, perform IO, schedule away and the same CPU tries to take the same > > lock via a different process. > > Perhaps might_sleep() in *_user, copy_* etc is in order? Wouldn't have caught this case - this interface hasn't actually been used/useful for many years as it only gives access to one of the pools and has never been atomic either. -- Matt Mackall : http://www.selenic.com : of or relating to the moon - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/