Received: by 10.223.185.116 with SMTP id b49csp887426wrg; Wed, 21 Feb 2018 08:30:52 -0800 (PST) X-Google-Smtp-Source: AH8x224k8xJ7JI3P9+C+XFA+9NWsNWJSLSytpVXf9ClGLqp27Y7n2if0FH2dwOJ8mEYkzUCbkhYp X-Received: by 10.99.152.10 with SMTP id q10mr3253063pgd.212.1519230652076; Wed, 21 Feb 2018 08:30:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519230652; cv=none; d=google.com; s=arc-20160816; b=X/jw8t0M3xh6V3Lf0gf2yutO5jaLfojYZP0iQhjc8pLGIepRfCGvsMYoQLXwozoBpK EIKlNVf8+/0JxDcu8ZinxCP25EzKaN6olumB35w7mVm9rah6p+BpUQwn7d8tgIJf5M4J g/ur2Z/3cJRxiJgJW1B0BwAOLrvMSWvzUHj/aI1RSOYJEtsMDaTa29M/Ktsv1vtYuXn8 tYAHfhDelKSnb00shgwYYadYc9KQ+cxjwvWZBDYW1I4jCimKJiJdWroDRV4ybcgo6jha xzp06QMTx6h7QTsm3OttZmfbpQQhvIBJiGhh6KsM+oVeihi2C+kSl5vETO56CLmsWu7b tDtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dmarc-filter:dkim-signature:dkim-signature :arc-authentication-results; bh=BQ9xOmpdx+7MmhmvbBgaPrXlqHbjNItDnJ/z45n11ew=; b=ETd2IYC+rL9hRmcbAKO3wCP5Mr3ioFQUKF8xGl0JjxcSYxqffcGv+eHy8yHUv8szff KhHWrg7Ufo12KREMYGkwXIK/y8suJL2k/WTDnB3jciZ1fGH8fZlhhILlNvX87iA4+x3S A1S9MDw3IlfhoTcBCE4StcvdtLqCPcham9S7y0PIOrSDV12C50YPpR9sUMR04rq1S6sG xwZ8TazCr3djheHeYQPUIWY9dThS05+cXxrOjdFbJzuPl41rgQdgw50X+gMcnkIjLFz8 h7ol84svm2oKlms37Tbo1CkLLT5DhC5pHxhdIZaKsQb0M2r73goigmMnkHiZR2BoaG6h ZMWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=f4EQ29S/; dkim=pass header.i=@codeaurora.org header.s=default header.b=pAqbk1E9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z100-v6si171129plh.415.2018.02.21.08.30.21; Wed, 21 Feb 2018 08:30:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=f4EQ29S/; dkim=pass header.i=@codeaurora.org header.s=default header.b=pAqbk1E9; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933146AbeBUK2y (ORCPT + 99 others); Wed, 21 Feb 2018 05:28:54 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:47814 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932785AbeBUK1N (ORCPT ); Wed, 21 Feb 2018 05:27:13 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id B7C9F602BA; Wed, 21 Feb 2018 10:27:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1519208832; bh=AsvJ+SOFQRslN6hmcHEEPHLzEs1VFTOYfij4cYW9OVE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f4EQ29S/tk0h1pBrY2OtQPaP8FI/macPHybuhYIeh8b0VQmFK2gG7VFmTRFrjCJsZ lsjE5gB0Iz7n06A/uPENVWX/BhbI6oKXTueJF847+of+ggrSv5f0MdRQhqF5XNqaK5 da80kfeSjeHltqRHan9upqlSntPKLw7rKH3xNqnQ= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.0 Received: from blr-ubuntu-poza.qualcomm.com (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.18.19]) (using TLSv1.1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: poza@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id D50266070D; Wed, 21 Feb 2018 10:27:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1519208831; bh=AsvJ+SOFQRslN6hmcHEEPHLzEs1VFTOYfij4cYW9OVE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pAqbk1E9aUgQl1Y/qPjVExU+VcqGLBKufHnfsbDlRormEmnVSWVhdCRyWh+xDWnIs RwEL2ul+P/SKqVS9Y934UvbqKasuelTC7g6m3GB673CEa39XBQ/XYZQXGoDbzBl3pD SEIcznQmVq5udHZZfeLNWCujmwnkjw4TpQpQFPU0= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D50266070D Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=poza@codeaurora.org From: Oza Pawandeep To: Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Keith Busch , Wei Zhang , Sinan Kaya , Timur Tabi Cc: Oza Pawandeep Subject: [PATCH v8 3/7] PCI/ERR: add mutex to synchronize recovery Date: Wed, 21 Feb 2018 15:56:40 +0530 Message-Id: <1519208804-24512-4-git-send-email-poza@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1519208804-24512-1-git-send-email-poza@codeaurora.org> References: <1519208804-24512-1-git-send-email-poza@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch protects pci_do_recovery with mutex. Signed-off-by: Oza Pawandeep diff --git a/drivers/pci/pcie/pcie-err.c b/drivers/pci/pcie/pcie-err.c index a532fe0..8318c84 100644 --- a/drivers/pci/pcie/pcie-err.c +++ b/drivers/pci/pcie/pcie-err.c @@ -20,6 +20,8 @@ #include #include "portdrv.h" +static DEFINE_MUTEX(pci_err_recovery_lock); + struct aer_broadcast_data { enum pci_channel_state state; enum pci_ers_result result; @@ -283,6 +285,8 @@ void pci_do_recovery(struct pci_dev *dev, int severity) pci_ers_result_t status, result = PCI_ERS_RESULT_RECOVERED; enum pci_channel_state state; + mutex_lock(&pci_err_recovery_lock); + if (severity == AER_FATAL) state = pci_channel_io_frozen; else @@ -326,9 +330,11 @@ void pci_do_recovery(struct pci_dev *dev, int severity) report_resume); dev_info(&dev->dev, "Device recovery successful\n"); + mutex_unlock(&pci_err_recovery_lock); return; failed: /* TODO: Should kernel panic here? */ dev_info(&dev->dev, "Device recovery failed\n"); + mutex_unlock(&pci_err_recovery_lock); } -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc., a Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.