Received: by 10.223.185.116 with SMTP id b49csp933817wrg; Wed, 21 Feb 2018 09:15:10 -0800 (PST) X-Google-Smtp-Source: AH8x226gaD43VbgxLH2EarisfLr96HRso5DrsbZhOLYV5scVaoP+0kgNDJ95bsI8AP224BNGIy1y X-Received: by 2002:a17:902:b090:: with SMTP id p16-v6mr3842724plr.324.1519233310531; Wed, 21 Feb 2018 09:15:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519233310; cv=none; d=google.com; s=arc-20160816; b=rnJ6MEovYyfJQrR8IBdGS6wsworBEUV+XI+74ebucb2laGis7wf9ZDpAYTRotWPvLl QPAJOQAn34xTqU+Jx5cXPB4ayoc1CwmteOqoQCNFXi2ZwkUpJcU1GO+afMxMZ3Slz1KJ lQiRtuE1em4zQdy/BkG+pH0VVixdTWnqUDYhApoGcDrstcAbIs3z2nM5YLDWGQfIAxW7 NOME0hAc/LVRhCb6Os/PMQ/aU9shqtKcZy7+Y/yApoo5MdtlJOvf9kGe8QEjQiT81wqx C0jvfbZ502tkfECHp/QGVl2z0tbG8XIe9No5izuJlgg4wzWK4vnNdpoFKcIPG1daRS1r Sxsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=koTm9ym7j0cneedkKJJR65va3iL0zQBSl+rCb36kBhg=; b=sIS3D96LQmJ6Y5cxMRqIcm43oxVKB1qfz8Z1WkN07/ZVXbwxyY/+7z3Rflflj5ra4t 4zYOF+Nb8rogx04MRm3ug4A8TYutTTCBXTmQyE88BFF0cbmWja+lmvzAgZXg/b7Jjemz wGCMU89VFsDTot3XQ3HOYOdL64SDLpujfZftyGhdqYWAj8h/A/z3Qk7UKzaS13wsvJVJ lozXPgr4dDZQtsj2mI/g0FMNG5xA1Anzk1LLHSn2M6MsLboN9wToUfFnMf/3eBVqYsEM 6/PqQnvkQDHuIRHR0un+S9HTx4RzBEHkz2BGPDeciUymic68I+5E9+Vrv0Xg6v1cc7FT aFWA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q2si2705081pgp.627.2018.02.21.09.14.55; Wed, 21 Feb 2018 09:15:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934076AbeBUMyg (ORCPT + 99 others); Wed, 21 Feb 2018 07:54:36 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:34126 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932466AbeBUMye (ORCPT ); Wed, 21 Feb 2018 07:54:34 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id C164310FF; Wed, 21 Feb 2018 12:54:33 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nicolas Pitre , Bartlomiej Zolnierkiewicz Subject: [PATCH 4.9 15/77] console/dummy: leave .con_font_get set to NULL Date: Wed, 21 Feb 2018 13:48:24 +0100 Message-Id: <20180221124432.813376426@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180221124432.172390020@linuxfoundation.org> References: <20180221124432.172390020@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nicolas Pitre commit 724ba8b30b044aa0d94b1cd374fc15806cdd6f18 upstream. When this method is set, the caller expects struct console_font fields to be properly initialized when it returns. Leave it unset otherwise nonsensical (leaked kernel stack) values are returned to user space. Signed-off-by: Nicolas Pitre Cc: stable@vger.kernel.org Signed-off-by: Bartlomiej Zolnierkiewicz Signed-off-by: Greg Kroah-Hartman --- drivers/video/console/dummycon.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/video/console/dummycon.c +++ b/drivers/video/console/dummycon.c @@ -67,7 +67,6 @@ const struct consw dummy_con = { .con_switch = DUMMY, .con_blank = DUMMY, .con_font_set = DUMMY, - .con_font_get = DUMMY, .con_font_default = DUMMY, .con_font_copy = DUMMY, };