Received: by 10.223.185.116 with SMTP id b49csp1007317wrg; Wed, 21 Feb 2018 10:27:54 -0800 (PST) X-Google-Smtp-Source: AH8x225yYP7eRHw2w4MrnA21T0jfRCmHk/6YBY1O1ilzb2YYnHD0J0SyTwe4pzFwr7knTSDn4LGq X-Received: by 10.98.166.200 with SMTP id r69mr4161647pfl.205.1519237674299; Wed, 21 Feb 2018 10:27:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519237674; cv=none; d=google.com; s=arc-20160816; b=ILHRJx8IKuzm3h/TpDM7chJaXfGdv8un7ULfoehcNWIIW8SXVYWgOIJJzRfiRFvIag RN+mymEC+ovgAgDkuhuGNAFLTPfl2scIx3glzpIkbT+FmMSOMLq94MiehcmgTzBWjlZ5 LBCITQtjokP6mBusBCkQ/7sH7drOXheYGn0Y9QIyt6jcz1zgh03VWDdfYXOeLWPD8O95 T2yhOuUqSJKcLgb7ftl2BLgleUm7ds+TLuaEEzn+L/mNFBwRtg0NrdXtaAFsreSYe0oY 5595QPycP3u+97hgOy8WcCrpWs7b0RvGYWQ7l//7UPXNGOKUIrK5jQfQ3qGJZN8jcqY6 17dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=nOWAXQaLxaDTaEg/dPlIXJZ5RK3lq/RfCduVZgYflwY=; b=ZmIIjfIXoHX/FqX1LUmO9M+RiSxYMcwzP+mG2DHcenQHMXs/KA5GHsj8VA1FFDXAt5 yexMuwsuvGaa3xwLpDe/ZvxLa6+2rVkR+n3bGz99g2ak6Yji6FaeGjR3/FwxZyWXlCeX GhrVkbIlVI0We1/q6n5ea1x046ri4pI81VZGdtYTL7FIbp1QVHpOwpsow5iCb9waWfEH eI2Q9GIA/WLYhSUp927uI8dVBzuArJOPqgz3qKS6iEmXevhfkT+Kb+G9h9/H6oZKvVcQ FCpASAedZzT0KOOgHFkM8UruWfNTkOboszqjtj4jjAZ0v3Isltbag/Ct2rY0EMFDAYyN CDCA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f35-v6si1874772plh.475.2018.02.21.10.27.40; Wed, 21 Feb 2018 10:27:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935799AbeBUNDs (ORCPT + 99 others); Wed, 21 Feb 2018 08:03:48 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:39642 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933197AbeBUNDo (ORCPT ); Wed, 21 Feb 2018 08:03:44 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id D779AE4A; Wed, 21 Feb 2018 13:03:43 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Markus Elfring , David Disseldorp , Nicholas Bellinger Subject: [PATCH 4.14 131/167] target/iscsi: avoid NULL dereference in CHAP auth error path Date: Wed, 21 Feb 2018 13:49:02 +0100 Message-Id: <20180221124531.795249321@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180221124524.639039577@linuxfoundation.org> References: <20180221124524.639039577@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: David Disseldorp commit ce512d79d0466a604793addb6b769d12ee326822 upstream. If chap_server_compute_md5() fails early, e.g. via CHAP_N mismatch, then crypto_free_shash() is called with a NULL pointer which gets dereferenced in crypto_shash_tfm(). Fixes: 69110e3cedbb ("iscsi-target: Use shash and ahash") Suggested-by: Markus Elfring Signed-off-by: David Disseldorp Cc: stable@vger.kernel.org # 4.6+ Signed-off-by: Nicholas Bellinger Signed-off-by: Greg Kroah-Hartman --- drivers/target/iscsi/iscsi_target_auth.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/target/iscsi/iscsi_target_auth.c +++ b/drivers/target/iscsi/iscsi_target_auth.c @@ -421,7 +421,8 @@ static int chap_server_compute_md5( auth_ret = 0; out: kzfree(desc); - crypto_free_shash(tfm); + if (tfm) + crypto_free_shash(tfm); kfree(challenge); kfree(challenge_binhex); return auth_ret;