Received: by 10.223.185.116 with SMTP id b49csp1016705wrg; Wed, 21 Feb 2018 10:37:22 -0800 (PST) X-Google-Smtp-Source: AH8x226PwBcpSnMvafrUXz9D0vEUIeUYlbOa5np0WukK7ObRrFWigjl1jprAzPjxc88dMszFnqkj X-Received: by 10.98.166.200 with SMTP id r69mr4184952pfl.205.1519238242700; Wed, 21 Feb 2018 10:37:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519238242; cv=none; d=google.com; s=arc-20160816; b=dBgeI8zshK1Rp0Bff15TNGPnYDOQ4i5JDL5dEVlv5XWy4XZyzWiVQK6sYNVqC7+IE+ /uSHu9DOyK21Bqowz1J6zEuoaRgsVfKgnZ3/a9Opd/mRfLHOKqF9rCfj7xzDaZAwBFxX TDFLOv4fQi2uR5rH7fXrQZle1TBYHf7FpblHpfbdposomRIUa0ATo0FJrL9sWoELPikR M2vX6wW7gc0CKnpcXeBLUnlkr1mA2xtc29fVIcBf8MztFE+rVteqnxYgP2wTQSZ50LS0 TsBFhQKorF25v+w4/OHgEUSZQq9rWMCx3tsm9OXmZFJui9mXl2rko69NBb0/LDbPneoN NlDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :in-reply-to:message-id:date:subject:cc:to:from :arc-authentication-results; bh=1HyUWJYhV6/RechYEDNuijiHyw7wFyng4FzmuvfZbtM=; b=PY9zTLJcK/9bQBWq4dz50n0vSrkfqXxSDc4mnGJui7rAu+F5FbrQjHbybNEV0eHx+N guzC5qE30nGWK4qF+qv7Yt3lg9JrWs1hQSbFaHUgNHxDHv18LC3hdXJgcURwh1GSQjVL CA7jREheBwWTWKe+RmkKBrpFYGlxHmmMgy1ARMRQjL2K+gMgCImYGyDAimgzINb6N22/ iWCvZEZLNDzlMIRet6vlJlgkACpzmVkngBx8ofisoEF9eS3mozY4hm6sYMsOrDvR97uj rgluks/3uOa8b/7Ud9cUnD616VhkOOjlCfssff5pBTp3k5YfWkhh7NCYdK0k1au9KSKH xpKg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y7si262172pgv.128.2018.02.21.10.37.08; Wed, 21 Feb 2018 10:37:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936374AbeBUNLW (ORCPT + 99 others); Wed, 21 Feb 2018 08:11:22 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:44488 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936317AbeBUNLN (ORCPT ); Wed, 21 Feb 2018 08:11:13 -0500 Received: from localhost (LFbn-1-12258-90.w90-92.abo.wanadoo.fr [90.92.71.90]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 6DECB1250; Wed, 21 Feb 2018 13:11:04 +0000 (UTC) From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nicolas Pitre , Bartlomiej Zolnierkiewicz Subject: [PATCH 4.15 120/163] console/dummy: leave .con_font_get set to NULL Date: Wed, 21 Feb 2018 13:49:09 +0100 Message-Id: <20180221124536.747679607@linuxfoundation.org> X-Mailer: git-send-email 2.16.2 In-Reply-To: <20180221124529.931834518@linuxfoundation.org> References: <20180221124529.931834518@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.15-stable review patch. If anyone has any objections, please let me know. ------------------ From: Nicolas Pitre commit 724ba8b30b044aa0d94b1cd374fc15806cdd6f18 upstream. When this method is set, the caller expects struct console_font fields to be properly initialized when it returns. Leave it unset otherwise nonsensical (leaked kernel stack) values are returned to user space. Signed-off-by: Nicolas Pitre Cc: stable@vger.kernel.org Signed-off-by: Bartlomiej Zolnierkiewicz Signed-off-by: Greg Kroah-Hartman --- drivers/video/console/dummycon.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/video/console/dummycon.c +++ b/drivers/video/console/dummycon.c @@ -67,7 +67,6 @@ const struct consw dummy_con = { .con_switch = DUMMY, .con_blank = DUMMY, .con_font_set = DUMMY, - .con_font_get = DUMMY, .con_font_default = DUMMY, .con_font_copy = DUMMY, };