Received: by 10.223.185.116 with SMTP id b49csp1054293wrg; Wed, 21 Feb 2018 11:16:18 -0800 (PST) X-Google-Smtp-Source: AH8x226SGN5vFXQatCLqmzx2pkWSfQN6tTf+WumtFrLO1TOG+1tb8Kl0ANYuCtfy1SbprcS7brzZ X-Received: by 2002:a17:902:34e:: with SMTP id 72-v6mr4065801pld.277.1519240578552; Wed, 21 Feb 2018 11:16:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519240578; cv=none; d=google.com; s=arc-20160816; b=wjLq73AqdOgok/gRdH4BLjltE6ek3byR1vYCcnrBNeQAGhpScYfGhN1pfGpsel0ycQ GPcJZT2OfehMqHsFCkpnWdo5iMxcYBzRtFMQ0e3rsTvlPLJDagxYem3eI8eQ/De968mk q6bHayUvBWSxI0TyWqpqTe9MF8liHo1CZE1Mqu2xwmRPOtKh26Nl40OCS34/b3Y3P0Cz lpLI9e51hF/+0ik86BZcn6m+k4PMluTp+8T8K9F6TffuhT8EsAcjUEcgHwL+Icrvwrwi YYgvrF3oC8NuP+b09mkos34wI7XkEb/i49vfT2eawCcuL1CCeR/V9C61cOAJwoJMdVwh 8d9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id :dkim-signature:arc-authentication-results; bh=eVYeBACSuULWtU2zX88uJdDaC/oo1t8H+1pxVTBfGBI=; b=aS/Ww2ecO873M4o0+KctBajM5iFUZE7D3fGMHOnK89A83EfofJQJ1XCv6zWzrcmiE/ V0IsLjZAmr2zbLn+K1VIhBVCbfLiCSWIIs4+iDhC52jknLdN7TPUnKe0MgF0RTmhhGQE 3rlS6Z2U/r4WYvLMtsFGV0rM/+jYk5lsfSwowXXAvhFuCw01TWN7SJZwSQ67YkHRp9eM JQvK8FMF3ANY1dCvtXbAwAJmjklKKcOlEsLHxINWdVywdLCDARVq8YDjJjSWv2spLEcE dBGK2CxPrUcbjAYtRR0ZEgMsga9gYGgmVTJFx+PvR0hu6E8sB4dMmgYS2EqZUnQ9r1Eb 33XA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=uhRx5X6D; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t23-v6si1909062ply.719.2018.02.21.11.16.04; Wed, 21 Feb 2018 11:16:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=uhRx5X6D; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753550AbeBUSjx (ORCPT + 99 others); Wed, 21 Feb 2018 13:39:53 -0500 Received: from mail-pg0-f67.google.com ([74.125.83.67]:40097 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751895AbeBUSjv (ORCPT ); Wed, 21 Feb 2018 13:39:51 -0500 Received: by mail-pg0-f67.google.com with SMTP id g2so980796pgn.7; Wed, 21 Feb 2018 10:39:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=eVYeBACSuULWtU2zX88uJdDaC/oo1t8H+1pxVTBfGBI=; b=uhRx5X6DZKtcqXx8dVuxeXYVl3foI1p3azk2YXv9iCoxxc2/b09eldGvglpoWPT3W7 xZ3ZJwEOa8H+16h7PJ7DebccOvQ7Lwv/WJH5zKE9Jn5e0ooHt47QzoFXEQJXDDA+A1HF 4JHDZ8D+3lbabDSQSW6jvaOVsKoqxc9blc/aSMLMAncsWqIFL3mmBpMv4JLmuPi0iP5l nK7ptOscrRzWPPqD5eCZMPp5cbEUY7cC1bcDS8sVj+14Q/bOshIOigi1nsY2U3qvmkOg OKE0IreYVmZ44hj1ZlSQB9ky7mCEkidjZHnt/aTvr5IjXmKTL01KFJh22WPP2iXzTSFG a/8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=eVYeBACSuULWtU2zX88uJdDaC/oo1t8H+1pxVTBfGBI=; b=JWE5hMso7WHUa8Uu1LfSjU73TE8q4x7fV4jKJLMCeJdFaPs7bcBkwgTLGokAC8nC27 df9G3Dru474ekpXeR2zxu31GKTPOlu98tBTh+MB6TNQoGohPDTx3Q0xftaoVtJBt2KR8 MU6QIM8Ft3xVj7iK6lfCVSN0IoOWE7iwIlrBhOgMQmqYVNDW/DCBbtLyoHD7hXHYEiJo gHkFqTgyZ7q8fXkBr+w25RZNPYAQ38jxvobIrBnHvuxCS7TDaTgRwX+Eh33BpBXvcv2x RBBdUtd8tJDWXrmWAipExtvW/pKz3zwM4DLFhsvZMCLYhBr4zaXJhZ2VBHGSCjx17w2J Pv5g== X-Gm-Message-State: APf1xPByywvOPdJbzwA1gijRy1moScipiCI4JRgORmiCWiFSCBahIOQ7 peyVZTn9mzMKfshYFpyHTqmWGSUg X-Received: by 10.98.192.203 with SMTP id g72mr4217925pfk.27.1519238390933; Wed, 21 Feb 2018 10:39:50 -0800 (PST) Received: from ?IPv6:2620:15c:2c4:201:a9db:72f9:aa27:32d2? ([2620:15c:2c4:201:a9db:72f9:aa27:32d2]) by smtp.googlemail.com with ESMTPSA id n1sm63117381pge.19.2018.02.21.10.39.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 21 Feb 2018 10:39:50 -0800 (PST) Message-ID: <1519238388.55655.43.camel@gmail.com> Subject: Re: [PATCH net-next] tcp: remove the hardcode in the definition of TCPF Macro From: Eric Dumazet To: Yafang Shao , davem@davemloft.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 21 Feb 2018 10:39:48 -0800 In-Reply-To: <1519133311-22068-1-git-send-email-laoar.shao@gmail.com> References: <1519133311-22068-1-git-send-email-laoar.shao@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1+deb9u1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2018-02-20 at 21:28 +0800, Yafang Shao wrote: > TCPF_ macro depends on the definition of TCP_ macro. > So it is better to define them with TCP_ marco. > > Signed-off-by: Yafang Shao > --- Seems reasonable, thanks ! Reviewed-by: Eric Dumazet