Received: by 10.223.185.116 with SMTP id b49csp1147053wrg; Wed, 21 Feb 2018 12:59:42 -0800 (PST) X-Google-Smtp-Source: AH8x224PxusIKuvvy7lG9xkVlVcuiURdss/OnxtJqgPFkNd8pv4Y2XZc/cL1SpVUw5FydSkh7KEJ X-Received: by 2002:a17:902:6c4d:: with SMTP id h13-v6mr1139620pln.273.1519246782710; Wed, 21 Feb 2018 12:59:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519246782; cv=none; d=google.com; s=arc-20160816; b=OiZZNoz+5yVXQyKUolhVIOYfxfIDQ634EeKzETenE4HKtbf0BJofnTKD97U7HyB7s4 iIZJUxT7Ujb2wPC1iFk745db7KQYwQ6tQW1hkI9A424zE55IjH6WAAf0qFoPeoi0Z9he PFNUopo8n3wpMNbBj9vd64ch44ZX5msdAjWazH6TB60pSPOtvQ02Xujt6380vsFX/BBN xr21wi1mB0RCexiFpCwJdPExou0mR/2LRJSc/+4ErDk8lD7xIli4yyS133L9IKJBo7bG wXfxWgfF40MKXc1gvlOQ9KIYQQzX1rvGVzG2qnyurKFdAvjup/g2G3u/DWLAhnyxMwzj xEAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=bvLxceMAgwwqTa5kAyf/0P3KWbruuFLHK2XppL4Cjlw=; b=WH1Cbab3XHkrbTsi8TiwvthFdagu9qPgRhWGHDJjt8Db3fZTykkRUAtHk7eLi2bTeR yJFP/ClR56GxeDxpGDCXwQ/5llPJyYwrmB8FFEbdsy/n4DhI0oX0MuEb6ZRrRgJmhRjj VFGQk5LggQzvNgS2yfbhdr5N2Ss5w+TH/T4+zx2WzdqGFA35T5dIEGYbzLsvWC4eZWe6 xtYfpx0S9U24w5YfMTCRWsmbcm1KxT3B1FuMdzCW2mLqYvvc8+E71fSmbBQoTF6eUd3Y yHe/VOPTdaAujPZOMA+M6l2yyGOyVzZne4zMtQtBqYo5sOj1fw+ku4smYfxwahQ73coL BkXQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w61-v6si1581379plb.412.2018.02.21.12.59.28; Wed, 21 Feb 2018 12:59:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752201AbeBUU6T (ORCPT + 99 others); Wed, 21 Feb 2018 15:58:19 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:47095 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752169AbeBUU6F (ORCPT ); Wed, 21 Feb 2018 15:58:05 -0500 Received: by mail.free-electrons.com (Postfix, from userid 110) id 02063207EF; Wed, 21 Feb 2018 21:58:02 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [88.191.26.124]) by mail.free-electrons.com (Postfix) with ESMTPSA id 5FE26213D8; Wed, 21 Feb 2018 21:57:19 +0100 (CET) From: Alexandre Belloni To: linux-rtc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH 098/100] rtc: max6900: remove useless indirection Date: Wed, 21 Feb 2018 21:56:33 +0100 Message-Id: <20180221205635.31314-99-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180221205635.31314-1-alexandre.belloni@bootlin.com> References: <20180221205635.31314-1-alexandre.belloni@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org max6900_i2c_read_time and max6900_i2c_set_time are only used after casting dev to an i2c_client. Remove that useless indirection. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-max6900.c | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/rtc/rtc-max6900.c b/drivers/rtc/rtc-max6900.c index 84f06106f5ba..ab60f13fa3ef 100644 --- a/drivers/rtc/rtc-max6900.c +++ b/drivers/rtc/rtc-max6900.c @@ -139,8 +139,9 @@ static int max6900_i2c_write_regs(struct i2c_client *client, u8 const *buf) return -EIO; } -static int max6900_i2c_read_time(struct i2c_client *client, struct rtc_time *tm) +static int max6900_rtc_read_time(struct device *dev, struct rtc_time *tm) { + struct i2c_client *client = to_i2c_client(dev); int rc; u8 regs[MAX6900_REG_LEN]; @@ -165,9 +166,9 @@ static int max6900_i2c_clear_write_protect(struct i2c_client *client) return i2c_smbus_write_byte_data(client, MAX6900_REG_CONTROL_WRITE, 0); } -static int -max6900_i2c_set_time(struct i2c_client *client, struct rtc_time const *tm) +static int max6900_rtc_set_time(struct device *dev, struct rtc_time *tm) { + struct i2c_client *client = to_i2c_client(dev); u8 regs[MAX6900_REG_LEN]; int rc; @@ -193,16 +194,6 @@ max6900_i2c_set_time(struct i2c_client *client, struct rtc_time const *tm) return 0; } -static int max6900_rtc_read_time(struct device *dev, struct rtc_time *tm) -{ - return max6900_i2c_read_time(to_i2c_client(dev), tm); -} - -static int max6900_rtc_set_time(struct device *dev, struct rtc_time *tm) -{ - return max6900_i2c_set_time(to_i2c_client(dev), tm); -} - static const struct rtc_class_ops max6900_rtc_ops = { .read_time = max6900_rtc_read_time, .set_time = max6900_rtc_set_time, -- 2.16.1