Received: by 10.223.185.116 with SMTP id b49csp1147417wrg; Wed, 21 Feb 2018 13:00:10 -0800 (PST) X-Google-Smtp-Source: AH8x224x30Aubso77wTezlTXXm1M/7w+MnEbmzSRW2dhJu3w7AKXBqLzFIQtzCBomByxRUozZskn X-Received: by 10.99.126.12 with SMTP id z12mr3644516pgc.142.1519246810769; Wed, 21 Feb 2018 13:00:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519246810; cv=none; d=google.com; s=arc-20160816; b=LiiLOnu4Np/gyJur+51niIK9VcysDhZe4CK6KBnOFkdCaJFtMJPa2RvFdjtVfWBHIF QkTtBJOfZBTwCDXeyNU8XPbdoFu05AHn3reG7TMS2GUCF/I+LGakMywbeL57Dh0Duedd YI1HNzbw0qMEutwmzuoCJ5Bu3P+rqv6CY1B+D9zw6dHiSfh38c59i29/tP0IOw9ppnOK lsdq+En9Nutdg+izXtfJmBSO9C65bEciOGRcaZ87X5AErgNCietco4FGvZZcfpW3au9T o4IeI6wGrOo0PvLPW8XSa5Lha83dB7eKCOlDubCUw8jDX6DJYj+U5FsIU9h8MjKq0nlZ HzXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=FfTidat0/LKZEMsvZaX8EJqMtA95xGxS3q/kQo+4U7E=; b=v7ofBPtF303k5D3M98S7Zu/vzR5j4JnxvBx130797crf1MGgvnLBQUafuCpRnEj+GC Vrw47acCmq49vQk7xIfz43xaAFcCg4ag2IX4gsb4F+acc3ULXVJATliUHIFBRA7ITKT5 GihTVkzplx32LhTmBzUwZEkj87pEbkSgC5i+hbLQ7SsrF8Hz/bv37OTZmH5ORK6zlqGy vHYUu5bN7dWojLYWbE4ter/rw9ca9DBGDhf5/7W8V5TOvy86G6aJIZBjghYPAXY0FOo4 9eyuccA3AteX6z/vHRgQgc4Ko5I+TKtOvwbGuawTumGpWLlJTcPc1e2BxJkRt9/pc8I1 whuA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u23-v6si37416plk.116.2018.02.21.12.59.56; Wed, 21 Feb 2018 13:00:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752158AbeBUU6E (ORCPT + 99 others); Wed, 21 Feb 2018 15:58:04 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:47077 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751360AbeBUU54 (ORCPT ); Wed, 21 Feb 2018 15:57:56 -0500 Received: by mail.free-electrons.com (Postfix, from userid 110) id 55510207F8; Wed, 21 Feb 2018 21:57:53 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [88.191.26.124]) by mail.free-electrons.com (Postfix) with ESMTPSA id 51AE520A4D; Wed, 21 Feb 2018 21:57:17 +0100 (CET) From: Alexandre Belloni To: linux-rtc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH 091/100] rtc: s35390a: remove useless message Date: Wed, 21 Feb 2018 21:56:26 +0100 Message-Id: <20180221205635.31314-92-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180221205635.31314-1-alexandre.belloni@bootlin.com> References: <20180221205635.31314-1-alexandre.belloni@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is not necessary to print a message when the time is invalid as userspace will already get an error (and an optional dev_dbg message). Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-s35390a.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/rtc/rtc-s35390a.c b/drivers/rtc/rtc-s35390a.c index 7067bca5c20d..604f527a1235 100644 --- a/drivers/rtc/rtc-s35390a.c +++ b/drivers/rtc/rtc-s35390a.c @@ -450,7 +450,6 @@ static int s35390a_probe(struct i2c_client *client, int err, err_read; unsigned int i; struct s35390a *s35390a; - struct rtc_time tm; char buf, status1; if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) { @@ -508,9 +507,6 @@ static int s35390a_probe(struct i2c_client *client, } } - if (err_read > 0 || s35390a_get_datetime(client, &tm) < 0) - dev_warn(&client->dev, "clock needs to be set\n"); - device_set_wakeup_capable(&client->dev, 1); s35390a->rtc = devm_rtc_device_register(&client->dev, -- 2.16.1