Received: by 10.223.185.116 with SMTP id b49csp1147698wrg; Wed, 21 Feb 2018 13:00:25 -0800 (PST) X-Google-Smtp-Source: AH8x226ISOK7Wuqmda/WYIvqt4iMPruNdjQIer6/lanrMKXuCEMxLFCoXMg6WGnu4REPNJ2rhCyV X-Received: by 2002:a17:902:b40d:: with SMTP id x13-v6mr4236240plr.320.1519246825367; Wed, 21 Feb 2018 13:00:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519246825; cv=none; d=google.com; s=arc-20160816; b=dW1JyNfAe1KGy1daed5bJhlyM003M6klST3ZUYLiD6qr2wVR0+q0VDwXAzedpP2Rir B/IZg/NC1vhukj+nRI6Y4J+1tGMYBcqovP/KTZAGf2Sb4mV5ptXn3TwrZzsa/Mg1+s4R 8ERTP3b9AHFQepafMjStYT4JAk4JMEFnN4kEOnu0rhERm4Qag3PI7jkfS1dfvYLuTwJk Sv/Gw8OpJ0VXNNj9o/FxEHxHlY5dpprLK2VcXbXkg+ODmo9B2An7+QB6aG89F3wcoEH3 Oaaqx+c4/hYFV6z5lNR30XP6v3534enfOHfBAT+Woun+7M2KaLNCqlqeraSSeBTEjj/W h2OQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=5L+q5Je8Bxeo8FBAVFYuWJTqqX9q2ay/kCAFuJcYsGk=; b=lo1Yaflfuf+U3yRj1k/wmYrxKsG/vMSfGv/8WKGGpAJOUfkIDlx04GCd1Mi7DvB3Ng XE9MnJpfW0TzTyodm8byiTp7LSkRYWSgN1FAN1wpZ7uxrnO/sT6wIS+D7t6COJGSBVoW vHsm4TduLH8u3ytl1Z/BZA5iC1ntn565/LgTWFDLuQ6NMpzHwFb5Wh91cW1OqCngDtNl QZDTl61R2fK0uVEX0OdI9CJjkgllPsvPwVJpnKZVrg6HUai5ezIDGYf7zk2jEFgQVmze p9cguVpvbF3iSGEr2nrzYr/NPXpQZwoBcUJa5m3/fo4DJ0TkuxmLQ1OZWZ1kBY5BwPaZ gUUA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r20si1684420pgu.423.2018.02.21.13.00.10; Wed, 21 Feb 2018 13:00:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752342AbeBUU7A (ORCPT + 99 others); Wed, 21 Feb 2018 15:59:00 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:47089 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751887AbeBUU6D (ORCPT ); Wed, 21 Feb 2018 15:58:03 -0500 Received: by mail.free-electrons.com (Postfix, from userid 110) id D7BE8207BB; Wed, 21 Feb 2018 21:58:01 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [88.191.26.124]) by mail.free-electrons.com (Postfix) with ESMTPSA id 34C2E20C32; Wed, 21 Feb 2018 21:57:18 +0100 (CET) From: Alexandre Belloni To: linux-rtc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH 094/100] rtc: rs5c372: remove useless message Date: Wed, 21 Feb 2018 21:56:29 +0100 Message-Id: <20180221205635.31314-95-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180221205635.31314-1-alexandre.belloni@bootlin.com> References: <20180221205635.31314-1-alexandre.belloni@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is not necessary to print a message when the time is invalid as userspace will already get an error (and an optional dev_dbg message). Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rs5c372.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/rtc/rtc-rs5c372.c b/drivers/rtc/rtc-rs5c372.c index d4eff8d7131f..37aa78fd2c4d 100644 --- a/drivers/rtc/rtc-rs5c372.c +++ b/drivers/rtc/rtc-rs5c372.c @@ -581,7 +581,6 @@ static int rs5c372_probe(struct i2c_client *client, int err = 0; int smbus_mode = 0; struct rs5c372 *rs5c372; - struct rtc_time tm; dev_dbg(&client->dev, "%s\n", __func__); @@ -662,9 +661,6 @@ static int rs5c372_probe(struct i2c_client *client, goto exit; } - if (rs5c372_get_datetime(client, &tm) < 0) - dev_warn(&client->dev, "clock needs to be set\n"); - dev_info(&client->dev, "%s found, %s\n", ({ char *s; switch (rs5c372->type) { case rtc_r2025sd: s = "r2025sd"; break; -- 2.16.1