Received: by 10.223.185.116 with SMTP id b49csp1152755wrg; Wed, 21 Feb 2018 13:04:24 -0800 (PST) X-Google-Smtp-Source: AH8x227AG/rky5NREYwLrdUcVTtjubworZ22uZmip9IFQTYKiidxNnt/AiYs954zRzzpeutqD+w3 X-Received: by 10.101.66.129 with SMTP id j1mr3663943pgp.56.1519247063972; Wed, 21 Feb 2018 13:04:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519247063; cv=none; d=google.com; s=arc-20160816; b=rhEcxTfW5ENa/cWdlT91AD0soNpffScUTY7cE6GWvbTdYsaazVtixHLu4SG0J3Lk4J n9B7pPFZX5Aw2L6SAtkc/pYKg8OA26afq8llo6IxXRFK5fCb01F59chdO+0ySVUOSmIT 4q7IBPUh1oV+oE5Mvmi1jHpy9nRQ/astVtmtrRKg7OA8kd7Naf+LSg08nj3ybcgv0vPl s3FpoKeF3MG8X2sKSjPos5Tcx/7r8f/s1HYq8mn3bt7vj1bxCKKOnttc/ApoN4iFa6J4 tlBflClVDGpwdO+TkR8EOqthuhz6721WJzRGot5B9eky6kpiaPn2eo5d6pumrocz7G0d McbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=U32MNJCmzHCWbv2W2/r7gtdiqciJ2TkIgScKDaVb+kI=; b=AdYT2ZhUJB6IfU7+d5Gy3FCoYKDDnURdHMp4s9mn2TpTSjk1TfqKKAzD3sZLxz1Go4 waVCywI/r+VcputALyqldPZPTsAGUB0vYUNqrcz6MK9SYL911x03SGTkD9CF2bVlEXtt RUbCBGOVHlpdQ6GIlQteGPZKUkKzSItL8Gm8RubNm7uT3D3BcYMzYR12IoeGPjBJ1UMZ +ptte5FNFO4Lv9OiAeZJj8UZfr/xX4ec8vyNObOztw05qdxnRSBD2ghEykn25e0/9wIy m6byyWGuWr8ts7/zDZ2e84lJZ+g+CrbIWtl4YakIzLGPQfJ5DvzIXyHvLwhV+hNtpAdK 8rHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a13si2359885pgu.178.2018.02.21.13.04.09; Wed, 21 Feb 2018 13:04:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752293AbeBUU65 (ORCPT + 99 others); Wed, 21 Feb 2018 15:58:57 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:47090 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752137AbeBUU6D (ORCPT ); Wed, 21 Feb 2018 15:58:03 -0500 Received: by mail.free-electrons.com (Postfix, from userid 110) id DBB4C207CC; Wed, 21 Feb 2018 21:58:01 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [88.191.26.124]) by mail.free-electrons.com (Postfix) with ESMTPSA id 79DA620D96; Wed, 21 Feb 2018 21:57:18 +0100 (CET) From: Alexandre Belloni To: linux-rtc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH 095/100] rtc: rs5c372: stop validating rtc_time in .read_time Date: Wed, 21 Feb 2018 21:56:30 +0100 Message-Id: <20180221205635.31314-96-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180221205635.31314-1-alexandre.belloni@bootlin.com> References: <20180221205635.31314-1-alexandre.belloni@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rs5c372.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/rtc/rtc-rs5c372.c b/drivers/rtc/rtc-rs5c372.c index 37aa78fd2c4d..ae7fa4324b0a 100644 --- a/drivers/rtc/rtc-rs5c372.c +++ b/drivers/rtc/rtc-rs5c372.c @@ -234,8 +234,7 @@ static int rs5c372_get_datetime(struct i2c_client *client, struct rtc_time *tm) tm->tm_sec, tm->tm_min, tm->tm_hour, tm->tm_mday, tm->tm_mon, tm->tm_year, tm->tm_wday); - /* rtc might need initialization */ - return rtc_valid_tm(tm); + return 0; } static int rs5c372_set_datetime(struct i2c_client *client, struct rtc_time *tm) -- 2.16.1