Received: by 10.223.185.116 with SMTP id b49csp1153277wrg; Wed, 21 Feb 2018 13:04:55 -0800 (PST) X-Google-Smtp-Source: AH8x2269CDgv6ZnjhGwxcnuwLn44l9FKKNDyG/L7TN0Uw+xM4pjL8to9wugPw5IQzIwAlGKbTdaq X-Received: by 10.99.0.209 with SMTP id 200mr591643pga.283.1519247094900; Wed, 21 Feb 2018 13:04:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519247094; cv=none; d=google.com; s=arc-20160816; b=AACkHlsTSu/KkjJN2WmqDIs812CtV0WOL2eHWNqWCwMLNSizU5Nu01p9MEbluSjSM+ i2eu2/GG3TWuLpkN/zLbtqjHVGEKy15ycxCILcnF77WoqaEn9hjk6dLZw0rJAodItozo 1a13Itse+7JWscYohwcFmQcoitTshA9k+MpLQCkgBDb+1LGr+/HSXIhnOVpTfIoR+n9f UXh1wug3Y2a3koityPXhXBUfWc7zCgAMq2+Tj7G8gjgZrntQMkIxubJf0Qt16qzOsmue 6O5+ijZe4FD2cStAhQaowbk0U9/glYvnRkedLg44eWQczx91vi8AxbBVYRW47tFNkxVa LH6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=2eJdiYEBvr8jlvN2mnSPixM2Z4xLb4fuhJvLHEg6ZgE=; b=AmbTlZ4yexBL8HawHdcTIQkdErbErhA/A8FQ5Ak0at+RI2BLC2PA/AoKYWd9S3cN0E ErINpPRps90t+mH4OeyADVPx4naGbqw0zSXUyygJj1pZHApyGomnPtMofBRX/s3QQQPe uKnqcrjnO0bV+hzcBpx4iEmMKaUBhN4srwnTHd0KoadMdmhitZkFc0S4dqIlvGC9KFob 5cNV/z68wBK1HgE5qormPWNwU06RhCNJCI48Pyoa4UU0k0mykM6JZaSpfkJPGbTSI+HW wakwb/zmnBcH/HblBHP4C/L5lXvROgelUqNgS/zB7G0TdlbYRLiMzBU66vxNYVJZAprH loGQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c5-v6si2148319plo.194.2018.02.21.13.04.39; Wed, 21 Feb 2018 13:04:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752275AbeBUU64 (ORCPT + 99 others); Wed, 21 Feb 2018 15:58:56 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:47092 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752139AbeBUU6D (ORCPT ); Wed, 21 Feb 2018 15:58:03 -0500 Received: by mail.free-electrons.com (Postfix, from userid 110) id EE711207E2; Wed, 21 Feb 2018 21:58:01 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [88.191.26.124]) by mail.free-electrons.com (Postfix) with ESMTPSA id C662820DB6; Wed, 21 Feb 2018 21:57:18 +0100 (CET) From: Alexandre Belloni To: linux-rtc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH 096/100] rtc: rs5c372: remove useless indirection Date: Wed, 21 Feb 2018 21:56:31 +0100 Message-Id: <20180221205635.31314-97-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180221205635.31314-1-alexandre.belloni@bootlin.com> References: <20180221205635.31314-1-alexandre.belloni@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org rs5c372_get_datetime and rs5c372_set_datetime are only used after casting dev to an i2c_client. Remove that useless indirection. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rs5c372.c | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/rtc/rtc-rs5c372.c b/drivers/rtc/rtc-rs5c372.c index ae7fa4324b0a..c5038329058c 100644 --- a/drivers/rtc/rtc-rs5c372.c +++ b/drivers/rtc/rtc-rs5c372.c @@ -207,8 +207,9 @@ static unsigned rs5c_hr2reg(struct rs5c372 *rs5c, unsigned hour) return bin2bcd(hour); } -static int rs5c372_get_datetime(struct i2c_client *client, struct rtc_time *tm) +static int rs5c372_rtc_read_time(struct device *dev, struct rtc_time *tm) { + struct i2c_client *client = to_i2c_client(dev); struct rs5c372 *rs5c = i2c_get_clientdata(client); int status = rs5c_get_regs(rs5c); @@ -237,8 +238,9 @@ static int rs5c372_get_datetime(struct i2c_client *client, struct rtc_time *tm) return 0; } -static int rs5c372_set_datetime(struct i2c_client *client, struct rtc_time *tm) +static int rs5c372_rtc_set_time(struct device *dev, struct rtc_time *tm) { + struct i2c_client *client = to_i2c_client(dev); struct rs5c372 *rs5c = i2c_get_clientdata(client); unsigned char buf[7]; int addr; @@ -304,17 +306,6 @@ static int rs5c372_get_trim(struct i2c_client *client, int *osc, int *trim) } #endif -static int rs5c372_rtc_read_time(struct device *dev, struct rtc_time *tm) -{ - return rs5c372_get_datetime(to_i2c_client(dev), tm); -} - -static int rs5c372_rtc_set_time(struct device *dev, struct rtc_time *tm) -{ - return rs5c372_set_datetime(to_i2c_client(dev), tm); -} - - static int rs5c_rtc_alarm_irq_enable(struct device *dev, unsigned int enabled) { struct i2c_client *client = to_i2c_client(dev); -- 2.16.1