Received: by 10.223.185.116 with SMTP id b49csp1153444wrg; Wed, 21 Feb 2018 13:05:04 -0800 (PST) X-Google-Smtp-Source: AH8x227Wd5U8cfTFHFnRpEatdfL8XyfGuqqfFiJwcdGwA/OgZTFpM3hceuwHJ4viNSS9t0F9ZMaW X-Received: by 10.101.101.84 with SMTP id a20mr3764083pgw.163.1519247104192; Wed, 21 Feb 2018 13:05:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519247104; cv=none; d=google.com; s=arc-20160816; b=mRnmVH8Op5acRHe2BrtI7zaXD1uzKqUvqEdVS/yZYvkWKajLlQme1YSE+rCJcNpFxl T/18leMODg3UzlmX3QaG1pRMSI5/SKgevn3cuEJJiW7I3zu3A1lJqy1jg4z31TZLBrl0 Lr0G4cVUgYhCd8XrKsvxePHxO9lQI89j2yNGWLAiMXZIsLcDI4epSPEyBzkwRLjiuMAa yzt9dl5TVXkb2nXWaVFmjD7JPRmOWqSboCMiDSnGWZSt0ufsjEQm4byy+PgnfXVkrnY/ RK0JfQdsAaLbPDxRkl6goeRl6BQVI//ttcsaW3nA8uGREBaQkFjqYnEQU2G6TijaKhuT kH/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=4/h8CR6K/jYkQBjk1ln/Uwzwc/ha2ur0PlDP/KYr6mg=; b=FRG4gZOYxE0dO113jQwMyNYR4xKBpqbxipuSXsFKMXnrKNnJxk+0z9h328DvcCH1Lu SIPVxajJs455IZLXYAya24ls2lipCK+H+S6Jp1JjTBmbyqE4MXhVMenVNIrQWayr2YoY s50gSwN2GtVBHj7v1OcDlBqN7rTqzjZwdosl9CaopLGknSE/32blrZfVx73ryjLX0YyG GZUUVo7FqL66rgwFd2HjjE31gDtcgWn+4FmbVyL2WsNvCnblIOQRmwtnBHFmm8JM3w27 pHCTvUkW6wX2wHIGk5CCSn1oEB/WBjVV7vXjvDvBGCtWDx6wi5evgY7R3qyuZmMkVYkg UCbw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n5si4060301pgc.459.2018.02.21.13.04.49; Wed, 21 Feb 2018 13:05:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752130AbeBUU6C (ORCPT + 99 others); Wed, 21 Feb 2018 15:58:02 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:47084 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751887AbeBUU5z (ORCPT ); Wed, 21 Feb 2018 15:57:55 -0500 Received: by mail.free-electrons.com (Postfix, from userid 110) id B7FF8207F6; Wed, 21 Feb 2018 21:57:52 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [88.191.26.124]) by mail.free-electrons.com (Postfix) with ESMTPSA id 2083420948; Wed, 21 Feb 2018 21:57:16 +0100 (CET) From: Alexandre Belloni To: linux-rtc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH 087/100] rtc: rx8581: remove useless message Date: Wed, 21 Feb 2018 21:56:22 +0100 Message-Id: <20180221205635.31314-88-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180221205635.31314-1-alexandre.belloni@bootlin.com> References: <20180221205635.31314-1-alexandre.belloni@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is not necessary to print a message when the time is invalid as userspace will already get an error (and an optional dev_dbg message). Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rx8581.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-rx8581.c b/drivers/rtc/rtc-rx8581.c index 9998d7937688..32caadf912ca 100644 --- a/drivers/rtc/rtc-rx8581.c +++ b/drivers/rtc/rtc-rx8581.c @@ -164,11 +164,7 @@ static int rx8581_get_datetime(struct i2c_client *client, struct rtc_time *tm) tm->tm_sec, tm->tm_min, tm->tm_hour, tm->tm_mday, tm->tm_mon, tm->tm_year, tm->tm_wday); - err = rtc_valid_tm(tm); - if (err < 0) - dev_err(&client->dev, "retrieved date/time is not valid.\n"); - - return err; + return 0; } static int rx8581_set_datetime(struct i2c_client *client, struct rtc_time *tm) -- 2.16.1