Received: by 10.223.185.116 with SMTP id b49csp1155703wrg; Wed, 21 Feb 2018 13:07:31 -0800 (PST) X-Google-Smtp-Source: AH8x2262CLbtDQ/wkpwccyQBHAUJiE3aXPYbyZ2L4oqfytYAWvewOehGmwtV5koxu9FOBc0Lfd/6 X-Received: by 10.99.103.69 with SMTP id b66mr3708601pgc.233.1519247251078; Wed, 21 Feb 2018 13:07:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519247251; cv=none; d=google.com; s=arc-20160816; b=WeYStBCVGtHwcrWN6qD0z4MJPKt4am6K7dotkK8kUUUF69AE7KpztnuglTG+1j3SEC d8ukea3pu4JMYh/sbtsrTPE4Kwb5UcqSVVRNK3DudN5q++YMKUPjnxrqFKrQOutmoTti 0VUePcoR0GjSvyF6s+Xk0Ffc/TfO4zbqkPNdgAFBuGjrVe9TAWmmeRgu6MggRf6UG+W6 4B1uAs2Mt7NCTvK/sB80HXp2CA+Lhus9N/MTPpSrlMdYQqu5xb/CSL/8ma04fBlArvM1 IgLMMk2YKB2mqOUo6tkbx5ubgvuiJHm4EYeqlHwwGv1qF+2zEyiriPWZAboAis4Y7GtK RDrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=h635iGu3R4hDJOboGiNYtdc9WkAvMoSrDPHJ2XlM+Xk=; b=PSGTx29lI8Yw8LExuMba76fZtcUULKioNGAPMdRaBkLERjuy5PdOl0pp5KeliK+ri4 MmRl5K+SmlVFi7HsaTNVsciHXLRHVCw8qyzNWbOAQCq9sUlTZ5YzRguvWTOiUwGlHDjI vaAAxnEwChf1427e+oo9ynxmtYkkmsWwoeiJZQa893MDlSTsbh4vmJ7MWNZoHwjkWJ1e hpHX4SZVtCG3QWEQr7/ORWmbUdXNYjhFi3j+LbsLFJlgf7HcKISdkmQFCNQH1meyVO5f 4Uf/iDppziQc6I5gqj1YnLFvM/MP1d782qsH3tpj10FrgOwoKGpvB9KyYi++m/QLew/S 3tkQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n5si4060301pgc.459.2018.02.21.13.07.16; Wed, 21 Feb 2018 13:07:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752173AbeBUVF0 (ORCPT + 99 others); Wed, 21 Feb 2018 16:05:26 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:47061 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751901AbeBUU5x (ORCPT ); Wed, 21 Feb 2018 15:57:53 -0500 Received: by mail.free-electrons.com (Postfix, from userid 110) id B8146207D7; Wed, 21 Feb 2018 21:57:51 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [88.191.26.124]) by mail.free-electrons.com (Postfix) with ESMTPSA id 434B1207CC; Wed, 21 Feb 2018 21:57:13 +0100 (CET) From: Alexandre Belloni To: linux-rtc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH 077/100] rtc: isl12022: remove useless indirection Date: Wed, 21 Feb 2018 21:56:12 +0100 Message-Id: <20180221205635.31314-78-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180221205635.31314-1-alexandre.belloni@bootlin.com> References: <20180221205635.31314-1-alexandre.belloni@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org isl12022_get_datetime and isl12022_set_datetime are only used after casting dev to an i2c_client. Remove that useless indirection. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-isl12022.c | 16 ++++------------ 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/rtc/rtc-isl12022.c b/drivers/rtc/rtc-isl12022.c index 46093cd13d5e..fa5c15d45070 100644 --- a/drivers/rtc/rtc-isl12022.c +++ b/drivers/rtc/rtc-isl12022.c @@ -104,8 +104,9 @@ static int isl12022_write_reg(struct i2c_client *client, * In the routines that deal directly with the isl12022 hardware, we use * rtc_time -- month 0-11, hour 0-23, yr = calendar year-epoch. */ -static int isl12022_get_datetime(struct i2c_client *client, struct rtc_time *tm) +static int isl12022_rtc_read_time(struct device *dev, struct rtc_time *tm) { + struct i2c_client *client = to_i2c_client(dev); uint8_t buf[ISL12022_REG_INT + 1]; int ret; @@ -152,8 +153,9 @@ static int isl12022_get_datetime(struct i2c_client *client, struct rtc_time *tm) return 0; } -static int isl12022_set_datetime(struct i2c_client *client, struct rtc_time *tm) +static int isl12022_rtc_set_time(struct device *dev, struct rtc_time *tm) { + struct i2c_client *client = to_i2c_client(dev); struct isl12022 *isl12022 = i2c_get_clientdata(client); size_t i; int ret; @@ -228,16 +230,6 @@ static int isl12022_set_datetime(struct i2c_client *client, struct rtc_time *tm) return 0; } -static int isl12022_rtc_read_time(struct device *dev, struct rtc_time *tm) -{ - return isl12022_get_datetime(to_i2c_client(dev), tm); -} - -static int isl12022_rtc_set_time(struct device *dev, struct rtc_time *tm) -{ - return isl12022_set_datetime(to_i2c_client(dev), tm); -} - static const struct rtc_class_ops isl12022_rtc_ops = { .read_time = isl12022_rtc_read_time, .set_time = isl12022_rtc_set_time, -- 2.16.1