Received: by 10.223.185.116 with SMTP id b49csp1155892wrg; Wed, 21 Feb 2018 13:07:44 -0800 (PST) X-Google-Smtp-Source: AH8x226fDnHnNRjb6pUKlQ+9roPiZ4Z27zUP+Cdg4RgZU1b4CNfuFma47+MYyVHFLMdAqZeWLcaA X-Received: by 10.98.64.146 with SMTP id f18mr4597079pfd.30.1519247264087; Wed, 21 Feb 2018 13:07:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519247264; cv=none; d=google.com; s=arc-20160816; b=qgNubC0C3XF3WGv5R3+EWrsELmThVGZaMarJG8V0RvGfm+AMIAZ1PfPjJRdLDb9oFH sBLfR939Wtd4U8rZ94P2OAymRRXDfX/NH9B0K86eXP7yxkHwIZJBsaYzacdtvvVnvRIX VZgea9SUF9vi1XOJIpXm+nNMyo+Q5J6cmN/6ooG3iPl27hSzVOneHIaERYRsbFshQnYa uCPoUu9/fkvVu19JUTeCYCa9DUiQcCY0gS32VpBMdnSQDbQpRjcWyHfe3+cRYkn73gig qMCjX7lHE0XXlVPbVF07ss+YgbnU1YZ+sQyJT1UoD0rkJP/mYsLwmbazBi+BL76ZMqZv nbIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=lLUjxvsz92QpU6/njyuBNm7lxQcXaUodYQgOPBeT0xk=; b=fLBjTXhb5e5teXkdyp2CM0FHtilwlvsFVGBCOBTaWfzXmUnqWtkrimGOtgpxl2Pmz6 lX8yZ13YPN/SdzQGm1vErLGAyZfJU2t9W0QcXIAgZl0QGV1RJOJTPGvStcF+PwEUV1yt 4BG0uyq6oWmv5TwIsl0LntqC0DnppYVqMty9Hqq7BPIh5oDf5XXrYmrOWDGYUphzx3c1 2CJibbo6gca5aiAiAPcO6vUOIu2hzht1Qz1oDjtWD/Q8A288t9UuqiZzq/3FkPRky94D R4pvczg0sgS5Y6L/6EwC1FyxA+s3bW4voJ10gAbF8Z4pUP3En5ewNL9fKAj3BRZob3dz fYEw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m8si119003pgu.551.2018.02.21.13.07.29; Wed, 21 Feb 2018 13:07:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752335AbeBUVFT (ORCPT + 99 others); Wed, 21 Feb 2018 16:05:19 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:47080 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752008AbeBUU5z (ORCPT ); Wed, 21 Feb 2018 15:57:55 -0500 Received: by mail.free-electrons.com (Postfix, from userid 110) id 2E1F5207F1; Wed, 21 Feb 2018 21:57:52 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [88.191.26.124]) by mail.free-electrons.com (Postfix) with ESMTPSA id 4036C207FE; Wed, 21 Feb 2018 21:57:15 +0100 (CET) From: Alexandre Belloni To: linux-rtc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH 084/100] rtc: abx80x: remove useless message Date: Wed, 21 Feb 2018 21:56:19 +0100 Message-Id: <20180221205635.31314-85-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180221205635.31314-1-alexandre.belloni@bootlin.com> References: <20180221205635.31314-1-alexandre.belloni@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is not necessary to print a message when the time is invalid as userspace will already get an error (and an optional dev_dbg message). Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-abx80x.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-abx80x.c b/drivers/rtc/rtc-abx80x.c index b033bc556f5d..2cefa67a1132 100644 --- a/drivers/rtc/rtc-abx80x.c +++ b/drivers/rtc/rtc-abx80x.c @@ -172,11 +172,7 @@ static int abx80x_rtc_read_time(struct device *dev, struct rtc_time *tm) tm->tm_mon = bcd2bin(buf[ABX8XX_REG_MO] & 0x1F) - 1; tm->tm_year = bcd2bin(buf[ABX8XX_REG_YR]) + 100; - err = rtc_valid_tm(tm); - if (err < 0) - dev_err(&client->dev, "retrieved date/time is not valid.\n"); - - return err; + return 0; } static int abx80x_rtc_set_time(struct device *dev, struct rtc_time *tm) -- 2.16.1