Received: by 10.223.185.116 with SMTP id b49csp1156616wrg; Wed, 21 Feb 2018 13:08:30 -0800 (PST) X-Google-Smtp-Source: AH8x224M2JSaY/sOgQRDaXT/+SHlLp1cJP9fzDzp26FomV88QUDO33gw0kXccrtJWoZCr9p3q1yk X-Received: by 10.98.14.70 with SMTP id w67mr4541983pfi.1.1519247310332; Wed, 21 Feb 2018 13:08:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519247310; cv=none; d=google.com; s=arc-20160816; b=We7HnUWl43858U6/Q0czOK86kj/OonjQlU8cuUQBtizDOIjphX+caaOc+U/r7Ty119 Xppm+K3nL5xwt6aTzVca5UQw3NG92nN0zHWoliVNJYPouS3bh972s+zMs+i5+7gOhK5K doyD+3eQkKhFD3D4ms/YQjuF1srQM7Htf0KdmI1PZO0buiOF701tUprLJFSRoLYX04N6 6OsyGYilAwaMgrj8cE8dzwTZyuOQD2HXWW9yD9DbTNTOGFcWFWxQ4mhaXxBpX/yVhhYU ghUMIxVN88xI4UxBswPZmY7Vz3KULLUGEYySc5m5NC9lRv4FvcVvOLw/E0Ol4QET96lA ujNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=x9pY6TRfqjGL1w6fEdFWrysE4kuwbe4tN4LmTrPI4Uk=; b=jBT5BzyHG1bJ5rhWMibheQAifiKR2JQ67R8oY/Uw2Fagevto0SKDMZIGU/RLkxtXeZ pK2wmHADMi6othNs16PJ/SMqgOeJ9NjvlnYYKYMJRXvTlTwMlVO3OqTThT+qDDtMgwP6 ZLdp+WTc2QGNuLLKMB8vRyGOk5cSVZjUbAHgq+XG72ba8WUgagLB0IN5m3nstMxS9w3J 1Y9nvK9FW+hFvbs4JJL4wl2tozA/d6KfM+Vk4maWK8luvIY6jUBiJGrzs7vlVlZqkD97 3It12E4vfLB+c+qbowvFukYH4nuM8B0S5J8DEMnQXP6SjhYCH3HNxlQU6p6ele7Cio4y Oebw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r62si1470240pgr.77.2018.02.21.13.08.15; Wed, 21 Feb 2018 13:08:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752052AbeBUVFQ (ORCPT + 99 others); Wed, 21 Feb 2018 16:05:16 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:47081 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752013AbeBUU5z (ORCPT ); Wed, 21 Feb 2018 15:57:55 -0500 Received: by mail.free-electrons.com (Postfix, from userid 110) id 66F8C207F5; Wed, 21 Feb 2018 21:57:52 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [88.191.26.124]) by mail.free-electrons.com (Postfix) with ESMTPSA id D450A208A2; Wed, 21 Feb 2018 21:57:15 +0100 (CET) From: Alexandre Belloni To: linux-rtc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH 086/100] rtc: rx4581: remove useless message Date: Wed, 21 Feb 2018 21:56:21 +0100 Message-Id: <20180221205635.31314-87-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180221205635.31314-1-alexandre.belloni@bootlin.com> References: <20180221205635.31314-1-alexandre.belloni@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org It is not necessary to print a message when the time is invalid as userspace will already get an error (and an optional dev_dbg message). Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-rx4581.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/rtc/rtc-rx4581.c b/drivers/rtc/rtc-rx4581.c index de3fe4f8d133..c59a218bdd87 100644 --- a/drivers/rtc/rtc-rx4581.c +++ b/drivers/rtc/rtc-rx4581.c @@ -172,11 +172,7 @@ static int rx4581_get_datetime(struct device *dev, struct rtc_time *tm) tm->tm_sec, tm->tm_min, tm->tm_hour, tm->tm_mday, tm->tm_mon, tm->tm_year, tm->tm_wday); - err = rtc_valid_tm(tm); - if (err < 0) - dev_err(dev, "retrieved date/time is not valid.\n"); - - return err; + return 0; } static int rx4581_set_datetime(struct device *dev, struct rtc_time *tm) -- 2.16.1