Received: by 10.223.185.116 with SMTP id b49csp1156902wrg; Wed, 21 Feb 2018 13:08:50 -0800 (PST) X-Google-Smtp-Source: AH8x225SK0d7ZDMQMxVQ+bN8OFOn/syPVhRx89Ue4bNj6KTqoKy3aU3QtUz1q7ocyy0lpSlAnqDk X-Received: by 10.99.143.69 with SMTP id r5mr3718295pgn.160.1519247330563; Wed, 21 Feb 2018 13:08:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519247330; cv=none; d=google.com; s=arc-20160816; b=f2Ju/e6w3X7iIAIJRXIVH95XFP8X2GyJPGGMVMPEwWyszzTg7mPj+A91xW6bNmGzIZ GiZaAd/kAQGw6jYKFpMgWYqGvpKuV+x/3itNrvR8WtyZuvd++1K68ilUQUgDOeitU9Z9 uErdSf/WHubX4XmvB72zNfOXccJE1cFRiBC8FP98m4DGxRCuy8tZlQem49y9d+CfAvgw yicAtTL1qcQOz2R4oaHzolwFWmbd6Ye32bx10kEco0RcscBZyK0UV4YOXSck2llJs3xk hmzvhH90Gzl045qCEfVa7xnOcDGp5+ghu7T3+cHggsu6gsAeb1zE14+lbcI9DpjAzHed F+4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=F1OeEkcIpPsZhMgJlGUhnQLBksjZGpVShA79yiRZlNA=; b=MBAgOKoh6QzbrXG1MGAcWZio9+plvevxAJmgGJSoGemgjolm0H9WsZmACbWeUFC/yP RxzafPVH4e450Cj4ajAWqCGbxxz+dgB7vSBxO7E04xOTb7/ZoKku96jZvML0lq0FmvlG 3OTlxiWdkxfAAKmE63vTZPUGTxVS91HvMsJ9kTsBAnJ3OKv+Z3vU4XzLHCTD49SqUGYI FhFe7/A5QDTFlG3OAx3wF4HDt4K6oF1mFw1jdBC4Gzj6nMsY1aMLnZRRfBSDEi1V+x2R p+fO9rlJT8yoPt5RNowqV/9AVljFlIJeg6Ad4pjOshEASFk64CTwQGazaiMiMm9SzZ9C 185Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1-v6si2126471plw.164.2018.02.21.13.08.36; Wed, 21 Feb 2018 13:08:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751962AbeBUU5u (ORCPT + 99 others); Wed, 21 Feb 2018 15:57:50 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:47055 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751900AbeBUU5q (ORCPT ); Wed, 21 Feb 2018 15:57:46 -0500 Received: by mail.free-electrons.com (Postfix, from userid 110) id DF89C207EF; Wed, 21 Feb 2018 21:57:42 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [88.191.26.124]) by mail.free-electrons.com (Postfix) with ESMTPSA id B68BC207F1; Wed, 21 Feb 2018 21:57:11 +0100 (CET) From: Alexandre Belloni To: linux-rtc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH 072/100] rtc: tx4939: stop validating rtc_time in .read_time Date: Wed, 21 Feb 2018 21:56:07 +0100 Message-Id: <20180221205635.31314-73-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180221205635.31314-1-alexandre.belloni@bootlin.com> References: <20180221205635.31314-1-alexandre.belloni@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org rtc_time_to_tm never generates an invalid tm. It is not necessary to validate it. Also, the RTC core is always calling rtc_valid_tm after the read_time callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-tx4939.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-tx4939.c b/drivers/rtc/rtc-tx4939.c index 1f351308afdc..438bed6f3b28 100644 --- a/drivers/rtc/rtc-tx4939.c +++ b/drivers/rtc/rtc-tx4939.c @@ -112,7 +112,7 @@ static int tx4939_rtc_read_time(struct device *dev, struct rtc_time *tm) sec = ((unsigned long)buf[5] << 24) | (buf[4] << 16) | (buf[3] << 8) | buf[2]; rtc_time_to_tm(sec, tm); - return rtc_valid_tm(tm); + return 0; } static int tx4939_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm) -- 2.16.1