Received: by 10.223.185.116 with SMTP id b49csp1157392wrg; Wed, 21 Feb 2018 13:09:28 -0800 (PST) X-Google-Smtp-Source: AH8x224cwXtvJ6lveOHnc2vlKasfLXwDe6yOGYat71esvI4xWlhR1+4PLb5TxYTBiLSbPf/MtANo X-Received: by 10.101.96.71 with SMTP id b7mr3758684pgv.339.1519247368081; Wed, 21 Feb 2018 13:09:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519247368; cv=none; d=google.com; s=arc-20160816; b=Q6YvNfjv6gNhqIk/s+YZj/CW3eqVz1XiD0YzsbP/4yNSYaHJH6L6kVGNT8AalpUl3u OqByYXlQluGK+UJ3lCwaMFlpDJQ/QMk52I/PbCsoHgJQnQTcuBIP39mHjJAxuJIxR7cL qLPmvtLZrSLmOUkT2brltqraPaFDl9xgR0w7fGSiDdEbq6Gtj7AbG+zDhIR1jOQCGigi QlRvJEt5W44wHuB5Jhnf3bvEeCp9n9WteMZe1JGaeB2xJMtLsZfxjNUGtNnXEIPnad6X PW7j5VA9vYAhkVC5vOnV4UcNBes7BAkI5ZA0EQRNgFu2tlJwDNEuTN4h09s0+7Ht9anl j35w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=mtdS6bApXAO9A1TNzDWx37iSkrDaR2u/TjwYq/DzhY8=; b=E3doU6Q6H8KJJBmZ12buPmmPVJY8HaJWodhUwd/++4o1CxsmY1IVRDmYUfstd7C4eY a09mZy8RFQKGc3fAErsO7QXKbEWGWAe/z3KeGloJwJOCHsYRGMB4jAEj+K+EhNMRyjXD V8qX5UHmuV7QDtI4QVpyOd2hx7rRarQHcj5W5+MeiZakquOyaZnfVGAuyQXFZMRvtTwS 7oJcgOSTsqzeO4s0A+ZNxsJXHe/Efbs7Z3xvoEu78pcrFp0wkYOHlM9/Cz+7tvhPxilA zHNGvRFNlUUwDZ6s0iol1grZ9OBS/PAuvwbE+2wRRSwkK9mBqQfe3v79x+aL42sCa1rP ySpw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u6-v6si1948148plm.382.2018.02.21.13.09.13; Wed, 21 Feb 2018 13:09:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752108AbeBUVHt (ORCPT + 99 others); Wed, 21 Feb 2018 16:07:49 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:47040 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751898AbeBUU5p (ORCPT ); Wed, 21 Feb 2018 15:57:45 -0500 Received: by mail.free-electrons.com (Postfix, from userid 110) id 32093203B1; Wed, 21 Feb 2018 21:57:43 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [88.191.26.124]) by mail.free-electrons.com (Postfix) with ESMTPSA id 09402207F4; Wed, 21 Feb 2018 21:57:12 +0100 (CET) From: Alexandre Belloni To: linux-rtc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH 073/100] rtc: wm831x: stop validating rtc_time in .read_time Date: Wed, 21 Feb 2018 21:56:08 +0100 Message-Id: <20180221205635.31314-74-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180221205635.31314-1-alexandre.belloni@bootlin.com> References: <20180221205635.31314-1-alexandre.belloni@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org rtc_time_to_tm never generates an invalid tm. It is not necessary to validate it. Also, the RTC core is always calling rtc_valid_tm after the read_time callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-wm831x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-wm831x.c b/drivers/rtc/rtc-wm831x.c index 75aea4c4d334..7b824dabf104 100644 --- a/drivers/rtc/rtc-wm831x.c +++ b/drivers/rtc/rtc-wm831x.c @@ -156,7 +156,7 @@ static int wm831x_rtc_readtime(struct device *dev, struct rtc_time *tm) u32 time = (time1[0] << 16) | time1[1]; rtc_time_to_tm(time, tm); - return rtc_valid_tm(tm); + return 0; } } while (++count < WM831X_GET_TIME_RETRIES); -- 2.16.1