Received: by 10.223.185.116 with SMTP id b49csp1159212wrg; Wed, 21 Feb 2018 13:11:32 -0800 (PST) X-Google-Smtp-Source: AH8x226ooUd+htL5frJ9Z4zXmUYGBYD/0YH47U9iEc7L1URG0X2yBNmSr7IaqSNUMcUYpBPp8+Ij X-Received: by 10.101.100.147 with SMTP id e19mr3768914pgv.88.1519247492062; Wed, 21 Feb 2018 13:11:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519247492; cv=none; d=google.com; s=arc-20160816; b=hIh8ouPqoomnIzpOFxxbXy+smA11oOjlOiB8MNzmFU1w+/+3/XF3tQYO2zzq8brUKP 5t0+XzXBGx1XfzBxcyIxAdDCkkMa7GqB1PEBvswt6yvyiwCOmQsHAMVUEaex3E/D3GUt x55CPdzDI771iqYnT5M8QTyX97U2cWDmtt3vPiuL/wkCnt5XTkj0V7BdHHqVunum25A4 XQhQ5EkaQeDYDDghKL+Pp5EHyTtp0O4URoObQGgjs/2ayrnHylLef0iT02C0d78W4Ucj 7fkQscuU6rkqOeilUoO7CM5X6cLLWFC7zlJ6Pp81wxjfW1bBy5kzFwP3XdakHUs4ceYP /twA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=qK8oPJh84gDBwsQrfpdxHnnnmYeZx6VzvHcJVhY9Swk=; b=YzOysEMGEy8gQMqNJPtyzKcierwsAi0xlFinUQVT0dYrp58BD8/rdnYxnf9CiA1EU4 CzZY1c/iS3VZ811/Ctckv3dUIC3BK37EfhSKSY6F8UWWqdLdBw2/WtvoM5MhBsLQy535 oL2isUjldu86HfFskISXnCU8Ov7Tu+q9tu3rqCsDd1CcxJxt41aw2ulQY0b3FNr5rmMo 75P1inUw7QMVJiiPXoZSGSqW0ZL8b8Fw/175pWGPrFcPy6RmU33uuL6yD6UFJBaMcdB5 p05U4lWRWhtOb8oYg+qGFjCp+peiRZ4S3+ylTk2OlPt7yb//n8e/tWV6ioptedLp5EwV Njwg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f11si357348pgo.174.2018.02.21.13.11.17; Wed, 21 Feb 2018 13:11:32 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751878AbeBUU5n (ORCPT + 99 others); Wed, 21 Feb 2018 15:57:43 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:47009 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751729AbeBUU5g (ORCPT ); Wed, 21 Feb 2018 15:57:36 -0500 Received: by mail.free-electrons.com (Postfix, from userid 110) id 9106820800; Wed, 21 Feb 2018 21:57:31 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [88.191.26.124]) by mail.free-electrons.com (Postfix) with ESMTPSA id 3644420830; Wed, 21 Feb 2018 21:57:03 +0100 (CET) From: Alexandre Belloni To: linux-rtc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH 043/100] rtc: mc13xxx: stop validating rtc_time in .read_time Date: Wed, 21 Feb 2018 21:55:38 +0100 Message-Id: <20180221205635.31314-44-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180221205635.31314-1-alexandre.belloni@bootlin.com> References: <20180221205635.31314-1-alexandre.belloni@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org rtc_time64_to_tm never generates an invalid tm. It is not necessary to validate it. Also, the RTC core is always calling rtc_valid_tm after the read_time callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-mc13xxx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-mc13xxx.c b/drivers/rtc/rtc-mc13xxx.c index 30b8ef6a3676..1f892b238ddb 100644 --- a/drivers/rtc/rtc-mc13xxx.c +++ b/drivers/rtc/rtc-mc13xxx.c @@ -85,7 +85,7 @@ static int mc13xxx_rtc_read_time(struct device *dev, struct rtc_time *tm) rtc_time64_to_tm((time64_t)days1 * SEC_PER_DAY + seconds, tm); - return rtc_valid_tm(tm); + return 0; } static int mc13xxx_rtc_set_mmss(struct device *dev, time64_t secs) -- 2.16.1