Received: by 10.223.185.116 with SMTP id b49csp1164287wrg; Wed, 21 Feb 2018 13:17:24 -0800 (PST) X-Google-Smtp-Source: AH8x226EPLLJkUC6p4H7a7sAnny51ybV4ZlS53Y3Av5heuvK6A5BgS3JP8t9wNG8bAQLjWLK303Z X-Received: by 2002:a17:902:123:: with SMTP id 32-v6mr4430548plb.278.1519247844536; Wed, 21 Feb 2018 13:17:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519247844; cv=none; d=google.com; s=arc-20160816; b=lniN00k4qxKz/vMSVQWhl0R1rqxYiPHyCsigSuGNbTjxgi4vVSkSQ+k+p2s3avMGmd tDHybAwsJwzLPKcGOCO9Slz5t3WkD/dTIXs9D/2VVDLlNynVKSfyVK2Tv7lDFEdljgYb 4LnDrYzHtT4ceu+bPZlO0fnPeEQSy3wY2RgsI1uows8vPQ/QpQYVn1nhtVX64aerrcOM K8xHbn4sBsVwiWImOBlpjg8rDEH8yaOQrLvt5mxIt3lQhkEdkyDU0tuWZYKmWPgWaqLz Tv2LzpPJr1KCalpbWKHWBQF8wv8O1c8+oNLb/jkweRIHoJWtoh+2nkHFcfxWwccP8mRM bT/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=Nusskqipm7kqI5WgI+lB4UNFc0VBaQG5kNtbWgMUTtY=; b=mOLOmPk+wEpKQghXbwRsyoPP4cyd63BXS8N+/L0tiSXZEgvyqW3Vv4Qr3fjVCTpdAp 3KHHFqfhQo3oWIw0xsETsDyayriwYwkxNr9GTzeTXPtG/DFvRDGhQBuJhJ4ZyUeGfM29 ZMDVTbNqtTPV24LvBBzx9gT9VB3/0xiaczECtOBgUpQCNNNAT5Y2C4VuwP/IHBgfWeHS M25SyY3zgiZBSXWZT4cGw2qVWT5Yve54xOY9ex2k19acFgCG46xCxHpbeE8LW/YQ/Kdm GeHN6bQkzmFnIXG5c0461c9Lq4oY3Cx+f0jyny0G/KGvkwSKbpMqZiVoHnwkJroWglXm uskg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i1-v6si2683595pld.42.2018.02.21.13.17.10; Wed, 21 Feb 2018 13:17:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751680AbeBUU52 (ORCPT + 99 others); Wed, 21 Feb 2018 15:57:28 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:46975 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751573AbeBUU5Y (ORCPT ); Wed, 21 Feb 2018 15:57:24 -0500 Received: by mail.free-electrons.com (Postfix, from userid 110) id D80CC20800; Wed, 21 Feb 2018 21:57:21 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [88.191.26.124]) by mail.free-electrons.com (Postfix) with ESMTPSA id B9F3D20818; Wed, 21 Feb 2018 21:56:58 +0100 (CET) From: Alexandre Belloni To: linux-rtc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH 028/100] rtc: ds3232: stop validating rtc_time in .read_time Date: Wed, 21 Feb 2018 21:55:23 +0100 Message-Id: <20180221205635.31314-29-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180221205635.31314-1-alexandre.belloni@bootlin.com> References: <20180221205635.31314-1-alexandre.belloni@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-ds3232.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-ds3232.c b/drivers/rtc/rtc-ds3232.c index 0550f7ba464f..7184e5145f12 100644 --- a/drivers/rtc/rtc-ds3232.c +++ b/drivers/rtc/rtc-ds3232.c @@ -145,7 +145,7 @@ static int ds3232_read_time(struct device *dev, struct rtc_time *time) time->tm_year = bcd2bin(year) + add_century; - return rtc_valid_tm(time); + return 0; } static int ds3232_set_time(struct device *dev, struct rtc_time *time) -- 2.16.1