Received: by 10.223.185.116 with SMTP id b49csp1164596wrg; Wed, 21 Feb 2018 13:17:47 -0800 (PST) X-Google-Smtp-Source: AH8x227Qv0ZLxuOIUGOReN5oLoHCjuIUQAaiZgZWG1V/JS9hsu3roGdPYWyczGE8Czd/fpmmqbHx X-Received: by 2002:a17:902:1683:: with SMTP id h3-v6mr4370810plh.433.1519247867699; Wed, 21 Feb 2018 13:17:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519247867; cv=none; d=google.com; s=arc-20160816; b=TDnGy5o00T8WL4w09EamgJvIfEAH7RCsaGq9+qsfhS6+yTQU/RKxC+Z1I9nfAzbr6V AlfBpRiL0jhLzxnxACSkGPrVspDhTMQZuwrLgM8o2FXbsfcvwZ8ebzyBnLuDpo4wCaC1 MyHNmuU4M9CqZTCzF5TUOcxxMjX/8DQwjE9yQA3LDFEFVgpi+hEBW+KJSsFL4OJ+yKAM uQGWDrjsyyiZ/RRx1u+mF/GeBTEqkv9bAQdxYYMz5TBAh94wSb4g9MAh72zp/tQY7yoI QIV6OB4jGQE97r/OVZrVoHW/4ChBfmRLWpZyl9hzZ58erkO2QQfblmZK5vLVTUUuGY/X 5hOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=gsuYPg3H0K0vKYK/aLUFDVoI3tLXuTbLiBXK5mj2k90=; b=eJ89vY8hX4gSseJvISSJ+pA0mw7nBLsTMZbJPAt44qG/n8ly6YMXPzmDJHghCom84r K3Au79Nt+qUddu2N96wJsfAbA1OV5//6mN3BZH2cuHi01YAg4gR5g6Lpp7C68sy7MpOY 8pU589NqjEsh/BqnsPYLhRTNm7i+dSNNi/n1W9gxJ03T6zKgZQmz/6cpe1plRxCNZlGp //5laXOvs6jFskdjURWCYizhbYoFULeRBT7AYjFWkS3/X5kzGgx0EwuDLX3/0v1lUmwY Nz7RLjhC2fAJTurntyHgX0TcwOqhSpzzJrWsBpDQluzgYMBzBdwqvhn/QEr9xqW4u2WR zAXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g92-v6si127880plg.629.2018.02.21.13.17.33; Wed, 21 Feb 2018 13:17:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751634AbeBUU50 (ORCPT + 99 others); Wed, 21 Feb 2018 15:57:26 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:46968 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751567AbeBUU5Y (ORCPT ); Wed, 21 Feb 2018 15:57:24 -0500 Received: by mail.free-electrons.com (Postfix, from userid 110) id 7441C2080B; Wed, 21 Feb 2018 21:57:21 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [88.191.26.124]) by mail.free-electrons.com (Postfix) with ESMTPSA id 53F032080D; Wed, 21 Feb 2018 21:56:57 +0100 (CET) From: Alexandre Belloni To: linux-rtc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH 023/100] rtc: ds1347: stop validating rtc_time in .read_time Date: Wed, 21 Feb 2018 21:55:18 +0100 Message-Id: <20180221205635.31314-24-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180221205635.31314-1-alexandre.belloni@bootlin.com> References: <20180221205635.31314-1-alexandre.belloni@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-ds1347.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-ds1347.c b/drivers/rtc/rtc-ds1347.c index ccfc9d43eb1e..938512c676ee 100644 --- a/drivers/rtc/rtc-ds1347.c +++ b/drivers/rtc/rtc-ds1347.c @@ -66,7 +66,7 @@ static int ds1347_read_time(struct device *dev, struct rtc_time *dt) dt->tm_wday = bcd2bin(buf[5]) - 1; dt->tm_year = bcd2bin(buf[6]) + 100; - return rtc_valid_tm(dt); + return 0; } static int ds1347_set_time(struct device *dev, struct rtc_time *dt) -- 2.16.1