Received: by 10.223.185.116 with SMTP id b49csp1165965wrg; Wed, 21 Feb 2018 13:19:18 -0800 (PST) X-Google-Smtp-Source: AH8x226zezLNe1OOX1k90tc7+P+xH7zFHuTB9OuJP7rq0D5Nkpi78+Go36namL8Rb/mo28VD5122 X-Received: by 2002:a17:902:8214:: with SMTP id x20-v6mr4284864pln.182.1519247957924; Wed, 21 Feb 2018 13:19:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519247957; cv=none; d=google.com; s=arc-20160816; b=I+g3F4xbfF3ZN6XVRosgzrEyC2a78LoZmJofpx0CCDc4niuUu0Drm+uyEQx+rEuJ6d oVK73ccJ5u/X87NXUmb0FO+F5ZjNLgyEwnEVbNWUuLTPjX5Q0lGbuTwr4lqi3om7jDX1 CSjS4tjM7wO0hMOm01V/noHDKxrQvAtE3O0cwMCCv4oT98nS0z4eZXzEwMf1RKIntII+ E4ag8wh03VA8/faoxjaX3xoU1Lynin96+dnsRIPViNTHXW5pAbzbY1suRSgbfzVy+AyH sX2R9rk/IStHrmYjzm/h5ZGJ17BS32a4apP9N6+gMqMCEBAs6qOYByrOIByKjfISRcUo L5Gg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=D4PIxXlWPHyVtXgFFqykEMsXFTFDYRaj8237uGyXGKk=; b=uxModBXbjY6QpTLUNA34pLnIY/OUotADGt7SoENdDHjHqu0d1txsF+lrpspcspgWw8 Aoiud7ilxI6UQmI+ZmgcMegBcj5OsL3pYXd0FGxWLSZFKiJO3jimt1sRq4QHZwnHH9+7 T88phjVTKoezPOCDI+U5LI5XxunW/mw0eysuS4CZjPqgcl9K1ZTkl1eTLL1+3IUvVMSD mfMpBuF2JfPQzGfV7+QToRDwXGfoUOyk6qjzGrE5rgHmcMB0SlW4oQfsmPcJaui1QDna 5SxdGxGBYQ0WnrHB/G/XZoT4RjP7L71hiIZHfxMGi+j5wHQoLYWywi3MJlz0O4fAFQI6 PHHA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m186si2688225pfm.25.2018.02.21.13.19.03; Wed, 21 Feb 2018 13:19:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751825AbeBUVS1 (ORCPT + 99 others); Wed, 21 Feb 2018 16:18:27 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:46969 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751429AbeBUU5Y (ORCPT ); Wed, 21 Feb 2018 15:57:24 -0500 Received: by mail.free-electrons.com (Postfix, from userid 110) id 85DB52080D; Wed, 21 Feb 2018 21:57:21 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [88.191.26.124]) by mail.free-electrons.com (Postfix) with ESMTPSA id 9ABE720811; Wed, 21 Feb 2018 21:56:57 +0100 (CET) From: Alexandre Belloni To: linux-rtc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH 024/100] rtc: ds1390: stop validating rtc_time in .read_time Date: Wed, 21 Feb 2018 21:55:19 +0100 Message-Id: <20180221205635.31314-25-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180221205635.31314-1-alexandre.belloni@bootlin.com> References: <20180221205635.31314-1-alexandre.belloni@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-ds1390.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-ds1390.c b/drivers/rtc/rtc-ds1390.c index 4d5b007d7fc6..3b095401f848 100644 --- a/drivers/rtc/rtc-ds1390.c +++ b/drivers/rtc/rtc-ds1390.c @@ -153,7 +153,7 @@ static int ds1390_read_time(struct device *dev, struct rtc_time *dt) /* adjust for century bit */ dt->tm_year = bcd2bin(chip->txrx_buf[6]) + ((chip->txrx_buf[5] & 0x80) ? 100 : 0); - return rtc_valid_tm(dt); + return 0; } static int ds1390_set_time(struct device *dev, struct rtc_time *dt) -- 2.16.1