Received: by 10.223.185.116 with SMTP id b49csp1166699wrg; Wed, 21 Feb 2018 13:20:10 -0800 (PST) X-Google-Smtp-Source: AH8x225cxCubZFMAqyVHPSyDeJFdJx7aTyHa7QaBGOiwrUqBoWmrobpgUkprINX6/57J9j0q27OD X-Received: by 2002:a17:902:a512:: with SMTP id s18-v6mr4310862plq.296.1519248009916; Wed, 21 Feb 2018 13:20:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519248009; cv=none; d=google.com; s=arc-20160816; b=KFylSP17UshXxxcylxh2gMxZxwpgpXwvhOlh0v+plk491iqKdQe9FjZnwEDkbhgXsm C0P+mFpDtfxSxIEJ9aiSWp9ZVpQNvjrBxLid/E6izl9KpwrDtEHmbS/svj5DQ0+Lzikp 082XGl3aG64s016pK9ByF9PcONLew0pKvaJfx+G09f9D84eMddHBPKb/r0JkqJU/y1jy QYx0/FpR2opCV3XSe0NGnINF2JAku2MEwMm9lnac72206NFyO5ePFWskuS9WKugbgCwv DfPB8TRtjkTtlE7VVvZYXvQEU5P+VsrEaN/AXPvyKFT84mozD4Oz6scmx7gKyBJM/Jcm wRWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=74kWf/L5pZnR50+MKGXgnbFuAfqgXEq8Dv8irLawCBE=; b=RJCvteD1Z08m6RGBjrcsMUH4RD8ViXRpk9I9mh7dbDgl2DUXXKPRod0I5pWg4x09qm EZ0BmYT8l/eB1kR/1C1uSsz47A7XCrLWnE0CrxmcIrnoQFE+LKQzIUUAFQMNp+fyN4dZ CXw+0X3A6c6OL/a1UpTZZTieYsn1v0L29evY4bL+7V+nBEPQZfcBvzJNYKICBNGj/DJi V/4f2a4wQvvUeUaSjuOb+s6dPWKktbgZHHSAsfkI8QLVG2D+ndz4t3WmRs1KTVdJH0Xv FMRD/V4b2dCmJ8lVI6RvwWT/7GFyl57OiLsB9Gg/xvcPxRLZFCnMZmd152/MgaVyoTm6 Tbzg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i1-v6si2683595pld.42.2018.02.21.13.19.55; Wed, 21 Feb 2018 13:20:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751711AbeBUVSY (ORCPT + 99 others); Wed, 21 Feb 2018 16:18:24 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:46973 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751568AbeBUU5Y (ORCPT ); Wed, 21 Feb 2018 15:57:24 -0500 Received: by mail.free-electrons.com (Postfix, from userid 110) id 929D720811; Wed, 21 Feb 2018 21:57:21 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [88.191.26.124]) by mail.free-electrons.com (Postfix) with ESMTPSA id E0D5E20813; Wed, 21 Feb 2018 21:56:57 +0100 (CET) From: Alexandre Belloni To: linux-rtc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH 025/100] rtc: ds1685: stop validating rtc_time in .read_time Date: Wed, 21 Feb 2018 21:55:20 +0100 Message-Id: <20180221205635.31314-26-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180221205635.31314-1-alexandre.belloni@bootlin.com> References: <20180221205635.31314-1-alexandre.belloni@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-ds1685.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-ds1685.c b/drivers/rtc/rtc-ds1685.c index ed43b4311660..1a39829d2b40 100644 --- a/drivers/rtc/rtc-ds1685.c +++ b/drivers/rtc/rtc-ds1685.c @@ -306,7 +306,7 @@ ds1685_rtc_read_time(struct device *dev, struct rtc_time *tm) tm->tm_yday = rtc_year_days(tm->tm_mday, tm->tm_mon, tm->tm_year); tm->tm_isdst = 0; /* RTC has hardcoded timezone, so don't use. */ - return rtc_valid_tm(tm); + return 0; } /** -- 2.16.1