Received: by 10.223.185.116 with SMTP id b49csp1166888wrg; Wed, 21 Feb 2018 13:20:21 -0800 (PST) X-Google-Smtp-Source: AH8x225svxxLfceyNOhM7ByP0DHAPbvdQXUgFD48mgOYMPK/I5iKPtv1W0rbwhIeb03aJpWeTDA9 X-Received: by 2002:a17:902:6c4c:: with SMTP id h12-v6mr4278080pln.101.1519248020919; Wed, 21 Feb 2018 13:20:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1519248020; cv=none; d=google.com; s=arc-20160816; b=K+CiQVXgvDNJg3hDMCwPiWA5vN+Af+LxZVmkgCtokathf8oBNNa7wHIyOcX/ppc9o9 PC/mxTDYqNBl0qSUvmbpV02B46BRcTUt01VUO8r197Q7V6eRlv5rtq3SE42D7XXIZepe YE9lMX0EozZ2uzYF6Zc2bUCSDEQ0gqwXJ1/7D7LFAnaEngJ1oHoQydj2jypy278Iy90g BDlbIVtLXXVSWP4k0jLDzJrTOAumtbTt+oplTT1Zvrrhl2VVtZWPAB5Atun7Mot8D/8j ZZLLSOBuwDA1CcN+o6oaI4sAqi+14GwXEAypuTHDTmUwzl/VozFR8X2AXXkyZfAYlrbG Kkew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=0+Pdrq4/WerNzKl1+qjhj0kJeUudxJk49cInKbnFj4U=; b=yoeibOYfQMzfd0B19k1Wc0uja5iwY6d57c3XQhyfeWkfwoUBkhE8fA8/+9GP3WKY7r 2UuF80QMfNTLSpFGUjhAUaHU7tK1fZ/I38LfTRjce3JUHYTA1fIRbft/EJvIAYGBfzih HZK5KcNQz3rjBhM/vTjpTLfAZi/KROhlPv9+t3ObmPizt4rqtyssUDkriFozTjZNRhQF BUZsRX740dIz5zIlEdSW0CQn2938pMl+IPvKqPzCNsrkoh0WThUKuE/hXX/r7MWfOyDU Sj0aTdloCFPRgK3ixUKaR62zlxTQSa1aUwTQ/d+45p16RxYMzGA26nUb+gbJlbl6Y7wk nCag== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n5si4060301pgc.459.2018.02.21.13.20.06; Wed, 21 Feb 2018 13:20:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751877AbeBUVTa (ORCPT + 99 others); Wed, 21 Feb 2018 16:19:30 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:46956 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751542AbeBUU5X (ORCPT ); Wed, 21 Feb 2018 15:57:23 -0500 Received: by mail.free-electrons.com (Postfix, from userid 110) id 7202420807; Wed, 21 Feb 2018 21:57:21 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail.free-electrons.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.0 Received: from localhost (unknown [88.191.26.124]) by mail.free-electrons.com (Postfix) with ESMTPSA id 080882080B; Wed, 21 Feb 2018 21:56:57 +0100 (CET) From: Alexandre Belloni To: linux-rtc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Alexandre Belloni Subject: [PATCH 022/100] rtc: ds1343: stop validating rtc_time in .read_time Date: Wed, 21 Feb 2018 21:55:17 +0100 Message-Id: <20180221205635.31314-23-alexandre.belloni@bootlin.com> X-Mailer: git-send-email 2.16.1 In-Reply-To: <20180221205635.31314-1-alexandre.belloni@bootlin.com> References: <20180221205635.31314-1-alexandre.belloni@bootlin.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The RTC core is always calling rtc_valid_tm after the read_time callback. It is not necessary to call it just before returning from the callback. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-ds1343.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-ds1343.c b/drivers/rtc/rtc-ds1343.c index 59d27db2fd37..5208da4cf94a 100644 --- a/drivers/rtc/rtc-ds1343.c +++ b/drivers/rtc/rtc-ds1343.c @@ -254,7 +254,7 @@ static int ds1343_read_time(struct device *dev, struct rtc_time *dt) dt->tm_mon = bcd2bin(buf[5] & 0x1F) - 1; dt->tm_year = bcd2bin(buf[6]) + 100; /* year offset from 1900 */ - return rtc_valid_tm(dt); + return 0; } static int ds1343_set_time(struct device *dev, struct rtc_time *dt) -- 2.16.1